Re: [PATCH 4/6] drm/msm/gem: Stop exposing a page array

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] msm: dead code return ret; in msm_gem_prime_pin()
--

commit bed87911e0269b42805b7cb336b30be286c9a63a
Author: Rob Clark <robin.clark@oss.qualcomm.com>

drm/msm/gem: Stop exposing a page array

This commit converts the remaining callers of msm_gem_pin_pages_locked() and 
msm_gem_get_pages_locked() to directly return an int instead of returning a 
page array. It also renames msm_gem_get_pages_locked() to 
msm_gem_make_resident_locked() to better reflect its purpose.

> diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
> index beb7f22fd6948..b14cda87df4fd 100644
> --- a/drivers/gpu/drm/msm/msm_gem_prime.c
> +++ b/drivers/gpu/drm/msm/msm_gem_prime.c
> @@ -109,7 +109,6 @@ struct dma_buf *msm_gem_prime_export(struct drm_gem_object *obj, int flags)
>  
>  int msm_gem_prime_pin(struct drm_gem_object *obj)
>  {
> -	struct page **pages;
>  	int ret = 0;
>  
>  	if (drm_gem_is_imported(obj))
> @@ -118,9 +117,7 @@ int msm_gem_prime_pin(struct drm_gem_object *obj)
>  	if (to_msm_bo(obj)->flags & MSM_BO_NO_SHARE)
>  		return -EINVAL;
>  
> -	pages = msm_gem_pin_pages_locked(obj);
> -	if (IS_ERR(pages))
> -		ret = PTR_ERR(pages);
> +	return msm_gem_pin_pages_locked(obj);
>  
>  	return ret;

[Severity: Low]
Is this return ret statement now completely unreachable? 

With the direct return of msm_gem_pin_pages_locked() added just above it, 
this looks like it might be dead code left over from the refactoring. Can this 
be safely removed?

>  }
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926183051.25754-1-robin.clark@oss.qualcomm.com?part=4