From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BA27C9832F for ; Mon, 28 Sep 2026 09:21:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 976AB10E8F7; Mon, 28 Sep 2026 09:21:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ORpk0RDv"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3B5F10E8F7 for ; Mon, 28 Sep 2026 09:21:05 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 88997408E2; Mon, 28 Sep 2026 09:21:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35A791F000FF; Mon, 28 Sep 2026 09:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790587265; bh=41dwQvvAj5dS5fS/OFysaZX9DGzlFq1nkfjLPItyE6Y=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ORpk0RDvH4W932V+TJGbFCcF38wAeXEq6IzHQCm+U8qczj/zQ7/Awyz4mbEs9XDsM /aycQ704LkpLFRkbWvj09dv/w2vj/XJyj5ejTeQLqSPwPfMxkx1FQG8ig0u1pSY3Od 8NPD8fYAo5NxZ6u0AVWyEb3CvW4SHzGHXO8NK6VQe6zn1Q8Z7bZZq5r+i8t1tIw85Y POdxfR+RCznaJiK2yhFmKpmwtKr9pH5R+d2hu31ZheJUz4e5iUtOsdyGLeDNRbzVSD CmwwZuu94Gw4fOdd7qy78J563CNvZSe4tp9gv/ydTyefM/M08UHUkMKKCIzsqI/Xmy ZNC+zDbUmfhZg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 5/5] fbcon: Replace fbcon_fill_cursor_mask() with fbcon_cursor_glyph() To: "Thomas Zimmermann" Cc: dri-devel@lists.freedesktop.org, linux-serial@vger.kernel.org In-Reply-To: <20260928085724.41660-6-tzimmermann@suse.de> References: <20260928085724.41660-1-tzimmermann@suse.de> <20260928085724.41660-6-tzimmermann@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Sep 2026 09:21:04 +0000 Message-Id: <20260928092105.35A791F000FF@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > The kernel's font library provides font_glyph_cursor() to create cursor > glyphs. Replace fbcon's fbcon_fill_cursor_mask() with a new helper that > uses font_glyph_cursor(). >=20 > The cursor shapes remain mostly unchanged. The only exception is in > underline cursors for fonts with a size larger than 10. The underlining > dash is now one pixel closer to the font-glyph data, so that the cursor > looks less detached. This follows the style used by vgacon. >=20 > v2: > - adapt to new VT interface >=20 > Signed-off-by: Thomas Zimmermann Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260928085724.4166= 0-1-tzimmermann@suse.de?part=3D5