Re: [RFC PATCH v4 2/3] rust: DmaFence: Implement Deref for FenceContext

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: dma_fence: missing #[inline] on FenceContext::deref
--

commit 4617358e176ca58ef1fbb67c98355887062d6801
Author: Philipp Stanner <phasta@kernel.org>

rust: DmaFence: Implement Deref for FenceContext

This commit implements the Deref trait for FenceContext, allowing users
to directly access the underlying data field.

> diff --git a/rust/kernel/dma_buf/dma_fence.rs b/rust/kernel/dma_buf/dma_fence.rs
> index eef2b9e93f356..0028124e6aa64 100644
> --- a/rust/kernel/dma_buf/dma_fence.rs
> +++ b/rust/kernel/dma_buf/dma_fence.rs
[ ... ]
> @@ -86,6 +86,14 @@ pub struct FenceContext<T: FenceContextOps + Send + Sync> {
>      data: T,
>  }
>  
> +impl<T: Send + Sync + FenceContextOps> Deref for FenceContext<T> {
> +    type Target = T;
> +
> +    fn deref(&self) -> &Self::Target {

[Severity: Low]
Should this method be annotated with #[inline]?

According to the Rust subsystem guidelines, small functions in abstraction
crates like the kernel crate should be annotated with the #[inline] attribute
to ensure optimal inlining across crate boundaries. The newly added deref
method is a trivial one-line accessor but lacks this attribute.

> +        &self.data
> +    }
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929104703.934128-2-phasta@kernel.org?part=2