From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1FD8CA5FFC for ; Tue, 6 Oct 2026 21:36:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CDE710E76F; Tue, 6 Oct 2026 21:36:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="LEA/N8ye"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01BE710E76F for ; Tue, 6 Oct 2026 21:36:53 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1FC95602BA; Tue, 6 Oct 2026 21:36:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A12C71F0089C; Tue, 6 Oct 2026 21:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791322611; bh=jO1rNsL4MEoaqt+EDLxFDNqJq3+GIguSxOzwozJ8c1U=; h=Date:From:To:Cc:Subject:In-Reply-To; b=LEA/N8yeHjy4SYd/wWMhspV55RDyEFyUH6Gre+O+y20X2dHCZ1VFdedVDBcYMVPZ7 zAQRArHg7K0x2xZjt3tcjC22uKAUZj7ltbiMBw3d8zzcau5qTw9t2THEcpwtGtiuqG UA5sTicyur71JTs5u4w0kHbViIyDDfC+0SNRqiPMfGdKnoxy1dDc51wm4YviLXFrkO PXMqpvagxGWh6FDj4b8h1D3HCvc6HBkTzWBKD/dzMzJ5FJdQHxqajQCxrgv0asCl0A 4ygRC49Ss94R002VvZYzG+uq/wLAf/KwzPwSCc6Runw8uTU9U1vPar+HhcmP+tPUTQ 6yb9hL78+a0rQ== Date: Tue, 6 Oct 2026 16:36:50 -0500 From: Bjorn Helgaas To: Leon Romanovsky Cc: Bjorn Helgaas , Logan Gunthorpe , Jason Gunthorpe , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Christian =?utf-8?B?S8O2bmln?= , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux.dev, Tushar Dave , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org, kvm@vger.kernel.org, Chaitanya Kulkarni , Greg Kroah-Hartman , Jens Axboe , Alex Williamson , Ankit Agrawal , Jonathan Corbet , Shuah Khan , Randy Dunlap , Sumit Semwal Subject: Re: [PATCH v9 00/18] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Message-ID: <20261006213650.GA716945@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261006212227.GB7822@unreal> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 07, 2026 at 12:22:27AM +0300, Leon Romanovsky wrote: > On Tue, Oct 06, 2026 at 02:29:55PM -0500, Bjorn Helgaas wrote: > > On Thu, Oct 01, 2026 at 02:55:08PM +0300, Leon Romanovsky wrote: > > > PCI P2PDMA applies Request and Completion Redirect throughout both paths. > > > This misclassifies asymmetric and nested switches, and reports one answer > > > for every kind of TLP. > > > > > > Three ACS controls act on TLP attributes the client chooses rather than > > > on the topology: Translation Blocking and Direct Translated P2P act on > > > a Request's Address Type, and Completion Redirect skips Completions carrying > > > Relaxed Ordering. > > > > > > Evaluate each direction at the path divergence, decide every class from the > > > one walk, and treat a client with ATS enabled as translating unless its > > > driver declares per-mapping ATS. > > > > > > This completes the P2PDMA side; dma-buf and mlx5 follow separately. > > > ... > > > > > Leon Romanovsky (18): > > > PCI/P2PDMA: Document the TLP attribute assumptions > > > PCI/P2PDMA: Derive routing from directional ACS controls > > > PCI: Reject unreadable ACS controls in isolation checks > > > PCI/P2PDMA: Evaluate ACS controls at the path divergence > > > PCI/P2PDMA: Document directional ACS routing > > > PCI/P2PDMA: Collect the path's ACS controls before deciding > > > PCI/P2PDMA: Answer routing per TLP class > > > PCI/P2PDMA: Route Relaxed Ordering Completions directly > > > PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking > > > PCI/P2PDMA: Route Translated Requests under Direct Translated P2P > > > PCI/P2PDMA: Log detailed ACS routing diagnostics > > > PCI/P2PDMA: Add KUnit tests for the ACS routing decisions > > > PCI/P2PDMA: Test the ACS P2P routing walk > > > PCI: Add KUnit coverage for ACS isolation checks > > > PCI/P2PDMA: Document TLP-class routing > > > PCI/P2PDMA: Let a client declare that it selects ATS per mapping > > > PCI/P2PDMA: Evaluate the ATS path for clients with ATS enabled > > > PCI/P2PDMA: Test the routing of clients with ATS enabled > > > > > > Documentation/admin-guide/kernel-parameters.txt | 15 +- > > > Documentation/driver-api/pci/p2pdma.rst | 80 +++ > > > drivers/pci/Kconfig | 15 + > > > drivers/pci/Makefile | 1 + > > > drivers/pci/p2pdma.c | 719 ++++++++++++++++++-- > > > drivers/pci/pci.c | 7 +- > > > drivers/pci/pci.h | 58 ++ > > > drivers/pci/pci_acs_test.c | 860 ++++++++++++++++++++++++ > > > drivers/pci/quirks.c | 6 +- > > > include/linux/pci-p2pdma.h | 12 +- > > > 10 files changed, 1687 insertions(+), 86 deletions(-) > > > --- > > > base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72 > > > change-id: 20260821-fix-p2p-acs-v4-0-e72455e3a261 > > > prerequisite-message-id: <20260830-batch-p2p-fixes-v1-0-5044e8dfbe2e@nvidia.com> > > > prerequisite-patch-id: 6b25c7fcf164cdfc14e9fac5b908d97fcf6509d7 > > > prerequisite-patch-id: 0d083c281001365aae4b35544cf28891a6ab9a96 > > > prerequisite-patch-id: bfd9dabf271f3cc9a3a61f46387d20c20311363d > > > prerequisite-patch-id: fad0275efc722830fc591509506c0a5e4f581073 > > > prerequisite-patch-id: 0c83bee688fec1f6d1564654df7c630fa6a4a978 > > > > This seems like material for the PCI tree, but I'm not sure how to > > apply it. It doesn't apply cleanly on the current pci/p2pdma > > (https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=p2pdma), > > which does contain your series from > > 20260830-batch-p2p-fixes-v1-0-5044e8dfbe2e@nvidia.com. > > > > I could probably fix the conflicts but I don't know why there should > > be conflicts, since the only commits on pci/p2pdma other than yours > > are a few trivial allow-list updates. > > So maybe this is related to these trivial updates, my series was based > on the clean p2pdma branch: > https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=fix-p2p-acs-v9 Ah, yeah, it must be the allow-list additions that I have but you don't. I wouldn't have thought the offsets would have been a problem.