From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9790606A325 for ; Fri, 20 Nov 2026 11:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KX0JszoF Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5F3511291E; Fri, 20 Nov 2026 11:27:37 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34AA111291A for ; Fri, 20 Nov 2026 11:27:32 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B837A45BA3; Fri, 20 Nov 2026 11:27:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02DC41F000D4; Fri, 20 Nov 2026 11:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795174051; bh=ASWa0rCwAwWSXr/9bmTm1YRMhd5ao8PveDcuQoxadiY=; h=From:To:Cc:Subject:Date; b=KX0JszoFy7WOkRSRQohyhEw9oq4ueePNK9uZIe3F3UiFaAwOojTr9CEp33d2MRDGZ wWGS5pw1soMSNX9fZm/0umk685jRuj+HkLdkVEVvLwWVix2OixHZyN21X1KeNk4Ze9 4OcRAsXq/towdZxjlkR1K6e/HqqU/9S6ACCTW5xgxM8WLa8WsIpwWVl+qJangn0kK0 4LgMZ0XfaaB96DWY6rxptGSHbWMMxVZod/Lchmx6QTKtWjh2RocMjU2ZGNDnpsYLCs Mqqdonhxc6HuRg0SQnQS1PQpex3OFYVEkwQVQ/I3YgB3JVnWCwYPfEsPEX7A5N9k+R mpz4/6FOnJbrw== From: Philipp Stanner To: Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Philipp Stanner , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] dma-buf/dma-fence: Remove dma_fence_later() Date: Fri, 20 Nov 2026 12:27:04 +0100 Message-ID: <20261120112702.2970576-3-phasta@kernel.org> X-Mailer: git-send-email 2.56.0 X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 dma_fence_later() does not have any in-tree users anymore. dma_fence_is_later() is available as an alternative. Remove the surplus function. Signed-off-by: Philipp Stanner Reviewed-by: Christian König --- Changes in v2: - Rebase onto misc-next due to conflict. - Add Christian's Rb. --- drivers/dma-buf/dma-fence.c | 3 --- include/linux/dma-fence.h | 26 -------------------------- 2 files changed, 29 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 0776ca7c795e..ab02afdb0f18 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -1115,9 +1115,6 @@ static bool dma_fence_flags_valid(unsigned long flags) * refcount after committing with this fence, but it will need to hold a * refcount again if &dma_fence_ops.enable_signaling gets called. * - * context and seqno are used for easy comparison between fences, allowing - * to check which fence is later by simply using dma_fence_later(). - * * External locks are a relic of legacy use cases that needed a shared lock * to serialize signaling when no out-of-order signaling was possible through * &dma_fence_ops.signaled. Drivers have abandoned this concept since the diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index 56c4e5beaafe..513d9dbbff47 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-fence.h @@ -626,32 +626,6 @@ static inline bool dma_fence_is_later_or_same(struct dma_fence *f1, return f1 == f2 || dma_fence_is_later(f1, f2); } -/** - * dma_fence_later - return the chronologically later fence - * @f1: the first fence from the same context - * @f2: the second fence from the same context - * - * Returns NULL if both fences are signaled, otherwise the fence that would be - * signaled last. Both fences must be from the same context, since a seqno is - * not re-used across contexts. - */ -static inline struct dma_fence *dma_fence_later(struct dma_fence *f1, - struct dma_fence *f2) -{ - if (WARN_ON(f1->context != f2->context)) - return NULL; - - /* - * Can't check just DMA_FENCE_FLAG_SIGNALED_BIT here, it may never - * have been set if enable_signaling wasn't called, and enabling that - * here is overkill. - */ - if (dma_fence_is_later(f1, f2)) - return dma_fence_is_signaled(f1) ? NULL : f1; - else - return dma_fence_is_signaled(f2) ? NULL : f2; -} - /** * dma_fence_get_status_locked - returns the status upon completion * @fence: the dma_fence to query -- 2.56.0