From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frediano Ziglio Subject: Re: [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged Date: Mon, 31 Oct 2016 08:00:09 -0400 (EDT) Message-ID: <2100365690.7702214.1477915209986.JavaMail.zimbra@redhat.com> References: <20161028121227.16904-1-cfergeau@redhat.com> <20161028121227.16904-6-cfergeau@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161028121227.16904-6-cfergeau@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spice-devel-bounces@lists.freedesktop.org Sender: "Spice-devel" To: Christophe Fergeau Cc: spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org PiAKPiBXaGVuIHRoZSBRWEwgZHJpdmVyIHJlY2VpdmVzIGEgUVhMX0lOVEVSUlVQVF9DTElFTlRf TU9OSVRPUlNfQ09ORklHCj4gaW50ZXJydXB0LAo+IHdlIGN1cnJlbnRseSBhbHdheXMgbm90aWZ5 IHVzZXJzcGFjZSB0aGF0IHRoZXJlIHdhcyBzb21lIGhvdHBsdWcgZXZlbnQuCj4gCj4gSG93ZXZl ciwgZ25vbWUtc2hlbGwvbXV0dGVyIGlzIHJlYWN0aW5nIHRvIHRoaXMgZXZlbnQgYnkgYXR0ZW1w dGluZyBhCj4gcmVzb2x1dGlvbiBjaGFuZ2UsIHdoaWNoIGl0IGRvZXMgYnkgaXNzdWVpbmcgZHJt TW9kZVJtRkIsIGRybU1vZGVBZGRGQiwKPiBhbmQgdGhlbiBkcm1Nb2RlU2V0Q3J0Yy4gVGhpcyBo YXMgdGhlIHNpZGUtZWZmZWN0IG9mIGNhdXNpbmcKPiBxeGxfY3J0Y19tb2RlX3NldCgpIHRvIHRl bGwgdGhlIFFYTCB2aXJ0dWFsIGhhcmR3YXJlIHRoYXQgYSBwcmltYXJ5Cj4gc3VyZmFjZSB3YXMg ZGVzdHJveWVkIGFuZCBjcmVhdGVkLiBBZnRlciBnb2luZyB0aHJvdWdoIFFFTVUgYW5kIHRoZW4g dGhlCj4gcmVtb3RlIFNQSUNFIGNsaWVudCwgYSBuZXcgaWRlbnRpY2FsIG1vbml0b3JzIGNvbmZp ZyBtZXNzYWdlIHdpbGwgYmUKPiBzZW50LCByZXN1bHRpbmcgaW4gYSBRWExfSU5URVJSVVBUX0NM SUVOVF9NT05JVE9SU19DT05GSUcgaW50ZXJydXB0IHRvCj4gYmUgZW1pdHRlZCwgYW5kIHRoZSBz YW1lIHNjZW5hcmlvIG9jY3VycmluZyBhZ2Fpbi4KPiAKPiBBcyBkZXN0cm95aW5nL2NyZWF0aW5n IHRoZSBwcmltYXJ5IHN1cmZhY2UgY2F1c2VzIGEgdmlzaWJsZSBzY3JlZW4KPiBmbGlja2VyLCB0 aGlzIG1ha2VzIHRoZSBndWVzdCBoYXJkIHRvIHVzZSAoCj4gaHR0cHM6Ly9idWd6aWxsYS5yZWRo YXQuY29tL3Nob3dfYnVnLmNnaT9pZD0xMjY2NDg0ICkuCj4gCj4gVGhpcyBjb21taXQgY2hlY2tz IGlmIHRoZSBzY3JlZW4gY29uZmlndXJhdGlvbiB3ZSByZWNlaXZlZCBpcyB0aGUgc2FtZQo+IG9u ZSBhcyB0aGUgY3VycmVudCBvbmUsIGFuZCBkb2VzIG5vdCBub3RpZnkgdXNlcnNwYWNlIGFib3V0 IGl0IGlmIHRoYXQncwo+IHRoZSBjYXNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waGUg RmVyZ2VhdSA8Y2ZlcmdlYXVAcmVkaGF0LmNvbT4KCkdyZWF0IG1lc3NhZ2UhCgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMgfCA2NQo+ICArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDU1IGluc2VydGlvbnMo KyksIDEwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcXhs L3F4bF9kaXNwbGF5LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+IGlu ZGV4IDE1NmI3ZGUuLmVkYjkwZjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3F4bC9x eGxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZGlzcGxheS5jCj4g QEAgLTU3LDExICs1NywxOCBAQCBzdGF0aWMgdm9pZCBxeGxfYWxsb2NfY2xpZW50X21vbml0b3Jz X2NvbmZpZyhzdHJ1Y3QKPiBxeGxfZGV2aWNlICpxZGV2LCB1bnNpZ25lZCBjCj4gIAlxZGV2LT5j bGllbnRfbW9uaXRvcnNfY29uZmlnLT5jb3VudCA9IGNvdW50Owo+ICB9Cj4gIAo+ICtlbnVtIE1v bml0b3JzQ29uZmlnQ29weVN0YXR1cyB7Cj4gKwlNT05JVE9SU19DT05GSUdfQ09QSUVELAo+ICsJ TU9OSVRPUlNfQ09ORklHX1VOQ0hBTkdFRCwKPiArCU1PTklUT1JTX0NPTkZJR19CQURfQ1JDLAo+ ICt9Owo+ICsKCkkgZG9uJ3QgcmVtZW1iZXIgZXhhY3RseSBrZXJuZWwgc3R5bGUsIGEgCgp0eXBl ZGVmIGVudW0gewoJTU9OSVRPUlNfQ09ORklHX0NPUElFRCwKCU1PTklUT1JTX0NPTkZJR19VTkNI QU5HRUQsCglNT05JVE9SU19DT05GSUdfQkFEX0NSQywKfSBNb25pdG9yc0NvbmZpZ0NvcHlTdGF0 dXM7Cgpjb3VsZCBtYWtlIGZvbGxvd2luZyBjb2RlIHNob3J0ZXIuCgo+ICBzdGF0aWMgaW50IHF4 bF9kaXNwbGF5X2NvcHlfcm9tX2NsaWVudF9tb25pdG9yc19jb25maWcoc3RydWN0IHF4bF9kZXZp Y2UKPiAgKnFkZXYpCgp3aHkgbm90IHJldHVybmluZyBNb25pdG9yc0NvbmZpZ0NvcHlTdGF0dXMg PwoKPiAgewo+ICAJaW50IGk7Cj4gIAlpbnQgbnVtX21vbml0b3JzOwo+ICAJdWludDMyX3QgY3Jj Owo+ICsJYm9vbCBjaGFuZ2VkID0gZmFsc2U7Cj4gIAoKdXNpbmcgYSAiTW9uaXRvcnNDb25maWdD b3B5U3RhdHVzIHJlcyA9IE1PTklUT1JTX0NPTkZJR19VTkNIQU5HRUQiIGhlcmUKY291bGQgbWFr ZSByZXR1cm4gc3RhdGVtZW50IHNob3J0ZXIuCgo+ICAJbnVtX21vbml0b3JzID0gcWRldi0+cm9t LT5jbGllbnRfbW9uaXRvcnNfY29uZmlnLmNvdW50Owo+ICAJY3JjID0gY3JjMzIoMCwgKGNvbnN0 IHVpbnQ4X3QgKikmcWRldi0+cm9tLT5jbGllbnRfbW9uaXRvcnNfY29uZmlnLAo+IEBAIC03MCw3 ICs3Nyw3IEBAIHN0YXRpYyBpbnQKPiBxeGxfZGlzcGxheV9jb3B5X3JvbV9jbGllbnRfbW9uaXRv cnNfY29uZmlnKHN0cnVjdCBxeGxfZGV2aWNlICpxZGV2KQo+ICAJCXF4bF9pb19sb2cocWRldiwg ImNyYyBtaXNtYXRjaDogaGF2ZSAlWCAoJXpkKSAhPSAlWFxuIiwgY3JjLAo+ICAJCQkgICBzaXpl b2YocWRldi0+cm9tLT5jbGllbnRfbW9uaXRvcnNfY29uZmlnKSwKPiAgCQkJICAgcWRldi0+cm9t LT5jbGllbnRfbW9uaXRvcnNfY29uZmlnX2NyYyk7Cj4gLQkJcmV0dXJuIDE7Cj4gKwkJcmV0dXJu IE1PTklUT1JTX0NPTkZJR19CQURfQ1JDOwo+ICAJfQo+ICAJaWYgKG51bV9tb25pdG9ycyA+IHFk ZXYtPm1vbml0b3JzX2NvbmZpZy0+bWF4X2FsbG93ZWQpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJj bGllbnQgbW9uaXRvcnMgbGlzdCB3aWxsIGJlIHRydW5jYXRlZDogJWQgPCAlZFxuIiwKPiBAQCAt NzksNiArODYsMTAgQEAgc3RhdGljIGludAo+IHF4bF9kaXNwbGF5X2NvcHlfcm9tX2NsaWVudF9t b25pdG9yc19jb25maWcoc3RydWN0IHF4bF9kZXZpY2UgKnFkZXYpCj4gIAl9IGVsc2Ugewo+ICAJ CW51bV9tb25pdG9ycyA9IHFkZXYtPnJvbS0+Y2xpZW50X21vbml0b3JzX2NvbmZpZy5jb3VudDsK PiAgCX0KPiArCWlmIChxZGV2LT5jbGllbnRfbW9uaXRvcnNfY29uZmlnCj4gKwkgICAgICAmJiAo bnVtX21vbml0b3JzICE9IHFkZXYtPmNsaWVudF9tb25pdG9yc19jb25maWctPmNvdW50KSkgewo+ ICsJCWNoYW5nZWQgPSB0cnVlOwo+ICsJfQo+ICAJcXhsX2FsbG9jX2NsaWVudF9tb25pdG9yc19j b25maWcocWRldiwgbnVtX21vbml0b3JzKTsKPiAgCS8qIHdlIGNvcHkgbWF4IGZyb20gdGhlIGNs aWVudCBidXQgaXQgaXNuJ3QgdXNlZCAqLwo+ICAJcWRldi0+Y2xpZW50X21vbml0b3JzX2NvbmZp Zy0+bWF4X2FsbG93ZWQgPQo+IEBAIC04OCwxNyArOTksNDIgQEAgc3RhdGljIGludAo+IHF4bF9k aXNwbGF5X2NvcHlfcm9tX2NsaWVudF9tb25pdG9yc19jb25maWcoc3RydWN0IHF4bF9kZXZpY2Ug KnFkZXYpCj4gIAkJCSZxZGV2LT5yb20tPmNsaWVudF9tb25pdG9yc19jb25maWcuaGVhZHNbaV07 Cj4gIAkJc3RydWN0IHF4bF9oZWFkICpjbGllbnRfaGVhZCA9Cj4gIAkJCSZxZGV2LT5jbGllbnRf bW9uaXRvcnNfY29uZmlnLT5oZWFkc1tpXTsKPiAtCQljbGllbnRfaGVhZC0+eCA9IGNfcmVjdC0+ bGVmdDsKPiAtCQljbGllbnRfaGVhZC0+eSA9IGNfcmVjdC0+dG9wOwo+IC0JCWNsaWVudF9oZWFk LT53aWR0aCA9IGNfcmVjdC0+cmlnaHQgLSBjX3JlY3QtPmxlZnQ7Cj4gLQkJY2xpZW50X2hlYWQt PmhlaWdodCA9IGNfcmVjdC0+Ym90dG9tIC0gY19yZWN0LT50b3A7Cj4gLQkJY2xpZW50X2hlYWQt PnN1cmZhY2VfaWQgPSAwOwo+IC0JCWNsaWVudF9oZWFkLT5pZCA9IGk7Cj4gLQkJY2xpZW50X2hl YWQtPmZsYWdzID0gMDsKPiArCQlpZiAoY2xpZW50X2hlYWQtPnggIT0gY19yZWN0LT5sZWZ0KSB7 Cj4gKwkJCWNsaWVudF9oZWFkLT54ID0gY19yZWN0LT5sZWZ0Owo+ICsJCQljaGFuZ2VkID0gdHJ1 ZTsKPiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT55ICE9IGNfcmVjdC0+dG9wKSB7Cj4gKwkJ CWNsaWVudF9oZWFkLT55ID0gY19yZWN0LT50b3A7Cj4gKwkJCWNoYW5nZWQgPSB0cnVlOwo+ICsJ CX0KPiArCQlpZiAoY2xpZW50X2hlYWQtPndpZHRoICE9IGNfcmVjdC0+cmlnaHQgLSBjX3JlY3Qt PmxlZnQpIHsKPiArCQkJY2xpZW50X2hlYWQtPndpZHRoID0gY19yZWN0LT5yaWdodCAtIGNfcmVj dC0+bGVmdDsKPiArCQkJY2hhbmdlZCA9IHRydWU7Cj4gKwkJfQo+ICsJCWlmIChjbGllbnRfaGVh ZC0+aGVpZ2h0ICE9IGNfcmVjdC0+Ym90dG9tIC0gY19yZWN0LT50b3ApIHsKPiArCQkJY2xpZW50 X2hlYWQtPmhlaWdodCA9IGNfcmVjdC0+Ym90dG9tIC0gY19yZWN0LT50b3A7Cj4gKwkJCWNoYW5n ZWQgPSB0cnVlOwo+ICsJCX0KPiArCQlpZiAoY2xpZW50X2hlYWQtPnN1cmZhY2VfaWQgIT0gMCkg ewo+ICsJCQljbGllbnRfaGVhZC0+c3VyZmFjZV9pZCA9IDA7Cj4gKwkJCWNoYW5nZWQgPSB0cnVl Owo+ICsJCX0KPiArCQlpZiAoY2xpZW50X2hlYWQtPmlkICE9IGkpIHsKPiArCQkJY2xpZW50X2hl YWQtPmlkID0gaTsKPiArCQkJY2hhbmdlZCA9IHRydWU7Cj4gKwkJfQoKcXVpdGUgc2ltaWxhciBj b2RlLi4uIEkgd291bGQgd3JpdGUgYSBtYWNybyBidXQgSSdtIGEgdG9vIG1hY3JvIGZ1biA6KQpX b3VsZCBiZSBzb21ldGhpbmcgbGlrZSB0aGlzCgoJaWYgKGNsaWVudF9oZWFkLT5pZCAhPSBpKQoJ CXJlcyA9IE1PTklUT1JTX0NPTkZJR19DT1BJRUQ7CgljbGllbnRfaGVhZC0+aWQgPSBpOwoKbWFr ZSBzZW5zZT8KCj4gKwkJaWYgKGNsaWVudF9oZWFkLT5mbGFncyAhPSAwKSB7Cj4gKwkJCWNsaWVu dF9oZWFkLT5mbGFncyA9IDA7Cj4gKwkJCWNoYW5nZWQgPSB0cnVlOwo+ICsJCX0KCndoeSB0ZXN0 aW5nIGZsYWdzIGNoYW5nZSBpZiBpcyBhbHdheXMgMCA/Cgo+ICAJCURSTV9ERUJVR19LTVMoInJl YWQgJWR4JWQrJWQrJWRcbiIsIGNsaWVudF9oZWFkLT53aWR0aCwKPiAgCQljbGllbnRfaGVhZC0+ aGVpZ2h0LAo+ICAJCQkgIGNsaWVudF9oZWFkLT54LCBjbGllbnRfaGVhZC0+eSk7Cj4gIAl9Cj4g LQlyZXR1cm4gMDsKPiArCWlmIChjaGFuZ2VkKSB7Cj4gKwkJcmV0dXJuIE1PTklUT1JTX0NPTkZJ R19DT1BJRUQ7Cj4gKwl9IGVsc2Ugewo+ICsJCXJldHVybiBNT05JVE9SU19DT05GSUdfVU5DSEFO R0VEOwo+ICsJfQoKSGVyZSBpdCB3b3VsZCBiZSBqdXN0ICJyZXR1cm4gcmVzOyIuCgo+ICB9Cj4g IAo+ICBzdGF0aWMgdm9pZCBxeGxfdXBkYXRlX29mZnNldF9wcm9wcyhzdHJ1Y3QgcXhsX2Rldmlj ZSAqcWRldikKPiBAQCAtMTI0LDkgKzE2MCwxOCBAQCB2b2lkIHF4bF9kaXNwbGF5X3JlYWRfY2xp ZW50X21vbml0b3JzX2NvbmZpZyhzdHJ1Y3QKPiBxeGxfZGV2aWNlICpxZGV2KQo+ICB7Cj4gIAo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHFkZXYtPmRkZXY7Cj4gLQl3aGlsZSAocXhsX2Rp c3BsYXlfY29weV9yb21fY2xpZW50X21vbml0b3JzX2NvbmZpZyhxZGV2KSkgewo+ICsJZW51bSBN b25pdG9yc0NvbmZpZ0NvcHlTdGF0dXMgc3RhdHVzOwo+ICsKPiArCXN0YXR1cyA9IHF4bF9kaXNw bGF5X2NvcHlfcm9tX2NsaWVudF9tb25pdG9yc19jb25maWcocWRldik7Cj4gKwl3aGlsZSAoc3Rh dHVzID09IE1PTklUT1JTX0NPTkZJR19CQURfQ1JDKSB7Cj4gIAkJcXhsX2lvX2xvZyhxZGV2LCAi ZmFpbGVkIGNyYyBjaGVjayBmb3IgY2xpZW50X21vbml0b3JzX2NvbmZpZywiCj4gIAkJCQkgIiBy ZXRyeWluZ1xuIik7Cj4gKwkJc3RhdHVzID0gcXhsX2Rpc3BsYXlfY29weV9yb21fY2xpZW50X21v bml0b3JzX2NvbmZpZyhxZGV2KTsKPiArCX0KClVzdWFsbHkgSSB3b3VsZCB3cml0ZSBzb21ldGhp bmcgbGlrZQoKCWZvciAoOzspIHsKCQlzdGF0dXMgPSBxeGxfZGlzcGxheV9jb3B5X3JvbV9jbGll bnRfbW9uaXRvcnNfY29uZmlnKHFkZXYpOwoJCWlmIChzdGF0dXMgIT0gTU9OSVRPUlNfQ09ORklH X0JBRF9DUkMpCgkJCWJyZWFrOwoJCXF4bF9pb19sb2cocWRldiwgImZhaWxlZCBjcmMgY2hlY2sg Zm9yIGNsaWVudF9tb25pdG9yc19jb25maWcsIgoJCQkJICIgcmV0cnlpbmdcbiIpOwoJfQoKb3IK Cgl3aGlsZSAoKHN0YXR1cyA9IHF4bF9kaXNwbGF5X2NvcHlfcm9tX2NsaWVudF9tb25pdG9yc19j b25maWcocWRldikpCgkJPT0gIE1PTklUT1JTX0NPTkZJR19CQURfQ1JDKSB7CgkJcXhsX2lvX2xv ZyhxZGV2LCAiZmFpbGVkIGNyYyBjaGVjayBmb3IgY2xpZW50X21vbml0b3JzX2NvbmZpZywiCgkJ CQkgIiByZXRyeWluZ1xuIik7Cgl9CgooanVzdCBzdHlsZSBhbmQgcHJvYmFibHkgaW5kZW50YXRp b24gaXMgZXZlbiB3cm9uZykKCj4gKwlpZiAoc3RhdHVzID09IE1PTklUT1JTX0NPTkZJR19VTkNI QU5HRUQpIHsKPiArCQlxeGxfaW9fbG9nKHFkZXYsICJjb25maWcgdW5jaGFuZ2VkXG4iKTsKPiAr CQlEUk1fREVCVUcoImlnbm9yaW5nIHVuY2hhbmdlZCBjbGllbnQgbW9uaXRvcnMgY29uZmlnIik7 Cj4gKwkJcmV0dXJuOwo+ICAJfQo+ICAKPiAgCWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRldik7CgpC ZXNpZGUgYWxsIHRoYXQgc3R5bGUgcGFyYW5vaWEvb3BpbmlvbnM6CgpBY2tlZC1ieTogRnJlZGlh bm8gWmlnbGlvIDxmemlnbGlvQHJlZGhhdC5jb20+CgooZmVlbCBmcmVlIHRvIHRha2UgaW50byBh Y2NvdW50IHNvbWUgb3Igbm9uZSBvZiB0aGVtKS4KCkZyZWRpYW5vCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClNwaWNlLWRldmVsIG1haWxpbmcgbGlzdApT cGljZS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9zcGljZS1kZXZlbAo=