From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14E54C83F33 for ; Mon, 4 Sep 2023 07:55:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2886310E2C5; Mon, 4 Sep 2023 07:54:59 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 528C210E2C5 for ; Mon, 4 Sep 2023 07:54:55 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 08DE4B80DBC; Mon, 4 Sep 2023 07:54:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DACFC433CA; Mon, 4 Sep 2023 07:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693814092; bh=xc2YozwhEL1/YHfZS9+Y6217G0tcKGwiBjaWl0K5Cyk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=jKFwPbfSBENdrDNjfQ8bpT1Dix0QCVFSi5ovbrgJS0uEVftPoNyXoUuP6gVc9JunW FHGntM8knG/xiqDkWNCs2cyl3eqPYwm0MqApy2EWxZqYFItZ231AtG+GYiTzaus5Z9 CL3JV0sbNTvw+oytnh6OtoqVZjB+qbhDnZmKex3uq9ym3hakXR1HyL1trh0iOBgYG0 BL8IBJUYCFPS//OQ+OgdVDkCD35Hd9RNIuiXg0VRqqaz6GXuQ5esDAUBCuUSmyJqSO gv7QrMhn6gM/bUDaK/+6PF9HJGdh6qqK1W3og5GwMglhsxPp9q/bWUrSUE0cL4a8eD 39zB18X/OK3yQ== Message-ID: <22638b6d731fdcb29367c90461cf0154.mripard@kernel.org> Date: Mon, 04 Sep 2023 07:54:50 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 11/15] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time In-Reply-To: <20230901164111.RFT.11.Iea33274908b6b258955f45a8aaf6f5bba24ad6cd@changeid> References: <20230901164111.RFT.11.Iea33274908b6b258955f45a8aaf6f5bba24ad6cd@changeid> Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org, Maxime Ripard , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 1 Sep 2023 16:41:22 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time > and at driver unbind time. Among other things, this means that if a > panel is in use that it won't be cleanly powered off at system > shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime