From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 05/32] drm/exynos: hdmi: Implement initialize op for
	hdmi
Date: Fri, 01 Nov 2013 20:56:40 +0100
Message-ID: <2285624.MYl7KV3BUH@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<32941501.gnCjUuNFa9@flatron>
	<CAOw6vbLKWAr1soz2n3LNJimerdvCh3dmwMSs=TsjtDgxxf6Zsw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-bk0-f50.google.com (mail-bk0-f50.google.com
	[209.85.214.50])
	by gabe.freedesktop.org (Postfix) with ESMTP id 22D03F0799
	for <dri-devel@lists.freedesktop.org>;
	Fri,  1 Nov 2013 12:56:38 -0700 (PDT)
Received: by mail-bk0-f50.google.com with SMTP id v4so1997157bkz.9
	for <dri-devel@lists.freedesktop.org>;
	Fri, 01 Nov 2013 12:56:38 -0700 (PDT)
In-Reply-To: <CAOw6vbLKWAr1soz2n3LNJimerdvCh3dmwMSs=TsjtDgxxf6Zsw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>, =?ISO-8859-1?Q?St=E9phane?= Marchesin <marcheu@chromium.org>
List-Id: dri-devel@lists.freedesktop.org

Hi Sean,

On Friday 01 of November 2013 15:54:31 Sean Paul wrote:
> On Thu, Oct 31, 2013 at 7:53 PM, Tomasz Figa <tomasz.figa@gmail.com> 
wrote:
> > Hi Sean,
> > 
> > On Tuesday 29 of October 2013 12:12:51 Sean Paul wrote:
[snip]
> >> @@ -995,6 +1000,9 @@ static irqreturn_t mixer_irq_handler(int irq,
> >> void
> >> *arg) /* read interrupt status for handling and clearing flags for
> >> VSYNC */ val = mixer_reg_read(res, MXR_INT_STATUS);
> >> 
> >> +     if (!ctx->drm_dev)
> >> +             goto out;
> > 
> > The patch looks fine, but I'd like you to explain me in what
> > conditions
> > can this condition evaluate to true.
> 
> This can happen if there's a mixer interrupt before the intialize()
> hook is called.

What about making the driver enable the interrupt (or even all the 
hardware) after this hook is called then?

Best regards,
Tomasz