From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Dave Airlie <airlied@redhat.com>,
kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org
Subject: Re: [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear'
Date: Wed, 07 Aug 2013 13:16:21 +0200 [thread overview]
Message-ID: <229314766.ZCcIACZPNp@avalon> (raw)
In-Reply-To: <CANq1E4Q7-rmpWHTZUiaLUaV4-rU+gc48ZoHLJwjZMrsZdcbnTQ@mail.gmail.com>
Hi David,
On Wednesday 07 August 2013 11:57:54 David Herrmann wrote:
> On Wed, Aug 7, 2013 at 10:19 AM, kbuild test robot wrote:
> > tree: git://people.freedesktop.org/~danvet/drm-intel.git
> > drm-intel-nightly head: 3224cf6c3ee5ab9c280052c9fbed4f660310c411
> > commit: 28ec711cd427f8b61f73712a43b8100ba8ca933b [243/249] drm/agp: move
> > AGP cleanup paths to drm_agpsupport.c config: x86_64-randconfig-a02-0807
> > (attached as .config)
> >
> > All error/warnings:
> > drivers/built-in.o: In function `drm_lastclose':
> >>> (.text+0x904a0): undefined reference to `drm_agp_clear'
>
> We called drm_agp_release() in the same code-path before. How did that
> work without CONFIG_AGP? Ugh, *confused*
drm_agp_release() was only called if drm_core_has_AGP() was true, and that
function is defined as a macro that just returns 0 when __OS_HAS_AGP isn't
defined. The compiler thus optimized the drm_agp_release() call away.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2013-08-07 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5202032e.Bh5xEyiO9yK+nGxr%fengguang.wu@intel.com>
2013-08-07 9:57 ` [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear' David Herrmann
2013-08-07 11:16 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229314766.ZCcIACZPNp@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox