From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDDFEC433F5 for ; Mon, 20 Dec 2021 16:53:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA96B10FF6B; Mon, 20 Dec 2021 16:53:18 +0000 (UTC) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EB6210FF58 for ; Mon, 20 Dec 2021 16:53:17 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id d9so1864312wrb.0 for ; Mon, 20 Dec 2021 08:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p9Tx2wH4HEpVybdHYcjlhyrX2v7ZfIvmca5PPAdXN6k=; b=fVQb2iOMp+8XdAiBh3r7/dK9kp/+EyrvqmRClEZfDbVqB1PzXufL4v8IiRsF7HLpoa QLHjSmC4jwYBjekVzIfT47xjwmABDFEr6RRI32lF/f3xa0RBFoXeTK9lAIbfd0SvZIOg DFWeNf1n9jX2+Z4rAPCkuwTUhyDDAOQ1AWLLIesGzavACAbtKZOhjOi61EoF31P5zJ/4 WTk+KRcyYo03rcn4y+nGMJN7FFKPE6biCgCWC2+e3Rgll9+DBMqQhi7fHPQWFFfzoUYc xqJ4k4Ls9vbAbILV0NZI1x1TmEWN4Os/2cvIVhloyPulUbql7QwH+tp3BjZ62/KXWNuS d09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p9Tx2wH4HEpVybdHYcjlhyrX2v7ZfIvmca5PPAdXN6k=; b=DiLBzcyouxqxEb4XksWhLcllPWGR5SVydfO2ccLcq4pmT8hMyDRr06BDNpuwqJt89J FsD0m8rY3rnrSXBhB6pxI0ypNVpi/nkMpxtAuLqMuq8DuMv98JH/f56wviQeRD9i03Ap OMJwlOLoqloNeZYARkj9PDPYoOmNd/YIqCz+oA87JZRnD/bwXCHIiFh4uRZRNuptzVlG dQyANUd1BCll5S6QY/d9X0Dm+gX7n8e+6h373Mc9zVQZOG2JgfmFTNS72j6zt0dFmI2Z 5xnyk4VMuHstwmyNbibxDDXRW8iJxUCVN36eRjuWTgBDxCK33jYajDgk60wRbRRKBLmg rpXg== X-Gm-Message-State: AOAM530bqMoctq3VlKZc+j1tR6hYbndfTGIN7hrCKa5zIiC0tYkraY+X iWEOnMCe5VfQDxwS9XZhCitrxqJtoUI= X-Google-Smtp-Source: ABdhPJx79HzNYw/1/E19mQIiwB8X0jLmD92oBdZER7LrTtQNdGGa5D09PBIWyP79Cz4iHMPyrQd8fA== X-Received: by 2002:adf:9cc2:: with SMTP id h2mr13387161wre.464.1640019196095; Mon, 20 Dec 2021 08:53:16 -0800 (PST) Received: from archbook.localnet ([217.151.114.10]) by smtp.gmail.com with ESMTPSA id p1sm155802wrr.75.2021.12.20.08.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 08:53:15 -0800 (PST) From: Nicolas Frattaroli To: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver Date: Mon, 20 Dec 2021 17:53:14 +0100 Message-ID: <2517243.oazWQlOnO6@archbook> In-Reply-To: <5637649.G3HFo5JPcS@archbook> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-23-s.hauer@pengutronix.de> <5637649.G3HFo5JPcS@archbook> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , Nicolas Frattaroli , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Montag, 20. Dezember 2021 15:16:55 CET Nicolas Frattaroli wrote: > On Montag, 20. Dezember 2021 12:06:30 CET Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip Kernel and > > heavily modified: > > > > - All nonstandard DRM properties have been removed > > - dropped struct vop2_plane_state and pass around less data between > > functions > > - Dropped all DRM_FORMAT_* not known on upstream > > - rework register access to get rid of excessively used macros > > - Drop all waiting for framesyncs > > > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > > > Signed-off-by: Sascha Hauer > > --- > > Hi Sascha, > > sadly I'm getting > > [ 1.668856] rockchip-drm display-subsystem: [drm] *ERROR* failed to get vop2 register byname > [ 1.669621] rockchip-drm display-subsystem: failed to bind fe040000.vop (ops vop2_component_ops): -22 > [ 1.670584] rockchip-drm display-subsystem: master bind failed: -22 > [ 1.671164] dwhdmi-rockchip: probe of fe0a0000.hdmi failed with error -22 > > on a Quartz64 Model A. > > > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs"); > > + if (!res) { > > + drm_err(vop2->drm, "failed to get vop2 register byname\n"); > > + return -EINVAL; > > + } > > This seems to be the code that triggers it. > > Any ideas as to what could be causing this? > > Regards, > Nicolas Frattaroli > A small follow-up: We're trying to get IORESOURCE_MEM by the name "regs", but nothing has a reg-names property in the device tree changes you sent in. How did you test this on your system? Also, adding the reg-names = "regs"; to the vop node doesn't make it probe, it just fails with [ 1.668560] rockchip-vop2 fe040000.vop: can't request region for resource [mem 0xfe040000-0xfe044fff] then. We're also trying to get gamma_lut the same way, but your cover letter states > drop unnecessary gamma_lut registers from vop2 which makes me wonder: is this the correct series of patches you sent in? Regards, Nicolas Frattaroli