From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v3] drm/bridge: analogix_dp: Remove duplicated code Date: Thu, 25 Aug 2016 16:02:26 +0800 Message-ID: <253ab620-e918-64ed-e227-31f952e910e4@rock-chips.com> References: <1472050481-32724-1-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1611168744==" Return-path: Received: from lucky1.263xmail.com (unknown [211.157.147.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76EAB6E007 for ; Thu, 25 Aug 2016 08:03:27 +0000 (UTC) In-Reply-To: <1472050481-32724-1-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , dri-devel@lists.freedesktop.org, tomeu.vizoso@collabora.com, architt@codeaurora.org Cc: daniel.vetter@intel.com, linux-kernel@vger.kernel.org, mika.kahola@intel.com, javier@osg.samsung.com List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1611168744== Content-Type: multipart/alternative; boundary="------------CF202AA10DDA09244BB7706D" This is a multi-part message in MIME format. --------------CF202AA10DDA09244BB7706D Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 08/24/2016 10:54 PM, Sean Paul wrote: > From: Tomeu Vizoso > > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use them instead of duplicating them. > > Signed-off-by: Tomeu Vizoso > Tested-by: Javier Martinez Canillas > Tested-by: Sean Paul > Reviewed-by: Sean Paul > Signed-off-by: Sean Paul > Cc: Javier Martinez Canillas > Cc: Mika Kahola > Cc: Yakir Yang > Cc: Daniel Vetter > Cc: Archit Taneja Reviewed-by: Yakir Yang > --- > > v2: > - A bunch of good fixes from Sean and Yakir > - Moved the transfer function to analogix_dp_reg.c > - Removed reference to the EDID from the dp struct > > v3: > - Rebased on top of Yakir's PSR series > - Fixed checkpatch warning about line length > > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 274 ++++--------- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 40 +- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 451 ++++++--------------- > 3 files changed, 210 insertions(+), 555 deletions(-) --------------CF202AA10DDA09244BB7706D Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/24/2016 10:54 PM, Sean Paul wrote:
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Remove code for reading the EDID and DPCD fields and use the helpers
instead.

Besides the obvious code reduction, other helpers are being added to the
core that could be used in this driver and will be good to be able to
use them instead of duplicating them.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
Tested-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Yakir Yang <ykk@rock-chips.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Archit Taneja <architt@codeaurora.org>

Reviewed-by: Yakir Yang <ykk@rock-chips.com>

---

v2:
    - A bunch of good fixes from Sean and Yakir
    - Moved the transfer function to analogix_dp_reg.c
    - Removed reference to the EDID from the dp struct

v3:
    - Rebased on top of Yakir's PSR series
    - Fixed checkpatch warning about line length


 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 274 ++++---------
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |  40 +-
 drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c  | 451 ++++++---------------
 3 files changed, 210 insertions(+), 555 deletions(-)

--------------CF202AA10DDA09244BB7706D-- --===============1611168744== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1611168744==--