From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put() Date: Thu, 3 Oct 2019 21:21:06 +0200 Message-ID: <25b9614f-d6be-9da5-0fe5-eb58c8c93850@gmail.com> References: <20191003082812.28491-1-jjhiblot@ti.com> <20191003082812.28491-3-jjhiblot@ti.com> <20191003104228.c5nho6eimwzqwxpt@earth.universe> <62591735-9082-1fd7-d791-07929ddaa223@gmail.com> <20191003183554.GA37096@sirena.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20191003183554.GA37096@sirena.co.uk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Jean-Jacques Hiblot , Sebastian Reichel , pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, lee.jones@linaro.org, daniel.thompson@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, dmurphy@ti.com, linux-leds@vger.kernel.org, Liam Girdwood List-Id: dri-devel@lists.freedesktop.org Hi Mark, On 10/3/19 8:35 PM, Mark Brown wrote: > On Thu, Oct 03, 2019 at 07:43:17PM +0200, Jacek Anaszewski wrote: >> On 10/3/19 2:47 PM, Jean-Jacques Hiblot wrote: >>> On 03/10/2019 12:42, Sebastian Reichel wrote: >>>> On Thu, Oct 03, 2019 at 10:28:09AM +0200, Jean-Jacques Hiblot wrote: > > This mail has nothing relevant in the subject line and pages of quotes > before the question for me, it's kind of lucky I noticed it.... Isn't it all about creating proper filters? >> I wonder if it wouldn't make sense to add support for fwnode >> parsing to regulator core. Or maybe it is either somehow supported >> or not supported on purpose? > > Anything attempting to use the regulator DT bindings in ACPI has very > serious problems, ACPI has its own power model which isn't compatible > with that used in DT. We have a means for checking if fwnode refers to of_node: is_of_node(const struct fwnode_handle *fwnode) Couldn't it be employed for OF case? -- Best regards, Jacek Anaszewski