dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: Maciej Falkowski <maciej.falkowski@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, quic_jhugo@quicinc.com, lizhi.hou@amd.com,
	Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
Subject: Re: [PATCH] accel/ivpu: Fix the D0i2 disable test mode
Date: Fri, 25 Apr 2025 10:51:07 +0200	[thread overview]
Message-ID: <261a616d-7eb7-417d-aee8-905f93f78491@linux.intel.com> (raw)
In-Reply-To: <20250416102629.384626-1-maciej.falkowski@linux.intel.com>

Applied to drm-misc-fixes

On 4/16/2025 12:26 PM, Maciej Falkowski wrote:
> From: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
> 
> Correct setup of D0i2 disable which was
> by mistake set up to value 1 and use BIT(1) instead.
> 
> Fixes: 011529fe8112 ("accel/ivpu: Implement D0i2 disable test mode")
> Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
> ---
>  drivers/accel/ivpu/ivpu_fw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
> index 5e1d709c6a46..ccaaf6c100c0 100644
> --- a/drivers/accel/ivpu/ivpu_fw.c
> +++ b/drivers/accel/ivpu/ivpu_fw.c
> @@ -544,7 +544,7 @@ static void ivpu_fw_boot_params_print(struct ivpu_device *vdev, struct vpu_boot_
>  		 boot_params->d0i3_entry_vpu_ts);
>  	ivpu_dbg(vdev, FW_BOOT, "boot_params.system_time_us = %llu\n",
>  		 boot_params->system_time_us);
> -	ivpu_dbg(vdev, FW_BOOT, "boot_params.power_profile = %u\n",
> +	ivpu_dbg(vdev, FW_BOOT, "boot_params.power_profile = 0x%x\n",
>  		 boot_params->power_profile);
>  }
>  
> @@ -646,7 +646,7 @@ void ivpu_fw_boot_params_setup(struct ivpu_device *vdev, struct vpu_boot_params
>  	boot_params->d0i3_residency_time_us = 0;
>  	boot_params->d0i3_entry_vpu_ts = 0;
>  	if (IVPU_WA(disable_d0i2))
> -		boot_params->power_profile = 1;
> +		boot_params->power_profile |= BIT(1);
>  
>  	boot_params->system_time_us = ktime_to_us(ktime_get_real());
>  	wmb(); /* Flush WC buffers after writing bootparams */


      parent reply	other threads:[~2025-04-25  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16 10:26 [PATCH] accel/ivpu: Fix the D0i2 disable test mode Maciej Falkowski
2025-04-18 15:30 ` Jeff Hugo
2025-04-25  8:51 ` Jacek Lawrynowicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=261a616d-7eb7-417d-aee8-905f93f78491@linux.intel.com \
    --to=jacek.lawrynowicz@linux.intel.com \
    --cc=Andrzej.Kacprowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lizhi.hou@amd.com \
    --cc=maciej.falkowski@linux.intel.com \
    --cc=oded.gabbay@gmail.com \
    --cc=quic_jhugo@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).