* [PATCH] accel/ivpu: Fix the D0i2 disable test mode
@ 2025-04-16 10:26 Maciej Falkowski
2025-04-18 15:30 ` Jeff Hugo
2025-04-25 8:51 ` Jacek Lawrynowicz
0 siblings, 2 replies; 3+ messages in thread
From: Maciej Falkowski @ 2025-04-16 10:26 UTC (permalink / raw)
To: dri-devel
Cc: oded.gabbay, quic_jhugo, jacek.lawrynowicz, lizhi.hou,
Andrzej Kacprowski, Maciej Falkowski
From: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
Correct setup of D0i2 disable which was
by mistake set up to value 1 and use BIT(1) instead.
Fixes: 011529fe8112 ("accel/ivpu: Implement D0i2 disable test mode")
Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
---
drivers/accel/ivpu/ivpu_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
index 5e1d709c6a46..ccaaf6c100c0 100644
--- a/drivers/accel/ivpu/ivpu_fw.c
+++ b/drivers/accel/ivpu/ivpu_fw.c
@@ -544,7 +544,7 @@ static void ivpu_fw_boot_params_print(struct ivpu_device *vdev, struct vpu_boot_
boot_params->d0i3_entry_vpu_ts);
ivpu_dbg(vdev, FW_BOOT, "boot_params.system_time_us = %llu\n",
boot_params->system_time_us);
- ivpu_dbg(vdev, FW_BOOT, "boot_params.power_profile = %u\n",
+ ivpu_dbg(vdev, FW_BOOT, "boot_params.power_profile = 0x%x\n",
boot_params->power_profile);
}
@@ -646,7 +646,7 @@ void ivpu_fw_boot_params_setup(struct ivpu_device *vdev, struct vpu_boot_params
boot_params->d0i3_residency_time_us = 0;
boot_params->d0i3_entry_vpu_ts = 0;
if (IVPU_WA(disable_d0i2))
- boot_params->power_profile = 1;
+ boot_params->power_profile |= BIT(1);
boot_params->system_time_us = ktime_to_us(ktime_get_real());
wmb(); /* Flush WC buffers after writing bootparams */
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/ivpu: Fix the D0i2 disable test mode
2025-04-16 10:26 [PATCH] accel/ivpu: Fix the D0i2 disable test mode Maciej Falkowski
@ 2025-04-18 15:30 ` Jeff Hugo
2025-04-25 8:51 ` Jacek Lawrynowicz
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Hugo @ 2025-04-18 15:30 UTC (permalink / raw)
To: Maciej Falkowski, dri-devel
Cc: oded.gabbay, jacek.lawrynowicz, lizhi.hou, Andrzej Kacprowski
On 4/16/2025 4:26 AM, Maciej Falkowski wrote:
> From: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
>
> Correct setup of D0i2 disable which was
> by mistake set up to value 1 and use BIT(1) instead.
>
> Fixes: 011529fe8112 ("accel/ivpu: Implement D0i2 disable test mode")
> Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/ivpu: Fix the D0i2 disable test mode
2025-04-16 10:26 [PATCH] accel/ivpu: Fix the D0i2 disable test mode Maciej Falkowski
2025-04-18 15:30 ` Jeff Hugo
@ 2025-04-25 8:51 ` Jacek Lawrynowicz
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Lawrynowicz @ 2025-04-25 8:51 UTC (permalink / raw)
To: Maciej Falkowski, dri-devel
Cc: oded.gabbay, quic_jhugo, lizhi.hou, Andrzej Kacprowski
Applied to drm-misc-fixes
On 4/16/2025 12:26 PM, Maciej Falkowski wrote:
> From: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
>
> Correct setup of D0i2 disable which was
> by mistake set up to value 1 and use BIT(1) instead.
>
> Fixes: 011529fe8112 ("accel/ivpu: Implement D0i2 disable test mode")
> Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski@linux.intel.com>
> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
> index 5e1d709c6a46..ccaaf6c100c0 100644
> --- a/drivers/accel/ivpu/ivpu_fw.c
> +++ b/drivers/accel/ivpu/ivpu_fw.c
> @@ -544,7 +544,7 @@ static void ivpu_fw_boot_params_print(struct ivpu_device *vdev, struct vpu_boot_
> boot_params->d0i3_entry_vpu_ts);
> ivpu_dbg(vdev, FW_BOOT, "boot_params.system_time_us = %llu\n",
> boot_params->system_time_us);
> - ivpu_dbg(vdev, FW_BOOT, "boot_params.power_profile = %u\n",
> + ivpu_dbg(vdev, FW_BOOT, "boot_params.power_profile = 0x%x\n",
> boot_params->power_profile);
> }
>
> @@ -646,7 +646,7 @@ void ivpu_fw_boot_params_setup(struct ivpu_device *vdev, struct vpu_boot_params
> boot_params->d0i3_residency_time_us = 0;
> boot_params->d0i3_entry_vpu_ts = 0;
> if (IVPU_WA(disable_d0i2))
> - boot_params->power_profile = 1;
> + boot_params->power_profile |= BIT(1);
>
> boot_params->system_time_us = ktime_to_us(ktime_get_real());
> wmb(); /* Flush WC buffers after writing bootparams */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-25 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 10:26 [PATCH] accel/ivpu: Fix the D0i2 disable test mode Maciej Falkowski
2025-04-18 15:30 ` Jeff Hugo
2025-04-25 8:51 ` Jacek Lawrynowicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).