From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile Date: Tue, 12 Mar 2013 14:34:07 +0100 Message-ID: <2623790.oJdsJXERqZ@avalon> References: <1363083578-17062-1-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 93715E6645 for ; Tue, 12 Mar 2013 06:33:33 -0700 (PDT) In-Reply-To: <1363083578-17062-1-git-send-email-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Steffen Trumtrar List-Id: dri-devel@lists.freedesktop.org Hi Tomi, Thanks for the patch. On Tuesday 12 March 2013 12:19:34 Tomi Valkeinen wrote: > This patch simplifies videomode related Kconfig and Makefile. After this > patch, there's only one non-user selectable Kconfig option left, > VIDEOMODE_HELPERS. The reasons for the change: > > * Videomode helper functions are not something that should be shown in > the kernel configuration options. The related code should just be > included if it's needed, i.e. selected by drivers using videomode. > > * There's no need to have separate Kconfig options for videomode and > display_timing. First of all, the amount of code for both is quite > small. Second, videomode depends on display_timing, and display_timing > in itself is not really useful, so both would be included in any case. > > * CONFIG_VIDEOMODE is a bit vague name, and CONFIG_VIDEOMODE_HELPERS > describes better what's included. > > Signed-off-by: Tomi Valkeinen > Cc: Steffen Trumtrar I like that. Acked-by: Laurent Pinchart -- Regards, Laurent Pinchart