From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v4 04/21] modetest: Add a command line parameter to select
	the driver
Date: Thu, 04 Apr 2013 15:22:24 +0200
Message-ID: <2627551.GBjC047QyW@avalon>
References: <1363704962-14077-1-git-send-email-laurent.pinchart@ideasonboard.com>
	<1363704962-14077-5-git-send-email-laurent.pinchart@ideasonboard.com>
	<20130403100630.GX4469@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[95.142.166.194])
	by gabe.freedesktop.org (Postfix) with ESMTP id AAF5FE5CE8
	for <dri-devel@lists.freedesktop.org>;
	Thu,  4 Apr 2013 06:21:24 -0700 (PDT)
In-Reply-To: <20130403100630.GX4469@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Ville,

On Wednesday 03 April 2013 13:06:30 Ville Syrj=E4l=E4 wrote:
> On Tue, Mar 19, 2013 at 03:55:45PM +0100, Laurent Pinchart wrote:
> > If the -M parameter is specified, modetest will use the requested device
> > name instead of trying its builtin list of device names.
> > =

> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > ---
> > =

> >  tests/modetest/modetest.c | 41 ++++++++++++++++++++++++++++-----------=
--
> >  1 file changed, 28 insertions(+), 13 deletions(-)
> > =

> > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
> > index 1d1f49d..91dabfc 100644
> > --- a/tests/modetest/modetest.c
> > +++ b/tests/modetest/modetest.c
> > @@ -908,6 +908,9 @@ static void usage(char *name)
> > =

> >  	fprintf(stderr, "\t-s =

<connector_id>[@<crtc_id>]:<mode>[@<format>]\tset
> >  	a mode\n"); fprintf(stderr, "\t-v\ttest vsynced page flipping\n");
> > =

> > +	fprintf(stderr, "\n Generic options:\n\n");
> > +	fprintf(stderr, "\t-M module\tuse the given driver\n");
> =

> You didn't add it to the "usage: ..." line. Same goes for patch 05/21.

Good catch, thanks. I'll fix that.

-- =

Regards,

Laurent Pinchart