From: Deepak Rawat <drawat.floss@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, Sam Ravnborg <sam@ravnborg.org>
Cc: linux-hyperv@vger.kernel.org,
Stephen Hemminger <sthemmin@microsoft.com>,
David Airlie <airlied@linux.ie>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
dri-devel@lists.freedesktop.org,
Michael Kelley <mikelley@microsoft.com>,
Jork Loeser <jloeser@microsoft.com>, Wei Hu <weh@microsoft.com>,
K Y Srinivasan <kys@microsoft.com>
Subject: Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Tue, 23 Jun 2020 02:12:09 -0700 [thread overview]
Message-ID: <2699290fb7ab566987da8f648a9234c6a4fbc24e.camel@gmail.com> (raw)
In-Reply-To: <ea38c268-01e6-e43e-343d-a413142d450f@suse.de>
On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote:
> Hi Deepak
>
> I did not receive you pat series, so I can only comment on Sam's
> reply.
> See below for some points.
Hi Thomas, Thanks for the review. I wanted to add you in cc list but
messed it up with final git send-email. Sorry about that. I am not sure
why you didn't received it via dri-devel. The patch series do show up
in dri-devel archive. I wonder if other people also have similar
issues.
> > >
> > > + struct hv_device *hdev;
> > > +};
> > > +
> > > +#define to_hv(_dev) container_of(_dev, struct hyperv_device,
> > > dev)
>
> Could this be a function?
Is there a reason to use a function here?
>
> > > +
> > > +/* -----------------------------------------------------------
> > > ----------- */
> > > +/* Hyper-V Synthetic Video
> > > Protocol */
>
> The comments look awkward. Unless this style has been used within
> DRM,
> maybe just use
>
> /*
> * ...
> */
>
This style is copy-paste from cirrus, and bochs also have same style.
Perhaps historical. Anyway I agree to I should get rid of this.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-23 9:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 11:06 [RFC PATCH 0/2] DRM driver for hyper-v synthetic video device Deepak Rawat
2020-06-22 11:06 ` [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv " Deepak Rawat
2020-06-22 12:46 ` Gerd Hoffmann
2020-06-22 22:20 ` Deepak Rawat
2020-06-23 9:42 ` Daniel Vetter
2020-06-23 16:17 ` Gerd Hoffmann
2020-06-25 0:47 ` Deepak Rawat
2020-06-22 15:19 ` Sam Ravnborg
2020-06-22 22:43 ` Deepak Rawat
2020-06-23 7:59 ` Thomas Zimmermann
2020-06-23 9:12 ` Deepak Rawat [this message]
2020-06-23 9:19 ` Thomas Zimmermann
2020-06-23 2:31 ` Dexuan Cui
2020-06-23 6:48 ` Deepak Rawat
2020-06-23 21:58 ` Dexuan Cui
2020-06-22 11:06 ` [RFC PATCH 2/2] MAINTAINERS: Add maintainer for hyperv " Deepak Rawat
2020-06-28 23:01 ` [RFC PATCH 0/2] DRM driver for hyper-v synthetic " Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2020-09-10 8:19 [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv " Tang, Shaofeng
2020-09-11 0:38 ` Deepak Rawat
2020-11-15 9:14 ` Thomas Zimmermann
2020-11-15 17:55 ` Deepak Rawat
2020-11-15 18:58 ` Thomas Zimmermann
2020-11-16 9:58 ` Daniel Vetter
2020-11-16 16:36 ` Deepak Rawat
2020-09-28 15:58 Marcin Skarbek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2699290fb7ab566987da8f648a9234c6a4fbc24e.camel@gmail.com \
--to=drawat.floss@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=jloeser@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sam@ravnborg.org \
--cc=sthemmin@microsoft.com \
--cc=tzimmermann@suse.de \
--cc=weh@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).