Re: [bug report] accel/amdxdna: Enhance power management settings

[Dan Carpenter <dan.carpenter@linaro.org>]

On Wed, Jan 08, 2025 at 10:14:47AM -0800, Lizhi Hou wrote:
> 
> On 1/8/25 00:40, Dan Carpenter wrote:
> > Hello Lizhi Hou,
> > 
> > Commit f4d7b8a6bc8c ("accel/amdxdna: Enhance power management
> > settings") from Dec 13, 2024 (linux-next), leads to the following
> > Smatch static checker warning:
> > 
> > 	drivers/accel/amdxdna/aie2_smu.c:68 npu1_set_dpm()
> > 	error: uninitialized symbol 'freq'.
> > 
> > drivers/accel/amdxdna/aie2_smu.c
> 
> Thanks for pointing this out. I will fix it.
> 
> I actually did run smatch_scripts/kchecker and it is clean.
> 
> Maybe I did not use the correct command. Could you share the instruction to
> reproduce this?
> 

This requires the cross function database which is simple to build but
takes hours. ~/smatch/smatch_scripts/build_kernel_data.sh.  Each time you
build the cross function database it adds a level to the call tree.
Having a one level call tree is slightly annoying because it give Smatch
a false sense of confidence.  I rebuild my database every day.  Probably
seven times is where it stops adding data.

regards,
dan carpenter