From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C95DC02199 for ; Thu, 6 Feb 2025 17:18:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDE3310E8EB; Thu, 6 Feb 2025 17:18:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=detlev.casanova@collabora.com header.b="Xnnm+nO0"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FEEA10E8EB for ; Thu, 6 Feb 2025 17:18:10 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1738862280; cv=none; d=zohomail.com; s=zohoarc; b=PPCYLM87aFcVCAfMPQQ0yXcTyrsvnyTkKS+eEJWcy9cBCCuvU9Z/z8+pzbkYFtSX/1MtKPTSysfLFbXWsfEn4byj3fWbAOF50Y5tLH18AvdCZkKxLHaumA6PPi+w7cpbrzAW/zHZKRqAzxiN4l2puMicJGcIhAlDALNZ/b9YfU8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738862280; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=HVIqXYzlOehlZiy0ALlRjz1XQBncBUDd5NT43WUTgZ8=; b=lPCdyF7Zdv6I6M84wss5fyglm2/LO3RG4Et3v4lfGLGQtmGbCACYz2VhVdDLcJWcdkQycgDbkuk4ZGGxHhKk3iAeh8IIV+awP5nEJB6tY9fg6a7T5kzzIZdXZPuU8y+dOu74c75bQ/v04kDe4qTY+pxoFi38JCRIwNMDaaZrC74= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=detlev.casanova@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1738862280; s=zohomail; d=collabora.com; i=detlev.casanova@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=HVIqXYzlOehlZiy0ALlRjz1XQBncBUDd5NT43WUTgZ8=; b=Xnnm+nO0wx4RBQFTK/tSarsm6Bq5OMFkZ+7cIhAlPgfpa8rlnBCfdv+urPIUC2vV cVB821xhg1vXmN291QFqArQSM1Jav3BdpYYLbFovhHAs0as6IBcrW3FP/nqYb12ynyh Wy1JW0YmE72r82iNQ0hiaJt67LjAQrKfsPFHG18w= Received: by mx.zohomail.com with SMTPS id 173886227382959.44952550211565; Thu, 6 Feb 2025 09:17:53 -0800 (PST) From: Detlev Casanova To: linux-kernel@vger.kernel.org, Quentin Schulz Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sebastian Reichel , Alexey Charkov , Cristian Ciocaltea , Dragan Simic , Jianfeng Liu , Niklas Cassel , FUKAUMI Naoki , Kever Yang , Johan Jonker , Geert Uytterhoeven , Dmitry Baryshkov , Algea Cao , Chen-Yu Tsai , Sugar Zhang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCH v5 2/3] arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC Date: Thu, 06 Feb 2025 12:17:51 -0500 Message-ID: <2781606.mvXUDI8C0e@earth> In-Reply-To: References: <20250203171925.126309-1-detlev.casanova@collabora.com> <20250203171925.126309-3-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-ZohoMailClient: External X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tuesday, 4 February 2025 05:14:37 EST Quentin Schulz wrote: > Hi Detlev, > > On 2/3/25 6:16 PM, Detlev Casanova wrote: > > Use the simple-audio-card driver with the hdmi0 QP node as CODEC and > > the i2s5 device as CPU. > > > > The simple-audio-card,mclk-fs value is set to 128 as it is done in > > the downstream driver. > > > > The #sound-dai-cells value is set to 0 in the hdmi0 node so that it can be > > used as an audio codec node. > > > > Signed-off-by: Detlev Casanova > > --- > > > > arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi > > b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi index > > 8cfa30837ce72..767bdfc06b7ec 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi > > @@ -1369,6 +1369,22 @@ i2s9_8ch: i2s@fddfc000 { > > > > status = "disabled"; > > > > }; > > > > + hdmi0_sound: hdmi0-sound { > > + compatible = "simple-audio-card"; > > + simple-audio-card,format = "i2s"; > > + simple-audio-card,mclk-fs = <128>; > > + simple-audio-card,name = "hdmi0"; > > + status = "disabled"; > > + > > + simple-audio-card,codec { > > + sound-dai = <&hdmi0>; > > + }; > > + > > + simple-audio-card,cpu { > > + sound-dai = <&i2s5_8ch>; > > + }; > > + }; > > + > > This is an address/bus-less device, so I believe it needs to be put > among other address/bus-less devices, which for Rockchip SoCs is at the > top of the DT? c.f. > https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style. > html > > **I** would put it between the firmware and the pmu-a55 nodes. I wasn't sure about this. It makes sense to move it with address-less devices, but the rk3399 device tree has it above the hdmi node, so I wanted to stay consistent with that. > Tested-by: Quentin Schulz # RK3588 Tiger Haikou > > Thanks! > Quentin