From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines
Date: Fri, 05 Apr 2019 14:42:16 +0200 [thread overview]
Message-ID: <2790d298adb0d57a67a0a3c9bc9aa8c7c08f0a0d.camel@linux.intel.com> (raw)
In-Reply-To: <155446684177.8259.3979238916498240519@skylake-alporthouse-com>
On Fri, 2019-04-05 at 13:20 +0100, Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-04-05 13:13:31)
> > From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> >
> > If there are active users of a device during driver unbind, the
> > driver
> > now panics on non-empty list of free cachelines.
>
> This panic is there to say that fini is being called with active
> contexts, that it is being called too early. Those requests should be
> cleaned up first, unpinning the contexts and resources, and so
> letting
> the timeline be freed.
OK, I see. But why panic? Maybe a WARN() would be enough.
Thanks,
Janusz
> -Chris
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-04-05 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 12:13 [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines Janusz Krzysztofik
2019-04-05 12:20 ` Chris Wilson
2019-04-05 12:42 ` Janusz Krzysztofik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2790d298adb0d57a67a0a3c9bc9aa8c7c08f0a0d.camel@linux.intel.com \
--to=janusz.krzysztofik@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).