From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 16/32] drm/exynos: Disable unused crtc planes from crtc Date: Sun, 10 Nov 2013 22:29:31 +0100 Message-ID: <28248054.3g0xOFFf3U@flatron> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-17-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com [209.85.215.178]) by gabe.freedesktop.org (Postfix) with ESMTP id DCEA2FA600 for ; Sun, 10 Nov 2013 22:13:26 -0800 (PST) Received: by mail-ea0-f178.google.com with SMTP id a10so1992172eae.9 for ; Sun, 10 Nov 2013 22:13:26 -0800 (PST) In-Reply-To: <1383063198-10526-17-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Sean Paul Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org On Tuesday 29 of October 2013 12:13:02 Sean Paul wrote: > This patch moves the code which disables unused crtc planes from the > encoder to the crtc. Since there is a 1:1 encoder/crtc mapping in > exynos, the only valid crtc change the pre-existing code could catch is > disconnecting an active crtc from the encoder. Thus it is functionally > equivalent to just disable all planes attached to a crtc when the crtc > is disabled. > > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 13 +++++- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 65 ++--------------------------- > 2 files changed, 15 insertions(+), 63 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz