Re: [PATCH v4] drm/rockchip: Remove dependency on DRM simple helpers

[Heiko Stuebner <heiko@sntech.de>]

Hi Diogo,

Am Donnerstag, 2. Juli 2026, 22:18:58 Mitteleuropäische Sommerzeit schrieb Diogo Silva:
> Simple KMS helper are deprecated since they only add an intermediate
> layer between drivers and the atomic modesetting.
> This patch removes the drm_simple_encoder_init() helper usage in the
> rockchip drivers by open coding it and using the encoder atomic helpers
> directly. This is a step to eventually get rid of this simple KMS helper,
> once all drivers that use it have been converted.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Diogo Silva <diogompaissilva@gmail.com>
> ---
> v4:
>  - improved commit message based on Javier Canillas feedback
> 
> v3:
>  - rebase on drm-tip tree
> 
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c  | 9 ++++++---
>  drivers/gpu/drm/rockchip/cdn-dp-core.c           | 9 ++++++---
>  drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c  | 9 +++++++--
>  drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c | 8 ++++++--
>  drivers/gpu/drm/rockchip/dw_dp-rockchip.c        | 1 -
>  drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c      | 1 -
>  drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c   | 1 -
>  drivers/gpu/drm/rockchip/rk3066_hdmi.c           | 8 ++++++--
>  drivers/gpu/drm/rockchip/rockchip_lvds.c         | 9 +++++++--
>  drivers/gpu/drm/rockchip/rockchip_rgb.c          | 8 ++++++--
>  10 files changed, 44 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 776954c7d052..46c245e35d21 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -30,7 +30,6 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_print.h>
>  #include <drm/drm_probe_helper.h>
> -#include <drm/drm_simple_kms_helper.h>
> 
>  #include "rockchip_drm_drv.h"
> 
> @@ -303,6 +302,10 @@ rockchip_dp_drm_encoder_atomic_check(struct
> drm_encoder *encoder,
>         return 0;

the tool you're using to send patches seems broken.
In the patch all the places that should be tabs are replaced as spaces.
This of course does not apply.

Ideally use git send-email or b4 for sending patches.

Also, please don't send new versions as replies to previous ones.
Tooling can get confused by this, so please start a new thread for
the next version.

Thanks
Heiko