Re: [PATCH v3 24/32] drm/exynos: Implement dpms display callback in DP

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Sean,

On Tuesday 29 of October 2013 12:13:10 Sean Paul wrote:
> This patch implements the dpms display callback for the DP driver.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> 
> Changes in v2:
> 	- Added to the patchset
> Changes in v3: None
> 
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 173 ++++++++++++++++----------------
>  drivers/gpu/drm/exynos/exynos_dp_core.h |   1 +
>  2 files changed, 85 insertions(+), 89 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 13ea8b7..476d3b0 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
[snip]
> @@ -1190,26 +1205,17 @@ static int exynos_dp_probe(struct platform_device *pdev)
>  
>  	dp->video_info = pdata->video_info;
>  
> -	if (pdev->dev.of_node) {
> -		if (dp->phy_addr)
> -			exynos_dp_phy_init(dp);
> -	} else {
> -		if (pdata->phy_init)
> -			pdata->phy_init();
> -	}
> -
> -	exynos_dp_init_dp(dp);
> -
>  	ret = devm_request_irq(&pdev->dev, dp->irq, exynos_dp_irq_handler, 0,
>  				"exynos-dp", dp);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to request irq\n");
>  		return ret;
>  	}
> -
> -	platform_set_drvdata(pdev, dp);
> +	disable_irq(dp->irq);
>  
>  	exynos_dp_display.ctx = dp;
> +
> +	platform_set_drvdata(pdev, &exynos_dp_display);

This is probably more a comment to previous patch, but what about multiple
instances of display port controller? The solution would be something
I proposed in my reply to one of HDMI related patches.

Otherwise the patch looks fine.

Best regards,
Tomasz