From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 24/32] drm/exynos: Implement dpms display callback in DP
Date: Mon, 11 Nov 2013 03:04:30 +0100
Message-ID: <2842849.PALcJgTznN@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<1383063198-10526-25-git-send-email-seanpaul@chromium.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com
	[209.85.215.174])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8D277FA61D
	for <dri-devel@lists.freedesktop.org>;
	Sun, 10 Nov 2013 22:18:37 -0800 (PST)
Received: by mail-ea0-f174.google.com with SMTP id n15so1962315ead.5
	for <dri-devel@lists.freedesktop.org>;
	Sun, 10 Nov 2013 22:18:36 -0800 (PST)
In-Reply-To: <1383063198-10526-25-git-send-email-seanpaul@chromium.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org
List-Id: dri-devel@lists.freedesktop.org

Hi Sean,

On Tuesday 29 of October 2013 12:13:10 Sean Paul wrote:
> This patch implements the dpms display callback for the DP driver.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> 
> Changes in v2:
> 	- Added to the patchset
> Changes in v3: None
> 
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 173 ++++++++++++++++----------------
>  drivers/gpu/drm/exynos/exynos_dp_core.h |   1 +
>  2 files changed, 85 insertions(+), 89 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 13ea8b7..476d3b0 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
[snip]
> @@ -1190,26 +1205,17 @@ static int exynos_dp_probe(struct platform_device *pdev)
>  
>  	dp->video_info = pdata->video_info;
>  
> -	if (pdev->dev.of_node) {
> -		if (dp->phy_addr)
> -			exynos_dp_phy_init(dp);
> -	} else {
> -		if (pdata->phy_init)
> -			pdata->phy_init();
> -	}
> -
> -	exynos_dp_init_dp(dp);
> -
>  	ret = devm_request_irq(&pdev->dev, dp->irq, exynos_dp_irq_handler, 0,
>  				"exynos-dp", dp);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to request irq\n");
>  		return ret;
>  	}
> -
> -	platform_set_drvdata(pdev, dp);
> +	disable_irq(dp->irq);
>  
>  	exynos_dp_display.ctx = dp;
> +
> +	platform_set_drvdata(pdev, &exynos_dp_display);

This is probably more a comment to previous patch, but what about multiple
instances of display port controller? The solution would be something
I proposed in my reply to one of HDMI related patches.

Otherwise the patch looks fine.

Best regards,
Tomasz