dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Liang, Prike" <Prike.Liang@amd.com>,
	"Olsak, Marek" <Marek.Olsak@amd.com>,
	"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/amdgpu: stop removing BOs from the LRU during CS
Date: Mon, 13 May 2019 16:17:34 +0200	[thread overview]
Message-ID: <29313d3a-a669-ffc0-c8e9-fe358d60d323@gmail.com> (raw)
In-Reply-To: <MN2PR12MB3536E593C868F386FC7E2A5BFB0F0@MN2PR12MB3536.namprd12.prod.outlook.com>

Hi Prike,

unfortunately Marek came up with an even better test case, and this 
unfortunately solves only about 80% of all cases where this problem can 
happen.

So Abaqus might work in 4 of 5 runs, but then still fail. I'm currently 
working on trying to fix the remaining 20%.

Give me a day or two to figure things out,
Christian.

Am 13.05.19 um 16:01 schrieb Liang, Prike:
> Hi Christian ,
>
> The series patch can resolve Abaqus pinned failed issue .
> Would you like push the four fix patches to drm-next branch .
>
> Thanks,
> Prike
> -----Original Message-----
> From: Christian König <ckoenig.leichtzumerken@gmail.com>
> Sent: Friday, May 10, 2019 10:13 PM
> To: Olsak, Marek <Marek.Olsak@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; Liang, Prike <Prike.Liang@amd.com>; dri-devel@lists.freedesktop.org
> Subject: [PATCH 4/4] drm/amdgpu: stop removing BOs from the LRU during CS
>
> [CAUTION: External Email]
>
> This avoids OOM situations when we have lots of threads submitting at the same time.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index a1d6a0721e53..8828d30cd409 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -648,7 +648,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>          }
>
>          r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
> -                                  &duplicates, true);
> +                                  &duplicates, false);
>          if (unlikely(r != 0)) {
>                  if (r != -ERESTARTSYS)
>                          DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
> --
> 2.17.1
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-05-13 14:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 14:13 [PATCH 1/4] drm/ttm: Make LRU removal optional Christian König
2019-05-10 14:13 ` [PATCH 2/4] drm/ttm: fix busy memory to fail other user v7 Christian König
2019-05-10 14:13 ` [PATCH 3/4] drm/amd/display: use ttm_eu_reserve_buffers instead of amdgpu_bo_reserve Christian König
2019-05-10 14:13 ` [PATCH 4/4] drm/amdgpu: stop removing BOs from the LRU during CS Christian König
2019-05-11  1:08   ` Marek Olšák
2019-05-13 14:01   ` Liang, Prike
2019-05-13 14:17     ` Christian König [this message]
2019-05-10 14:22 ` [PATCH 1/4] drm/ttm: Make LRU removal optional Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29313d3a-a669-ffc0-c8e9-fe358d60d323@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=David1.Zhou@amd.com \
    --cc=Marek.Olsak@amd.com \
    --cc=Prike.Liang@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox