dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/12] drm: shmob_drm: Convert to clk_prepare/unprepare
Date: Sat, 09 Nov 2013 13:51:04 +0100	[thread overview]
Message-ID: <2959885.VdyEnllx0c@avalon> (raw)
In-Reply-To: <1383000569-8916-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Hi Dave,

Could you please pick this patch up ?

On Monday 28 October 2013 23:49:22 Laurent Pinchart wrote:
> Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
> clk_disable_unprepare() to get ready for the migration to the common
> clock framework.
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 54bad98..562f9a4 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> @@ -40,7 +40,7 @@
>  static void shmob_drm_clk_on(struct shmob_drm_device *sdev)
>  {
>  	if (sdev->clock)
> -		clk_enable(sdev->clock);
> +		clk_prepare_enable(sdev->clock);
>  #if 0
>  	if (sdev->meram_dev && sdev->meram_dev->pdev)
>  		pm_runtime_get_sync(&sdev->meram_dev->pdev->dev);
> @@ -54,7 +54,7 @@ static void shmob_drm_clk_off(struct shmob_drm_device
> *sdev) pm_runtime_put_sync(&sdev->meram_dev->pdev->dev);
>  #endif
>  	if (sdev->clock)
> -		clk_disable(sdev->clock);
> +		clk_disable_unprepare(sdev->clock);
>  }
> 
>  /*
> ---------------------------------------------------------------------------
-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2013-11-09 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 22:49 [PATCH 00/12] Prepare various SH/R Mobile/Car drivers for CCF migration Laurent Pinchart
2013-10-28 22:49 ` [PATCH 05/12] drm: shmob_drm: Convert to clk_prepare/unprepare Laurent Pinchart
2013-11-09 12:51   ` Laurent Pinchart [this message]
2013-11-11  8:55     ` Thierry Reding
2013-11-11 12:55       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2959885.VdyEnllx0c@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox