From: Rohan Garg <rohan.garg@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: kernel@collabora.com
Subject: Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects
Date: Tue, 22 Oct 2019 10:58:41 +0200 [thread overview]
Message-ID: <2975162.debWhmaBkT@saphira> (raw)
In-Reply-To: <CAPj87rOMMdi0zUdjEKeiUsLpfQkTPf3adEfw13ur6UQtNdNUxQ@mail.gmail.com>
Hey
On viernes, 11 de octubre de 2019 19:09:52 (CEST) Daniel Stone wrote:
> Hi Rohan,
>
> On Fri, 11 Oct 2019 at 15:30, Rohan Garg <rohan.garg@collabora.com> wrote:
> > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it
> > easier to debug issues in userspace applications.
>
> I'm not sure if this was pointed out already, but dumb buffers != GEM
> buffers. GEM buffers _can_ be dumb, but might not be.
>
> Could you please rename to GEM_SET_LABEL?
>
Daniel and I had a opportunity to talk about this in person and we agreed that
HANDLE_SET_LABEL would be a more sensible name.
Cheers
Rohan Garg
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-22 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:30 [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects Rohan Garg
2019-10-11 17:09 ` Daniel Stone
2019-10-11 17:55 ` Thomas Zimmermann
2019-10-14 8:58 ` Daniel Vetter
2019-10-22 8:58 ` Rohan Garg
2019-10-22 8:58 ` Rohan Garg [this message]
2019-10-11 17:31 ` Boris Brezillon
2019-10-12 13:35 ` Dan Carpenter
2019-10-14 8:59 ` Daniel Vetter
2019-10-22 8:58 ` Rohan Garg
2019-10-22 9:30 ` Daniel Vetter
2019-10-22 13:14 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2975162.debWhmaBkT@saphira \
--to=rohan.garg@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox