From: Paul Cercueil <paul@crapouillou.net>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
kraxel@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com,
xinliang.liu@linaro.org, kong.kongxinwei@hisilicon.com,
tomi.valkeinen@ti.com, chunkuang.hu@kernel.org,
puck.chen@hisilicon.com, hdegoede@redhat.com, jsarha@ti.com,
matthias.bgg@gmail.com, sean@poorly.run, zourongrong@gmail.com,
tiantao6@hisilicon.com
Subject: Re: [PATCH 04/10] drm/ingenic: Remove error check from fbdev setup
Date: Tue, 07 Apr 2020 01:45:02 +0200 [thread overview]
Message-ID: <2N4E8Q.P9MTB5NUTGTK3@crapouillou.net> (raw)
In-Reply-To: <20200406134405.6232-5-tzimmermann@suse.de>
Hi Thomas,
Le lun. 6 avril 2020 à 15:43, Thomas Zimmermann <tzimmermann@suse.de>
a écrit :
> Remove the error check from the fbdev setup function. The function
> will print a warning.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index 7f3f869f57b3f..d938f2b1a96f1 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -783,9 +783,7 @@ static int ingenic_drm_probe(struct
> platform_device *pdev)
> goto err_devclk_disable;
> }
>
> - ret = drm_fbdev_generic_setup(drm, 32);
> - if (ret)
> - dev_warn(dev, "Unable to start fbdev emulation: %i", ret);
> + drm_fbdev_generic_setup(drm, 32);
>
> return 0;
>
> --
> 2.26.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-07 8:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 13:43 [PATCH 00/10] Set up generic fbdev after registering device Thomas Zimmermann
2020-04-06 13:43 ` [PATCH 01/10] drm/ast: Set up fbdev after registering device; remove error checks Thomas Zimmermann
2020-04-06 13:43 ` [PATCH 02/10] drm/hibmc: Remove error check from fbdev setup Thomas Zimmermann
2020-04-06 13:43 ` [PATCH 03/10] drm/kirin: Set up fbdev after fully registering device Thomas Zimmermann
2020-04-07 8:04 ` Daniel Vetter
2020-04-07 13:19 ` Thomas Zimmermann
2020-04-06 13:43 ` [PATCH 04/10] drm/ingenic: Remove error check from fbdev setup Thomas Zimmermann
2020-04-06 23:45 ` Paul Cercueil [this message]
2020-04-06 13:44 ` [PATCH 05/10] drm/mediathek: " Thomas Zimmermann
2020-04-07 11:04 ` Noralf Trønnes
2020-04-06 13:44 ` [PATCH 06/10] drm/mgag200: Set up fbdev after registering device; remove error checks Thomas Zimmermann
2020-04-06 13:44 ` [PATCH 07/10] drm/tilcdc: Set up fbdev after fully registering device Thomas Zimmermann
2020-04-07 11:59 ` Jyri Sarha
2020-04-06 13:44 ` [PATCH 08/10] drm/udl: Remove error check from fbdev setup Thomas Zimmermann
2020-04-06 13:44 ` [PATCH 09/10] drm/vboxvideo: Set up fbdev after registering device; remove error checks Thomas Zimmermann
2020-04-06 13:44 ` [PATCH 10/10] drm/fb-helper: Remove return value from drm_fbdev_generic_setup() Thomas Zimmermann
2020-04-07 10:16 ` Sam Ravnborg
2020-04-06 20:00 ` [PATCH 00/10] Set up generic fbdev after registering device Sam Ravnborg
2020-04-07 6:28 ` Thomas Zimmermann
2020-04-07 7:24 ` Jani Nikula
2020-04-08 7:55 ` Thomas Zimmermann
2020-04-07 10:13 ` Sam Ravnborg
2020-04-07 7:21 ` Gerd Hoffmann
2020-04-07 11:02 ` Noralf Trønnes
2020-04-07 13:00 ` Thomas Zimmermann
2020-04-07 16:50 ` Sam Ravnborg
2020-04-08 6:28 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2N4E8Q.P9MTB5NUTGTK3@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=hdegoede@redhat.com \
--cc=jsarha@ti.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=matthias.bgg@gmail.com \
--cc=puck.chen@hisilicon.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=tiantao6@hisilicon.com \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox