From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Koenig, Christian" Subject: Re: [PATCH v3 2/8] ttm: turn ttm_bo_device.vma_manager into a pointer Date: Thu, 8 Aug 2019 09:48:49 +0000 Message-ID: <2a90c899-19eb-5be2-3eda-f20efd31aa29@amd.com> References: <20190808093702.29512-1-kraxel@redhat.com> <20190808093702.29512-3-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190808093702.29512-3-kraxel@redhat.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann , "dri-devel@lists.freedesktop.org" Cc: "tzimmermann@suse.de" , "Huang, Ray" , David Airlie , Daniel Vetter , open list List-Id: dri-devel@lists.freedesktop.org QW0gMDguMDguMTkgdW0gMTE6MzYgc2NocmllYiBHZXJkIEhvZmZtYW5uOg0KPiBSZW5hbWUgdGhl IGVtYmVkZGVkIHN0cnVjdCB2bWFfb2Zmc2V0X21hbmFnZXIsIGl0IGlzIG5hbWVkIF92bWFfbWFu YWdlcg0KPiBub3cuICB0dG1fYm9fZGV2aWNlLnZtYV9tYW5hZ2VyIGlzIGEgcG9pbnRlciBub3cs IHBvaW50aW5nIHRvIHRoZQ0KPiBlbWJlZGRlZCB0dG1fYm9fZGV2aWNlLl92bWFfbWFuYWdlciBi eSBkZWZhdWx0Lg0KPg0KPiBBZGQgdHRtX2JvX2RldmljZV9pbml0X3dpdGhfdm1hX21hbmFnZXIo KSBmdW5jdGlvbiB3aGljaCBhbGxvd3MgdG8NCj4gaW5pdGlhbGl6ZSB0dG0gd2l0aCBhIGRpZmZl cmVudCB2bWEgbWFuYWdlci4NCg0KQ2FuJ3Qgd2UgZ28gZG93biB0aGUgcm91dGUgb2YgY29tcGxl dGVseSByZW1vdmluZyB0aGUgdm1hX21hbmFnZXIgZnJvbSANClRUTT8gdHRtX2JvX21tYXAoKSB3 b3VsZCBnZXQgdGhlIEJPIGFzIHBhcmFtZXRlciBpbnN0ZWFkLg0KDQpUaGF0IHdvdWxkIGFsc28g bWFrZSB0aGUgdmVyaWZ5X2FjY2VzcyBjYWxsYmFjayBjb21wbGV0ZWx5IHN1cGVyZmx1b3VzIA0K YW5kIGxvb2tzIGxpa2UgYSBnb29kIHN0ZXAgaW50byB0aGUgcmlnaHQgZGlyZWN0aW9uIG9mIGRl LW1pZGxheWVyaW5nLg0KDQpDaHJpc3RpYW4uDQoNCj4NCj4gU2lnbmVkLW9mZi1ieTogR2VyZCBI b2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+DQo+IC0tLQ0KPiAgIGluY2x1ZGUvZHJtL3R0bS90 dG1fYm9fZHJpdmVyLmggfCAxMSArKysrKysrKystLQ0KPiAgIGRyaXZlcnMvZ3B1L2RybS90dG0v dHRtX2JvLmMgICAgfCAyOSArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQ0KPiAgIGRyaXZl cnMvZ3B1L2RybS90dG0vdHRtX2JvX3ZtLmMgfCAgNiArKystLS0NCj4gICAzIGZpbGVzIGNoYW5n ZWQsIDMzIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9kcm0vdHRtL3R0bV9ib19kcml2ZXIuaCBiL2luY2x1ZGUvZHJtL3R0bS90dG1fYm9f ZHJpdmVyLmgNCj4gaW5kZXggM2YxOTM1YzE5YTY2Li4yZjg0ZDZiY2QxYTcgMTAwNjQ0DQo+IC0t LSBhL2luY2x1ZGUvZHJtL3R0bS90dG1fYm9fZHJpdmVyLmgNCj4gKysrIGIvaW5jbHVkZS9kcm0v dHRtL3R0bV9ib19kcml2ZXIuaA0KPiBAQCAtNDQxLDcgKzQ0MSw4IEBAIGV4dGVybiBzdHJ1Y3Qg dHRtX2JvX2dsb2JhbCB7DQo+ICAgICoNCj4gICAgKiBAZHJpdmVyOiBQb2ludGVyIHRvIGEgc3Ry dWN0IHR0bV9ib19kcml2ZXIgc3RydWN0IHNldHVwIGJ5IHRoZSBkcml2ZXIuDQo+ICAgICogQG1h bjogQW4gYXJyYXkgb2YgbWVtX3R5cGVfbWFuYWdlcnMuDQo+IC0gKiBAdm1hX21hbmFnZXI6IEFk ZHJlc3Mgc3BhY2UgbWFuYWdlcg0KPiArICogQHZtYV9tYW5hZ2VyOiBBZGRyZXNzIHNwYWNlIG1h bmFnZXIgKHBvaW50ZXIpDQo+ICsgKiBAX3ZtYV9tYW5hZ2VyOiBBZGRyZXNzIHNwYWNlIG1hbmFn ZXIgKGVuYmVkZGVkKQ0KPiAgICAqIGxydV9sb2NrOiBTcGlubG9jayB0aGF0IHByb3RlY3RzIHRo ZSBidWZmZXIrZGV2aWNlIGxydSBsaXN0cyBhbmQNCj4gICAgKiBkZGVzdHJveSBsaXN0cy4NCj4g ICAgKiBAZGV2X21hcHBpbmc6IEEgcG9pbnRlciB0byB0aGUgc3RydWN0IGFkZHJlc3Nfc3BhY2Ug cmVwcmVzZW50aW5nIHRoZQ0KPiBAQCAtNDY0LDcgKzQ2NSw4IEBAIHN0cnVjdCB0dG1fYm9fZGV2 aWNlIHsNCj4gICAJLyoNCj4gICAJICogUHJvdGVjdGVkIGJ5IGludGVybmFsIGxvY2tzLg0KPiAg IAkgKi8NCj4gLQlzdHJ1Y3QgZHJtX3ZtYV9vZmZzZXRfbWFuYWdlciB2bWFfbWFuYWdlcjsNCj4g KwlzdHJ1Y3QgZHJtX3ZtYV9vZmZzZXRfbWFuYWdlciAqdm1hX21hbmFnZXI7DQo+ICsJc3RydWN0 IGRybV92bWFfb2Zmc2V0X21hbmFnZXIgX3ZtYV9tYW5hZ2VyOw0KPiAgIA0KPiAgIAkvKg0KPiAg IAkgKiBQcm90ZWN0ZWQgYnkgdGhlIGdsb2JhbDpscnUgbG9jay4NCj4gQEAgLTU5Nyw2ICs1OTks MTEgQEAgaW50IHR0bV9ib19kZXZpY2VfaW5pdChzdHJ1Y3QgdHRtX2JvX2RldmljZSAqYmRldiwN Cj4gICAJCSAgICAgICBzdHJ1Y3QgdHRtX2JvX2RyaXZlciAqZHJpdmVyLA0KPiAgIAkJICAgICAg IHN0cnVjdCBhZGRyZXNzX3NwYWNlICptYXBwaW5nLA0KPiAgIAkJICAgICAgIGJvb2wgbmVlZF9k bWEzMik7DQo+ICtpbnQgdHRtX2JvX2RldmljZV9pbml0X3dpdGhfdm1hX21hbmFnZXIoc3RydWN0 IHR0bV9ib19kZXZpY2UgKmJkZXYsDQo+ICsJCQkJCXN0cnVjdCB0dG1fYm9fZHJpdmVyICpkcml2 ZXIsDQo+ICsJCQkJCXN0cnVjdCBhZGRyZXNzX3NwYWNlICptYXBwaW5nLA0KPiArCQkJCQlzdHJ1 Y3QgZHJtX3ZtYV9vZmZzZXRfbWFuYWdlciAqdm1hX21hbmFnZXIsDQo+ICsJCQkJCWJvb2wgbmVl ZF9kbWEzMik7DQo+ICAgDQo+ICAgLyoqDQo+ICAgICogdHRtX2JvX3VubWFwX3ZpcnR1YWwNCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvLmMgYi9kcml2ZXJzL2dwdS9k cm0vdHRtL3R0bV9iby5jDQo+IGluZGV4IDEwYTg2MWExNjkwYy4uMGVkMWExMTgyOTYyIDEwMDY0 NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9iby5jDQo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS90dG0vdHRtX2JvLmMNCj4gQEAgLTY3Miw3ICs2NzIsNyBAQCBzdGF0aWMgdm9pZCB0 dG1fYm9fcmVsZWFzZShzdHJ1Y3Qga3JlZiAqa3JlZikNCj4gICAJc3RydWN0IHR0bV9ib19kZXZp Y2UgKmJkZXYgPSBiby0+YmRldjsNCj4gICAJc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICpt YW4gPSAmYmRldi0+bWFuW2JvLT5tZW0ubWVtX3R5cGVdOw0KPiAgIA0KPiAtCWRybV92bWFfb2Zm c2V0X3JlbW92ZSgmYmRldi0+dm1hX21hbmFnZXIsICZiby0+YmFzZS52bWFfbm9kZSk7DQo+ICsJ ZHJtX3ZtYV9vZmZzZXRfcmVtb3ZlKGJkZXYtPnZtYV9tYW5hZ2VyLCAmYm8tPmJhc2Uudm1hX25v ZGUpOw0KPiAgIAl0dG1fbWVtX2lvX2xvY2sobWFuLCBmYWxzZSk7DQo+ICAgCXR0bV9tZW1faW9f ZnJlZV92bShibyk7DQo+ICAgCXR0bV9tZW1faW9fdW5sb2NrKG1hbik7DQo+IEBAIC0xMzUzLDcg KzEzNTMsNyBAQCBpbnQgdHRtX2JvX2luaXRfcmVzZXJ2ZWQoc3RydWN0IHR0bV9ib19kZXZpY2Ug KmJkZXYsDQo+ICAgCSAqLw0KPiAgIAlpZiAoYm8tPnR5cGUgPT0gdHRtX2JvX3R5cGVfZGV2aWNl IHx8DQo+ICAgCSAgICBiby0+dHlwZSA9PSB0dG1fYm9fdHlwZV9zZykNCj4gLQkJcmV0ID0gZHJt X3ZtYV9vZmZzZXRfYWRkKCZiZGV2LT52bWFfbWFuYWdlciwgJmJvLT5iYXNlLnZtYV9ub2RlLA0K PiArCQlyZXQgPSBkcm1fdm1hX29mZnNldF9hZGQoYmRldi0+dm1hX21hbmFnZXIsICZiby0+YmFz ZS52bWFfbm9kZSwNCj4gICAJCQkJCSBiby0+bWVtLm51bV9wYWdlcyk7DQo+ICAgDQo+ICAgCS8q IHBhc3NlZCByZXNlcnZhdGlvbiBvYmplY3RzIHNob3VsZCBhbHJlYWR5IGJlIGxvY2tlZCwNCj4g QEAgLTE3MDQsNyArMTcwNCw3IEBAIGludCB0dG1fYm9fZGV2aWNlX3JlbGVhc2Uoc3RydWN0IHR0 bV9ib19kZXZpY2UgKmJkZXYpDQo+ICAgCQkJcHJfZGVidWcoIlN3YXAgbGlzdCAlZCB3YXMgY2xl YW5cbiIsIGkpOw0KPiAgIAlzcGluX3VubG9jaygmZ2xvYi0+bHJ1X2xvY2spOw0KPiAgIA0KPiAt CWRybV92bWFfb2Zmc2V0X21hbmFnZXJfZGVzdHJveSgmYmRldi0+dm1hX21hbmFnZXIpOw0KPiAr CWRybV92bWFfb2Zmc2V0X21hbmFnZXJfZGVzdHJveSgmYmRldi0+X3ZtYV9tYW5hZ2VyKTsNCj4g ICANCj4gICAJaWYgKCFyZXQpDQo+ICAgCQl0dG1fYm9fZ2xvYmFsX3JlbGVhc2UoKTsNCj4gQEAg LTE3MTMsMTAgKzE3MTMsMTEgQEAgaW50IHR0bV9ib19kZXZpY2VfcmVsZWFzZShzdHJ1Y3QgdHRt X2JvX2RldmljZSAqYmRldikNCj4gICB9DQo+ICAgRVhQT1JUX1NZTUJPTCh0dG1fYm9fZGV2aWNl X3JlbGVhc2UpOw0KPiAgIA0KPiAtaW50IHR0bV9ib19kZXZpY2VfaW5pdChzdHJ1Y3QgdHRtX2Jv X2RldmljZSAqYmRldiwNCj4gLQkJICAgICAgIHN0cnVjdCB0dG1fYm9fZHJpdmVyICpkcml2ZXIs DQo+IC0JCSAgICAgICBzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqbWFwcGluZywNCj4gLQkJICAgICAg IGJvb2wgbmVlZF9kbWEzMikNCj4gK2ludCB0dG1fYm9fZGV2aWNlX2luaXRfd2l0aF92bWFfbWFu YWdlcihzdHJ1Y3QgdHRtX2JvX2RldmljZSAqYmRldiwNCj4gKwkJCQkJc3RydWN0IHR0bV9ib19k cml2ZXIgKmRyaXZlciwNCj4gKwkJCQkJc3RydWN0IGFkZHJlc3Nfc3BhY2UgKm1hcHBpbmcsDQo+ ICsJCQkJCXN0cnVjdCBkcm1fdm1hX29mZnNldF9tYW5hZ2VyICp2bWFfbWFuYWdlciwNCj4gKwkJ CQkJYm9vbCBuZWVkX2RtYTMyKQ0KPiAgIHsNCj4gICAJc3RydWN0IHR0bV9ib19nbG9iYWwgKmds b2IgPSAmdHRtX2JvX2dsb2I7DQo+ICAgCWludCByZXQ7DQo+IEBAIC0xNzM3LDcgKzE3MzgsOCBA QCBpbnQgdHRtX2JvX2RldmljZV9pbml0KHN0cnVjdCB0dG1fYm9fZGV2aWNlICpiZGV2LA0KPiAg IAlpZiAodW5saWtlbHkocmV0ICE9IDApKQ0KPiAgIAkJZ290byBvdXRfbm9fc3lzOw0KPiAgIA0K PiAtCWRybV92bWFfb2Zmc2V0X21hbmFnZXJfaW5pdCgmYmRldi0+dm1hX21hbmFnZXIsDQo+ICsJ YmRldi0+dm1hX21hbmFnZXIgPSB2bWFfbWFuYWdlcjsNCj4gKwlkcm1fdm1hX29mZnNldF9tYW5h Z2VyX2luaXQoJmJkZXYtPl92bWFfbWFuYWdlciwNCj4gICAJCQkJICAgIERSTV9GSUxFX1BBR0Vf T0ZGU0VUX1NUQVJULA0KPiAgIAkJCQkgICAgRFJNX0ZJTEVfUEFHRV9PRkZTRVRfU0laRSk7DQo+ ICAgCUlOSVRfREVMQVlFRF9XT1JLKCZiZGV2LT53cSwgdHRtX2JvX2RlbGF5ZWRfd29ya3F1ZXVl KTsNCj4gQEAgLTE3NTQsNiArMTc1NiwxNyBAQCBpbnQgdHRtX2JvX2RldmljZV9pbml0KHN0cnVj dCB0dG1fYm9fZGV2aWNlICpiZGV2LA0KPiAgIAl0dG1fYm9fZ2xvYmFsX3JlbGVhc2UoKTsNCj4g ICAJcmV0dXJuIHJldDsNCj4gICB9DQo+ICtFWFBPUlRfU1lNQk9MKHR0bV9ib19kZXZpY2VfaW5p dF93aXRoX3ZtYV9tYW5hZ2VyKTsNCj4gKw0KPiAraW50IHR0bV9ib19kZXZpY2VfaW5pdChzdHJ1 Y3QgdHRtX2JvX2RldmljZSAqYmRldiwNCj4gKwkJICAgICAgIHN0cnVjdCB0dG1fYm9fZHJpdmVy ICpkcml2ZXIsDQo+ICsJCSAgICAgICBzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqbWFwcGluZywNCj4g KwkJICAgICAgIGJvb2wgbmVlZF9kbWEzMikNCj4gK3sNCj4gKwlyZXR1cm4gdHRtX2JvX2Rldmlj ZV9pbml0X3dpdGhfdm1hX21hbmFnZXIoYmRldiwgZHJpdmVyLCBtYXBwaW5nLA0KPiArCQkJCQkJ ICAgJmJkZXYtPl92bWFfbWFuYWdlciwNCj4gKwkJCQkJCSAgIG5lZWRfZG1hMzIpOw0KPiArfQ0K PiAgIEVYUE9SVF9TWU1CT0wodHRtX2JvX2RldmljZV9pbml0KTsNCj4gICANCj4gICAvKg0KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdm0uYyBiL2RyaXZlcnMvZ3B1 L2RybS90dG0vdHRtX2JvX3ZtLmMNCj4gaW5kZXggODVmNWJjYmUwYzc2Li5kNGVlY2RlOGQwNTAg MTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvX3ZtLmMNCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdm0uYw0KPiBAQCAtNDA5LDE2ICs0MDksMTYgQEAg c3RhdGljIHN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqdHRtX2JvX3ZtX2xvb2t1cChzdHJ1Y3Qg dHRtX2JvX2RldmljZSAqYmRldiwNCj4gICAJc3RydWN0IGRybV92bWFfb2Zmc2V0X25vZGUgKm5v ZGU7DQo+ICAgCXN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqYm8gPSBOVUxMOw0KPiAgIA0KPiAt CWRybV92bWFfb2Zmc2V0X2xvY2tfbG9va3VwKCZiZGV2LT52bWFfbWFuYWdlcik7DQo+ICsJZHJt X3ZtYV9vZmZzZXRfbG9ja19sb29rdXAoYmRldi0+dm1hX21hbmFnZXIpOw0KPiAgIA0KPiAtCW5v ZGUgPSBkcm1fdm1hX29mZnNldF9sb29rdXBfbG9ja2VkKCZiZGV2LT52bWFfbWFuYWdlciwgb2Zm c2V0LCBwYWdlcyk7DQo+ICsJbm9kZSA9IGRybV92bWFfb2Zmc2V0X2xvb2t1cF9sb2NrZWQoYmRl di0+dm1hX21hbmFnZXIsIG9mZnNldCwgcGFnZXMpOw0KPiAgIAlpZiAobGlrZWx5KG5vZGUpKSB7 DQo+ICAgCQlibyA9IGNvbnRhaW5lcl9vZihub2RlLCBzdHJ1Y3QgdHRtX2J1ZmZlcl9vYmplY3Qs DQo+ICAgCQkJCSAgYmFzZS52bWFfbm9kZSk7DQo+ICAgCQlibyA9IHR0bV9ib19nZXRfdW5sZXNz X3plcm8oYm8pOw0KPiAgIAl9DQo+ICAgDQo+IC0JZHJtX3ZtYV9vZmZzZXRfdW5sb2NrX2xvb2t1 cCgmYmRldi0+dm1hX21hbmFnZXIpOw0KPiArCWRybV92bWFfb2Zmc2V0X3VubG9ja19sb29rdXAo YmRldi0+dm1hX21hbmFnZXIpOw0KPiAgIA0KPiAgIAlpZiAoIWJvKQ0KPiAgIAkJcHJfZXJyKCJD b3VsZCBub3QgZmluZCBidWZmZXIgb2JqZWN0IHRvIG1hcFxuIik7DQoNCg==