From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Price Subject: Re: [PATCH v2 6/7] drm/panfrost: Add support for GPU heap allocations Date: Wed, 31 Jul 2019 10:30:51 +0100 Message-ID: <2aa4cc3f-03c2-ae7b-d3b8-683ac9b06dc6@arm.com> References: <20190725011003.30837-1-robh@kernel.org> <20190725011003.30837-7-robh@kernel.org> <9eaf879c-bd7b-aded-e8f6-8efc2394fef5@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 336E388EBA for ; Wed, 31 Jul 2019 09:30:54 +0000 (UTC) In-Reply-To: Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Tomeu Vizoso , Maxime Ripard , Sean Paul , dri-devel , David Airlie , Boris Brezillon , Alyssa Rosenzweig , Robin Murphy List-Id: dri-devel@lists.freedesktop.org T24gMzAvMDcvMjAxOSAyMTowMywgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gT24gVGh1LCBKdWwgMjUs IDIwMTkgYXQgOTozNSBBTSBTdGV2ZW4gUHJpY2UgPHN0ZXZlbi5wcmljZUBhcm0uY29tPiB3cm90 ZToKPj4KPj4gT24gMjUvMDcvMjAxOSAxNTo1OSwgU3RldmVuIFByaWNlIHdyb3RlOgo+PiBbLi4u XQo+Pj4gSXQgd291bGQgYXBwZWFyIHRoYXQgaW4gdGhlIGZvbGxvd2luZyBjYWxsIHNndD09TlVM TDoKPj4+PiAgICAgIHJldCA9IHNnX2FsbG9jX3RhYmxlX2Zyb21fcGFnZXMoc2d0LCBwYWdlcyAr IHBhZ2Vfb2Zmc2V0LAo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBO VU1fRkFVTFRfUEFHRVMsIDAsIFNaXzJNLCBHRlBfS0VSTkVMKTsKPj4+Cj4+PiBXaGljaCBtZWFu cyB3ZSd2ZSBlbmRlZCB1cCB3aXRoIGEgQk8gd2l0aCBiby0+c2d0PT1OVUxMLCBiby0+cGFnZXMg c2V0Cj4+PiBhbmQgYm8tPmlzX2hlYXA9dHJ1ZS4gTXkgdW5kZXJzdGFuZGluZyBpcyB0aGlzIHNo b3VsZCBiZSBpbXBvc3NpYmxlLgo+Pj4KPj4+IEkgaGF2ZW4ndCB5ZXQgZmlndXJlZCBvdXQgaG93 IHRoaXMgaGFwcGVucyAtIGl0IHNlZW1zIHRvIGJlIGp1c3QgYmVmb3JlCj4+PiB0ZXJtaW5hdGlv biwgc28gaXQgbWlnaHQgYmUgYSByYWNlIHdpdGggY2xlYW51cD8KPj4KPj4gVGhhdCB3YXMgYSBy ZWQgaGVycmluZyAtIGl0J3MgcGFydGx5IG15IHRlc3QgY2FzZSBkb2luZyBzb21ldGhpbmcgYSBi aXQKPj4gd2VpcmQuIFRoaXMgY3Jhc2ggaXMgY2F1c2VkIGJ5IGRvaW5nIGFuIG1tYXAgb2YgYSBI RUFQIG9iamVjdCBiZWZvcmUgYW55Cj4+IGZhdWx0IGhhcyBvY2N1cnJlZC4KPj4KPj4gZHJtX2dl bV9zaG1lbV9tbWFwKCkgY2FsbHMgZHJtX2dlbV9zaG1lbV9nZXRfcGFnZXMoKSB3aGljaCB3aWxs IHBvcHVsYXRlCj4+IGJvLT5iYXNlLnBhZ2VzIChldmVuIGlmIGJvLT5pc19oZWFwKS4KPj4KPj4g RWl0aGVyIHdlIHNob3VsZCBwcmV2ZW50IG1hcHBpbmcgb2YgSEVBUCBvYmplY3RzLCBvciBhbHRl cm5hdGl2ZWx5Cj4+IGJvLT5iYXNlLnBhZ2VzIGNvdWxkIGJlIGFsbG9jYXRlZCB1cGZyb250IGlu c3RlYWQgb2YgZHVyaW5nIHRoZSBmaXJzdAo+PiBmYXVsdC4gTXkgcHJlZmVyZW5jZSB3b3VsZCBi ZSBhbGxvY2F0aW5nIGl0IHVwZnJvbnQgYmVjYXVzZSBvcHRpbWlzaW5nCj4+IGZvciB0aGUgY2Fz ZSBvZiBhIEhFQVAgQk8gd2hpY2ggaXNuJ3QgdXNlZCBzZWVtcyBhIGJpdCB3ZWlyZC4gQWx0aG91 Z2gKPj4gdGhlcmUncyBzdGlsbCB0aGUgcXVlc3Rpb24gb2YgZXhhY3RseSB3aGF0IHRoZSBiZWhh dmlvdXIgc2hvdWxkIGJlIG9mCj4+IGFjY2Vzc2luZyB0aHJvdWdoIHRoZSBDUFUgcGFnZXMgd2hp Y2ggaGF2ZW4ndCBiZWVuIGFsbG9jYXRlZCB5ZXQuCj4gCj4gQXMgcHJldmVudGluZyBnZXR0aW5n IHRoZSBtbWFwIGZha2Ugb2Zmc2V0IHNob3VsZCBiZSBzdWZmaWNpZW50LCBJJ20KPiBwbGFubmlu ZyBvbiBkb2luZyB0aGlzIGNoYW5nZToKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3BhbmZyb3N0L3BhbmZyb3N0X2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFu ZnJvc3RfZHJ2LmMKPiBpbmRleCA3NDZlYjQ2MDNiYzIuLjE4NmQ1ZGI4OTJhOSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMKPiBAQCAtMjcwLDYgKzI3MCwxMCBA QCBzdGF0aWMgaW50IHBhbmZyb3N0X2lvY3RsX21tYXBfYm8oc3RydWN0Cj4gZHJtX2RldmljZSAq ZGV2LCB2b2lkICpkYXRhLAo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT0VOVDsKPiAgICAg ICAgIH0KPiAKPiArICAgICAgIC8qIERvbid0IGFsbG93IG1tYXBwaW5nIG9mIGhlYXAgb2JqZWN0 cyBhcyBwYWdlcyBhcmUgbm90IHBpbm5lZC4gKi8KPiArICAgICAgIGlmICh0b19wYW5mcm9zdF9i byhnZW1fb2JqKS0+aXNfaGVhcCkpCj4gKyAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ ICsKPiAgICAgICAgIHJldCA9IGRybV9nZW1fY3JlYXRlX21tYXBfb2Zmc2V0KGdlbV9vYmopOwo+ ICAgICAgICAgaWYgKHJldCA9PSAwKQo+ICAgICAgICAgICAgICAgICBhcmdzLT5vZmZzZXQgPSBk cm1fdm1hX25vZGVfb2Zmc2V0X2FkZHIoJmdlbV9vYmotPnZtYV9ub2RlKTsKPiAKClNlZW1zIHJl YXNvbmFibGUgdG8gbWUgLSB3ZSBjYW4gYWx3YXlzIGFkZCBzdXBwb3J0IGZvciBtbWFwKClpbmcg YXQgYQpsYXRlciBkYXRlIGlmIGl0IGJlY29tZXMgdXNlZnVsLgoKPj4gQWxzbyBzaG1lbS0+cGFn ZXNfdXNlX2NvdW50IG5lZWRzIGluY3JlbWVudGluZyB0byBzdG9wCj4+IGRybV9nZW1fc2htZW1f Z2V0X3BhZ2VzKCkgcmVwbGFjaW5nIGJvLT5iYXNlLnBhZ2VzLiBJIGhhdmVuJ3QgdGVzdGVkCj4+ IHdoYXQgaGFwcGVucyBpZiB5b3UgbW1hcCAqYWZ0ZXIqIHRoZSBmaXJzdCBmYXVsdC4KPiAKPiBJ IHNldCBwYWdlc191c2VfY291bnQgdG8gMSB3aGVuIHdlIGFsbG9jYXRlIHBhZ2VzIG9uIHRoZSBm aXJzdCBmYXVsdC4KPiBPciBkbyB5b3UgbWVhbiB3ZSBuZWVkIHRvIHNldCBpdCBvbiBjcmVhdGlv biBpbiBjYXNlCj4gZHJtX2dlbV9zaG1lbV9nZXRfcGFnZXMoKSBpcyBjYWxsZWQgYmVmb3JlIGFu eSBHUFUgZmF1bHRzPwo+IAo+IEVpdGhlciB3YXksIHRoYXQganVzdCBzaGlmdHMgaG93L3doZXJl IHdlIGNyYXNoIEkgdGhpbmsuIFdlIG5lZWQgdG8KPiBwcmV2ZW50IGRybV9nZW1fc2htZW1fZ2V0 X3BhZ2VzKCkgZnJvbSBiZWluZyBjYWxsZWQuIEJlc2lkZXMgbW1hcCwgdGhlCj4gb3RoZXIgY2Fz ZXMgYXJlIHZtYXAgYW5kIGV4cG9ydGluZy4gSSBkb24ndCB0aGluayB3ZSBoYXZlIGFueSBwYXRo cwo+IHRoYXQgd2lsbCBjYXVzZSB2bWFwIHRvIGdldCBjYWxsZWQgaW4gb3VyIGNhc2UuIEZvciBl eHBvcnRpbmcsIHBlcmhhcHMKPiB3ZSBuZWVkIGEgd3JhcHBlciBhcm91bmQgZHJtX2dlbV9zaG1l bV9waW4oKSB0byBwcmV2ZW50IGl0LgoKWWVzLCBlaXRoZXIgZXZlcnkgcGF0aCB0byBkcm1fZ2Vt X3NobWVtX2dldF9wYWdlcygpIG5lZWRzIHRvIGJlIGJsb2NrZWQKZm9yIEhFQVAgb2JqZWN0cywg b3IgeW91IG5lZWQgdG8gc2V0IHBhZ2VzX3VzZV9jb3VudCB0byAxIHdoZW4geW91CmFsbG9jYXRl ICh3aGljaCB0aGVuIG1lYW5zIGRybV9nZW1fc2htZW1fZ2V0X3BhZ2VzKCkgd2lsbCBzaW1wbHkK aW5jcmVtZW50IHRoZSByZWYtY291bnQpLgoKT2YgY291cnNlIGlmIHlvdSBhcmUgbGVhdmluZyBh bnkgY2FsbHMgdG8gZHJtX2dlbV9zaG1lbV9nZXRfcGFnZXMoKQpyZWFjaGFibGUgdGhlbiB5b3Ug YWxzbyBuZWVkIHRvIGVuc3VyZSB0aGF0IHRoZSBjb2RlIHRoYXQgZm9sbG93cwp1bmRlcnN0YW5k cyBob3cgdG8gZGVhbCB3aXRoIGEgc3BhcnNlIGJvLT5wYWdlcyBhcnJheS4gRXhwb3J0aW5nIHdv dWxkCmJlIGEgZ29vZCBleGFtcGxlIC0gYW5kIGFnYWluIEkgc3VzcGVjdCBqdXN0IHByZXZlbnRp bmcgaXQgaXMgZmluZSBmb3Igbm93LgoKU3RldmUKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVs