From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE7FC433ED for ; Mon, 17 May 2021 16:30:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8726660FD9 for ; Mon, 17 May 2021 16:30:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8726660FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 247D86E9EB; Mon, 17 May 2021 16:30:10 +0000 (UTC) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1838A6E949 for ; Mon, 17 May 2021 12:27:43 +0000 (UTC) Received: by mail-qv1-xf33.google.com with SMTP id h7so2295774qvs.12 for ; Mon, 17 May 2021 05:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RrMgSrZtTqdB/wlv0id/9NlOUPd01Z7kAGWKqnT2c2M=; b=CctOlq+UkKn18QqKAOdc7VqJDwwJKN9HU/A5tTPZ0EUkYGQMbFanD0RNwVHW2f6R4E 7fGATCP3I/aegDtzmOBa5y7HYnBAOTRIl+10jhJuS7FOhQbBKJ3dZOOA6X3ITygKqzls GYKmF56nNhO+08TdkpRANu9VXaTwgiFhOUXy8+b44TjtqJNCthTAiLbF/r709SBk+TTr JFfUCWgDEX967xOAuQfbJGZ4in3xZj/3kE8Mf/9i0HFQ65dEhwLg/3wrcJKdfUh8FmVT hxlDPhEvB3cXIZu0UWRwRNkFRYiWjfn70i3oucULeBS2i2/4Qn1sRdt3WfdmU+uTZ/f+ PWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RrMgSrZtTqdB/wlv0id/9NlOUPd01Z7kAGWKqnT2c2M=; b=M8OGoM5B+e/jXk6Ibktx4XuHC2JhlZskKB8lzXx+5lYsQR5tosNEAxM/r7UAFJ08bH 9rlMRZ+qRwHUBMnDMAOQVl45f3ttrmEBhqRzodOz8RTw0YTttvvHWEQoNO1lvgKZ/eCu xvJKqQll9yJk++tzUA7hBPJILfTtGwFy1jVI2oD0Z2kPrup2ECMbJBMGXm2aRK1KM6Dt cJtVUiVproGNW83P0qmAbfUk4b3+mt6Ozcc/qAskqWENOhlgHJO7t6bDq3vAmQjrDWee TBPowxBTkATVyvA1EiT7qsExXzMAHptgvRWrmoylHIZ7Faz6JCE9tqw0+rgHTiQ1lq3l de0A== X-Gm-Message-State: AOAM533pm7KbRbZZT8EiRoedpTNrXCEkLes9bGlbGLE0+LLZcEC41I4n RwcpPTxNRFkB2yCTTwayka8= X-Google-Smtp-Source: ABdhPJzM+6xSTMZ2jK4banMxGU90aLBTrZTJZYJp2Lr/pLBs4nDcAdGVJO5Aq8VNiSxT+2/N1fJnug== X-Received: by 2002:a05:6214:87:: with SMTP id n7mr16082560qvr.1.1621254462149; Mon, 17 May 2021 05:27:42 -0700 (PDT) Received: from ?IPv6:2804:14c:125:811b::1003? ([2804:14c:125:811b::1003]) by smtp.gmail.com with ESMTPSA id 10sm10377983qka.23.2021.05.17.05.27.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 05:27:41 -0700 (PDT) Subject: Re: [PATCH] video: hgafb: correctly handle card detect failure during probe To: Anirudh Rayabharam , Ferenc Bakonyi , Greg Kroah-Hartman References: <20210516192714.25823-1-mail@anirudhrb.com> From: Igor Torrente Message-ID: <2b945eaa-4288-1601-3f1a-60f2ceaa1ea7@gmail.com> Date: Mon, 17 May 2021 09:27:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210516192714.25823-1-mail@anirudhrb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 17 May 2021 16:30:08 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel test robot , stable , linux-nvidia@lists.surfsouth.com, linux-kernel-mentees@lists.linuxfoundation.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 5/16/21 4:27 PM, Anirudh Rayabharam wrote: > The return value of hga_card_detect() is not properly handled causing > the probe to succeed even though hga_card_detect() failed. Since probe > succeeds, hgafb_open() can be called which will end up operating on an > unmapped hga_vram. This results in an out-of-bounds access as reported > by kernel test robot [1]. > > To fix this, correctly detect failure of hga_card_detect() by checking > for a non-zero error code. > > [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/ > > Reported-by: kernel test robot > Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference") > Cc: stable > Signed-off-by: Anirudh Rayabharam > --- > drivers/video/fbdev/hgafb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c > index cc8e62ae93f6..bd3d07aa4f0e 100644 > --- a/drivers/video/fbdev/hgafb.c > +++ b/drivers/video/fbdev/hgafb.c > @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev) > int ret; > > ret = hga_card_detect(); > - if (!ret) > + if (ret) > return ret; > > printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n", > In fact, this return isn't being properly handled. Thanks for fix it! Reviewed-by: Igor Matheus Andrade Torrente