From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: tzimmermann@suse.de, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, jani.nikula@intel.com
Subject: [PATCH v3 22/25] drm/vblank: pass vblank to drm_get_last_vbltimestamp()
Date: Fri, 5 Dec 2025 13:27:38 +0200 [thread overview]
Message-ID: <2bc71eb80db23bfb5c4aacd082cde3b12c20a63b.1764933891.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1764933891.git.jani.nikula@intel.com>
Use the vblank pointer instead of a dev, pipe pair to simplify
code. Rename to drm_vblank_crtc_get_last_timestamp().
v2: Rename (Thomas)
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_vblank.c | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 52fa4ca361e3..4a88cdea086d 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -162,9 +162,8 @@
*/
#define DRM_REDUNDANT_VBLIRQ_THRESH_NS 1000000
-static bool
-drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,
- ktime_t *tvblank, bool in_vblank_irq);
+static bool drm_vblank_crtc_get_last_timestamp(struct drm_vblank_crtc *vblank,
+ ktime_t *tvblank, bool in_vblank_irq);
static unsigned int drm_timestamp_precision = 20; /* Default to 20 usecs. */
@@ -253,7 +252,6 @@ static u32 drm_vblank_crtc_get_counter(struct drm_vblank_crtc *vblank)
static void drm_vblank_crtc_reset_timestamp(struct drm_vblank_crtc *vblank)
{
struct drm_device *dev = vblank->dev;
- unsigned int pipe = vblank->pipe;
u32 cur_vblank;
bool rc;
ktime_t t_vblank;
@@ -267,7 +265,7 @@ static void drm_vblank_crtc_reset_timestamp(struct drm_vblank_crtc *vblank)
*/
do {
cur_vblank = drm_vblank_crtc_get_counter(vblank);
- rc = drm_get_last_vbltimestamp(dev, pipe, &t_vblank, false);
+ rc = drm_vblank_crtc_get_last_timestamp(vblank, &t_vblank, false);
} while (cur_vblank != drm_vblank_crtc_get_counter(vblank) && --count > 0);
/*
@@ -325,7 +323,7 @@ static void drm_vblank_crtc_update_count(struct drm_vblank_crtc *vblank,
*/
do {
cur_vblank = drm_vblank_crtc_get_counter(vblank);
- rc = drm_get_last_vbltimestamp(dev, pipe, &t_vblank, in_vblank_irq);
+ rc = drm_vblank_crtc_get_last_timestamp(vblank, &t_vblank, in_vblank_irq);
} while (cur_vblank != drm_vblank_crtc_get_counter(vblank) && --count > 0);
if (max_vblank_count) {
@@ -911,11 +909,10 @@ drm_crtc_get_last_vbltimestamp(struct drm_crtc *crtc, ktime_t *tvblank,
return ret;
}
-static bool
-drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,
- ktime_t *tvblank, bool in_vblank_irq)
+static bool drm_vblank_crtc_get_last_timestamp(struct drm_vblank_crtc *vblank,
+ ktime_t *tvblank, bool in_vblank_irq)
{
- struct drm_crtc *crtc = drm_crtc_from_index(dev, pipe);
+ struct drm_crtc *crtc = drm_crtc_from_vblank(vblank);
return drm_crtc_get_last_vbltimestamp(crtc, tvblank, in_vblank_irq);
}
@@ -1555,7 +1552,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_on);
void drm_crtc_vblank_restore(struct drm_crtc *crtc)
{
struct drm_device *dev = crtc->dev;
- unsigned int pipe = drm_crtc_index(crtc);
struct drm_vblank_crtc *vblank = drm_crtc_vblank_crtc(crtc);
ktime_t t_vblank;
int framedur_ns;
@@ -1578,7 +1574,7 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc)
do {
cur_vblank = drm_vblank_crtc_get_counter(vblank);
- drm_get_last_vbltimestamp(dev, pipe, &t_vblank, false);
+ drm_vblank_crtc_get_last_timestamp(vblank, &t_vblank, false);
} while (cur_vblank != drm_vblank_crtc_get_counter(vblank) && --count > 0);
diff_ns = ktime_to_ns(ktime_sub(t_vblank, vblank->time));
--
2.47.3
next prev parent reply other threads:[~2025-12-05 11:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 11:27 [PATCH v3 00/25] drm/vblank: refactoring and cleanups Jani Nikula
2025-12-05 11:27 ` [PATCH v3 01/25] drm/vblank: Unexport drm_wait_one_vblank() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 02/25] drm/vblank: remove drm_wait_one_vblank() completely Jani Nikula
2025-12-05 11:27 ` [PATCH v3 03/25] drm/vblank: remove superfluous pipe check Jani Nikula
2025-12-05 11:27 ` [PATCH v3 04/25] drm/vblank: add return value to drm_crtc_wait_one_vblank() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 05/25] drm/vblank: limit vblank variable scope to atomic Jani Nikula
2025-12-05 11:27 ` [PATCH v3 06/25] drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc() helpers more Jani Nikula
2025-12-05 11:27 ` [PATCH v3 07/25] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 08/25] drm/vblank: pass vlank to drm_vblank_get()/_put()/_count() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 09/25] drm/vblank: pass vblank to drm_update_vblank_count() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 10/25] drm/vblank: pass vblank to drm_handle_vblank_events() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 11/25] drm/vblank: use the vblank based interfaces more Jani Nikula
2025-12-05 11:27 ` [PATCH v3 12/25] drm/vblank: pass vblank to drm_queue_vblank_event() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 13/25] drm/vblank: pass vblank to drm_wait_vblank_reply() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 14/25] drm/vblank: pass vblank to drm_vblank_count_and_time() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 15/25] drm/vblank: pass vblank to drm_reset_vblank_timestamp() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 16/25] drm/vblank: pass vblank to store_vblank() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 17/25] drm/vblank: pass vblank to drm_vblank_enable() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 18/25] drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 19/25] drm/vblank: add drm_crtc_from_vblank() helper Jani Nikula
2025-12-05 11:27 ` [PATCH v3 20/25] drm/vblank: pass vblank to __get_vblank_counter() and drm_max_vblank_count() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 21/25] drm/vblank: pass vblank to __{enable, disable}_vblank() Jani Nikula
2025-12-05 11:27 ` Jani Nikula [this message]
2025-12-05 11:27 ` [PATCH v3 23/25] drm/vblank: pass vblank to drm_vblank_disable_and_save(), make static Jani Nikula
2025-12-05 11:27 ` [PATCH v3 24/25] drm/vblank: reduce pipe checks Jani Nikula
2025-12-05 11:27 ` [PATCH v3 25/25] drm/vblank: clean up debug logging Jani Nikula
2025-12-08 15:18 ` [PATCH v3 00/25] drm/vblank: refactoring and cleanups Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc71eb80db23bfb5c4aacd082cde3b12c20a63b.1764933891.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).