From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Thompson <daniel.thompson@linaro.org>
Subject: Re: [PATCH] backlight: pwm_bl: switch to using "atomic" PWM API
Date: Fri, 27 Jul 2018 12:32:33 +0100
Message-ID: <2e157deb-de8d-9f12-b4f2-04e04ff2e5ed@linaro.org>
References: <20180726091534.27521-1-enric.balletbo@collabora.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com
 [IPv6:2a00:1450:400c:c09::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 8CC1C6E970
 for <dri-devel@lists.freedesktop.org>; Fri, 27 Jul 2018 11:32:37 +0000 (UTC)
Received: by mail-wm0-x243.google.com with SMTP id y9-v6so5152681wma.5
 for <dri-devel@lists.freedesktop.org>; Fri, 27 Jul 2018 04:32:37 -0700 (PDT)
In-Reply-To: <20180726091534.27521-1-enric.balletbo@collabora.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>, linux-kernel@vger.kernel.org
Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Jingoo Han <jingoohan1@gmail.com>, dri-devel@lists.freedesktop.org, Thierry Reding <thierry.reding@gmail.com>, kernel@collabora.com, Lee Jones <lee.jones@linaro.org>, cl@rock-chips.com
List-Id: dri-devel@lists.freedesktop.org

T24gMjYvMDcvMTggMTA6MTUsIEVucmljIEJhbGxldGJvIGkgU2VycmEgd3JvdGU6Cj4gVGhlICJh
dG9taWMiIEFQSSBhbGxvd3MgdXMgdG8gY29uZmlndXJlIFBXTSBwZXJpb2QgYW5kIGR1dHlfY3lj
bGUgYW5kCj4gZW5hYmxlIGl0IGluIG9uZSBjYWxsLgo+IAo+IFRoZSBwYXRjaCBhbHNvIG1vdmVz
IHRoZSBwd21faW5pdF9zdGF0ZSBqdXN0IGJlZm9yZSBhbnkgdXNlIG9mIHRoZQo+IHB3bV9zdGF0
ZSBzdHJ1Y3QsIHRoaXMgZml4ZXMgYSBwb3RlbnRpYWwgYnVnIHdoZXJlIHB3bV9nZXRfc3RhdGUK
PiBjYW4gYmUgY2FsbGVkIGJlZm9yZSBwd21faW5pdF9zdGF0ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5
OiBFbnJpYyBCYWxsZXRibyBpIFNlcnJhIDxlbnJpYy5iYWxsZXRib0Bjb2xsYWJvcmEuY29tPgo+
IC0tLQo+IAo+ICAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcHdtX2JsLmMgfCA0OCArKysrKysr
KysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlv
bnMoKyksIDE4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2Jh
Y2tsaWdodC9wd21fYmwuYyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3B3bV9ibC5jCj4gaW5k
ZXggYmRmY2MwYTcxZGIxLi4yYzczNGQ1NWQ2MDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aWRl
by9iYWNrbGlnaHQvcHdtX2JsLmMKPiArKysgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9wd21f
YmwuYwo+IEBAIC00Niw3ICs0Niw4IEBAIHN0cnVjdCBwd21fYmxfZGF0YSB7Cj4gICAJdm9pZAkJ
CSgqZXhpdCkoc3RydWN0IGRldmljZSAqKTsKPiAgIH07Cj4gICAKPiAtc3RhdGljIHZvaWQgcHdt
X2JhY2tsaWdodF9wb3dlcl9vbihzdHJ1Y3QgcHdtX2JsX2RhdGEgKnBiLCBpbnQgYnJpZ2h0bmVz
cykKPiArc3RhdGljIHZvaWQgcHdtX2JhY2tsaWdodF9wb3dlcl9vbihzdHJ1Y3QgcHdtX2JsX2Rh
dGEgKnBiLAo+ICsJCQkJICAgc3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gICB7Cj4gICAJaW50
IGVycjsKPiAgIAo+IEBAIC01Nyw3ICs1OCw4IEBAIHN0YXRpYyB2b2lkIHB3bV9iYWNrbGlnaHRf
cG93ZXJfb24oc3RydWN0IHB3bV9ibF9kYXRhICpwYiwgaW50IGJyaWdodG5lc3MpCj4gICAJaWYg
KGVyciA8IDApCj4gICAJCWRldl9lcnIocGItPmRldiwgImZhaWxlZCB0byBlbmFibGUgcG93ZXIg
c3VwcGx5XG4iKTsKPiAgIAo+IC0JcHdtX2VuYWJsZShwYi0+cHdtKTsKPiArCXN0YXRlLT5lbmFi
bGVkID0gdHJ1ZTsKPiArCXB3bV9hcHBseV9zdGF0ZShwYi0+cHdtLCBzdGF0ZSk7Cj4gICAKPiAg
IAlpZiAocGItPnBvc3RfcHdtX29uX2RlbGF5KQo+ICAgCQltc2xlZXAocGItPnBvc3RfcHdtX29u
X2RlbGF5KTsKPiBAQCAtNzAsNiArNzIsOCBAQCBzdGF0aWMgdm9pZCBwd21fYmFja2xpZ2h0X3Bv
d2VyX29uKHN0cnVjdCBwd21fYmxfZGF0YSAqcGIsIGludCBicmlnaHRuZXNzKQo+ICAgCj4gICBz
dGF0aWMgdm9pZCBwd21fYmFja2xpZ2h0X3Bvd2VyX29mZihzdHJ1Y3QgcHdtX2JsX2RhdGEgKnBi
KQo+ICAgewo+ICsJc3RydWN0IHB3bV9zdGF0ZSBzdGF0ZTsKPiArCj4gICAJaWYgKCFwYi0+ZW5h
YmxlZCkKPiAgIAkJcmV0dXJuOwo+ICAgCj4gQEAgLTc5LDggKzgzLDExIEBAIHN0YXRpYyB2b2lk
IHB3bV9iYWNrbGlnaHRfcG93ZXJfb2ZmKHN0cnVjdCBwd21fYmxfZGF0YSAqcGIpCj4gICAJaWYg
KHBiLT5wd21fb2ZmX2RlbGF5KQo+ICAgCQltc2xlZXAocGItPnB3bV9vZmZfZGVsYXkpOwo+ICAg
Cj4gLQlwd21fY29uZmlnKHBiLT5wd20sIDAsIHBiLT5wZXJpb2QpOwo+IC0JcHdtX2Rpc2FibGUo
cGItPnB3bSk7Cj4gKwlwd21fZ2V0X3N0YXRlKHBiLT5wd20sICZzdGF0ZSk7Cj4gKwlzdGF0ZS5l
bmFibGVkID0gZmFsc2U7Cj4gKwlzdGF0ZS5wZXJpb2QgPSBwYi0+cGVyaW9kOwo+ICsJc3RhdGUu
ZHV0eV9jeWNsZSA9IDA7Cj4gKwlwd21fYXBwbHlfc3RhdGUocGItPnB3bSwgJnN0YXRlKTsKPiAg
IAo+ICAgCXJlZ3VsYXRvcl9kaXNhYmxlKHBiLT5wb3dlcl9zdXBwbHkpOwo+ICAgCXBiLT5lbmFi
bGVkID0gZmFsc2U7Cj4gQEAgLTEwNiw2ICsxMTMsNyBAQCBzdGF0aWMgaW50IHB3bV9iYWNrbGln
aHRfdXBkYXRlX3N0YXR1cyhzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAqYmwpCj4gICB7Cj4gICAJ
c3RydWN0IHB3bV9ibF9kYXRhICpwYiA9IGJsX2dldF9kYXRhKGJsKTsKPiAgIAlpbnQgYnJpZ2h0
bmVzcyA9IGJsLT5wcm9wcy5icmlnaHRuZXNzOwo+ICsJc3RydWN0IHB3bV9zdGF0ZSBzdGF0ZTsK
PiAgIAlpbnQgZHV0eV9jeWNsZTsKPiAgIAo+ICAgCWlmIChibC0+cHJvcHMucG93ZXIgIT0gRkJf
QkxBTktfVU5CTEFOSyB8fAo+IEBAIC0xMTgsOCArMTI2LDEzIEBAIHN0YXRpYyBpbnQgcHdtX2Jh
Y2tsaWdodF91cGRhdGVfc3RhdHVzKHN0cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpibCkKPiAgIAo+
ICAgCWlmIChicmlnaHRuZXNzID4gMCkgewo+ICAgCQlkdXR5X2N5Y2xlID0gY29tcHV0ZV9kdXR5
X2N5Y2xlKHBiLCBicmlnaHRuZXNzKTsKPiAtCQlwd21fY29uZmlnKHBiLT5wd20sIGR1dHlfY3lj
bGUsIHBiLT5wZXJpb2QpOwo+IC0JCXB3bV9iYWNrbGlnaHRfcG93ZXJfb24ocGIsIGJyaWdodG5l
c3MpOwo+ICsJCXB3bV9nZXRfc3RhdGUocGItPnB3bSwgJnN0YXRlKTsKPiArCQlzdGF0ZS5kdXR5
X2N5Y2xlID0gZHV0eV9jeWNsZTsKPiArCQlzdGF0ZS5wZXJpb2QgPSBwYi0+cGVyaW9kOwo+ICsJ
CWlmICghc3RhdGUuZW5hYmxlZCkKPiArCQkJcHdtX2JhY2tsaWdodF9wb3dlcl9vbihwYiwgJnN0
YXRlKTsKPiArCQllbHNlCj4gKwkJCXB3bV9hcHBseV9zdGF0ZShwYi0+cHdtLCAmc3RhdGUpOwo+
ICAgCX0gZWxzZQo+ICAgCQlwd21fYmFja2xpZ2h0X3Bvd2VyX29mZihwYik7Cj4gICAKPiBAQCAt
NDQ3LDcgKzQ2MCw2IEBAIHN0YXRpYyBpbnQgcHdtX2JhY2tsaWdodF9wcm9iZShzdHJ1Y3QgcGxh
dGZvcm1fZGV2aWNlICpwZGV2KQo+ICAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSA9IHBkZXYt
PmRldi5vZl9ub2RlOwo+ICAgCXN0cnVjdCBwd21fYmxfZGF0YSAqcGI7Cj4gICAJc3RydWN0IHB3
bV9zdGF0ZSBzdGF0ZTsKPiAtCXN0cnVjdCBwd21fYXJncyBwYXJnczsKPiAgIAl1bnNpZ25lZCBp
bnQgaTsKPiAgIAlpbnQgcmV0Owo+ICAgCj4gQEAgLTUzOSwxMCArNTUxLDE3IEBAIHN0YXRpYyBp
bnQgcHdtX2JhY2tsaWdodF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAg
Cj4gICAJZGV2X2RiZygmcGRldi0+ZGV2LCAiZ290IHB3bSBmb3IgYmFja2xpZ2h0XG4iKTsKPiAg
IAo+IC0JaWYgKCFkYXRhLT5sZXZlbHMpIHsKPiAtCQkvKiBHZXQgdGhlIFBXTSBwZXJpb2QgKGlu
IG5hbm9zZWNvbmRzKSAqLwo+IC0JCXB3bV9nZXRfc3RhdGUocGItPnB3bSwgJnN0YXRlKTsKPiAr
CS8qIFN5bmMgdXAgUFdNIHN0YXRlIGFuZCBlbnN1cmUgaXQgaXMgb2ZmLiAqLwo+ICsJcHdtX2lu
aXRfc3RhdGUocGItPnB3bSwgJnN0YXRlKTsKPiArCXN0YXRlLmVuYWJsZWQgPSBmYWxzZTsKPiAr
CXJldCA9IHB3bV9hcHBseV9zdGF0ZShwYi0+cHdtLCAmc3RhdGUpOwoKV2h5IGRvIHdlIGVuc3Vy
ZSB0aGUgUFdNIGlzIG9mZj8gRG9lcyB0aGlzIGNhdXNlIGJhY2tsaWdodCBmbGlja2VycyBvciAK
bWFrZSBzb21lIG9mIHRoZSBjb2RlIGluIHB3bV9iYWNrbGlnaHRfaW5pdGlhbF9wb3dlcl9zdGF0
ZSgpIHVucmVhY2hhYmxlPwoKCj4gKwlpZiAocmV0KSB7Cj4gKwkJZGV2X2VycigmcGRldi0+ZGV2
LCAiZmFpbGVkIHRvIGFwcGx5IGluaXRpYWwgUFdNIHN0YXRlOiAlZFxuIiwKPiArCQkJcmV0KTsK
PiArCQlnb3RvIGVycl9hbGxvYzsKPiArCX0KPiAgIAo+ICsJaWYgKCFkYXRhLT5sZXZlbHMpIHsK
PiAgIAkJcmV0ID0gcHdtX2JhY2tsaWdodF9icmlnaHRuZXNzX2RlZmF1bHQoJnBkZXYtPmRldiwg
ZGF0YSwKPiAgIAkJCQkJCSAgICAgICBzdGF0ZS5wZXJpb2QpOwo+ICAgCQlpZiAocmV0IDwgMCkg
ewo+IEBAIC01NTksMjAgKzU3OCwxMyBAQCBzdGF0aWMgaW50IHB3bV9iYWNrbGlnaHRfcHJvYmUo
c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgIAkJcGItPmxldmVscyA9IGRhdGEtPmxl
dmVsczsKPiAgIAl9Cj4gICAKPiAtCS8qCj4gLQkgKiBGSVhNRTogcHdtX2FwcGx5X2FyZ3MoKSBz
aG91bGQgYmUgcmVtb3ZlZCB3aGVuIHN3aXRjaGluZyB0bwo+IC0JICogdGhlIGF0b21pYyBQV00g
QVBJLgo+IC0JICovCj4gLQlwd21fYXBwbHlfYXJncyhwYi0+cHdtKTsKPiAtCj4gICAJLyoKPiAg
IAkgKiBUaGUgRFQgY2FzZSB3aWxsIHNldCB0aGUgcHdtX3BlcmlvZF9ucyBmaWVsZCB0byAwIGFu
ZCBzdG9yZSB0aGUKPiAgIAkgKiBwZXJpb2QsIHBhcnNlZCBmcm9tIHRoZSBEVCwgaW4gdGhlIFBX
TSBkZXZpY2UuIEZvciB0aGUgbm9uLURUIGNhc2UsCj4gICAJICogc2V0IHRoZSBwZXJpb2QgZnJv
bSBwbGF0Zm9ybSBkYXRhIGlmIGl0IGhhcyBub3QgYWxyZWFkeSBiZWVuIHNldAo+ICAgCSAqIHZp
YSB0aGUgUFdNIGxvb2t1cCB0YWJsZS4KPiAgIAkgKi8KPiAtCXB3bV9nZXRfYXJncyhwYi0+cHdt
LCAmcGFyZ3MpOwo+IC0JcGItPnBlcmlvZCA9IHBhcmdzLnBlcmlvZDsKPiArCXBiLT5wZXJpb2Qg
PSBzdGF0ZS5wZXJpb2Q7Cj4gICAJaWYgKCFwYi0+cGVyaW9kICYmIChkYXRhLT5wd21fcGVyaW9k
X25zID4gMCkpCj4gICAJCXBiLT5wZXJpb2QgPSBkYXRhLT5wd21fcGVyaW9kX25zOwoKQ291bGQg
d2UgaGF2ZSBkZWxheWVkIGFwcGx5aW5nIHRoZSBzdGF0ZSB1bnRpbCB3ZSBrbm93IHdoYXQgdGhl
IHBlcmlvZCAKaXMgc3VwcG9zZWQgdG8gYmU/IE5vIG90aGVyIGNhbGwgdG8gcHdtX2FwcGx5X3N0
YXRlKCkgaGFzIGl0cyBlcnJvciAKdmFsdWUgY2hlY2tlZC4uLiBzbyBpZiB0aGVyZSBhcmUgcHJv
YmxlbXMgd2l0aCB0aGUgcGVyaW9kIHdlIGNvdWxkIApkZXRlY3QgdGhlbSBoZXJlLgoKTm90ZSBh
bHNvIHRoYXQgd2UgY2FuIGd1YXJhbnRlZSB0aGUgcGVyaW9kIGlzIHNldCBiZWZvcmUgdGhlIHBy
b2JlIApjb21wbGV0ZXMgdGhlbiBJIHRoaW5rIHBiLT5wZXJpb2QgY291bGQgYmUgcmVtb3ZlZCBl
bnRpcmVseS4gSXQgd2FzIG9ubHkgCnJlYWxseSBiZWluZyBjYXJyaWVkIGFyb3VuZCB0byBoZWxw
IHdpdGggY2FsbHMgdG8gcHdtX2NvbmZpZygpIGFuZCB0aGVzZSAKbm8gbG9uZ2VyIGV4aXN0LgoK
CkRhbmllbC4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==