From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A702E7D27A for ; Tue, 26 Sep 2023 10:35:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EA4310E0E7; Tue, 26 Sep 2023 10:35:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBF6010E0E7 for ; Tue, 26 Sep 2023 10:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695724542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IN3gjXP/ulM4+M4Osvjbx+CJvR8HzZe/I6zVYXrFanI=; b=QWhP+Nn9JdBPR6dMiaRZrordaQhXo60tZC/aLFaBF080fwk7sH1fuq4DbeTYU/XN3tOsnx iDbyFUELSwd7usBUeX6QzF55ac2CoumKxKpTNboJ6zPrM+Gxzt714uhhgbviDm0OTnCPLq HK9ryH3TnTOvQH7TUogku4vGcnenJ9Q= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-80lI8PwKPQCWNSVZWGMn4A-1; Tue, 26 Sep 2023 06:35:41 -0400 X-MC-Unique: 80lI8PwKPQCWNSVZWGMn4A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50421897564so13075001e87.0 for ; Tue, 26 Sep 2023 03:35:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695724540; x=1696329340; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IN3gjXP/ulM4+M4Osvjbx+CJvR8HzZe/I6zVYXrFanI=; b=jQzBm/dIr9MLIBKYTD7RsOFjrBob/zTZCYhZOLkxNOG9cHVA51NORN2IN3PJzrpvth bS7bY165EzW+gX6f8bmKHR8ztmHokk2QZotGIEXgWWJFKku1Fn1eXmLsyxWcDsBCXCn2 +K8CBVNV1DmKyvWptxJtxqHDKCb3NJ8Gd+Z1pqU134omR5yDAt29QyEHzd36Wqu9wtQP wpLb49N298OaHscbxRjAwb77Dk8de7u/qhRtCJW5TjIQPuKNmxJDMRt2BZu1P7A7eDnZ CptFIqH+4xJAeFVoNst9o3l7RyRU7sYVWs7pR/tAVgdKVjWm41dOGA0dXna+V9lSI+tJ tIjQ== X-Gm-Message-State: AOJu0YwMxKd3b4eUGx0yjxTPeSEZQRSKSflhOcmaoFLkJV0VI7tUYLp1 3tiXn6oJ0ACVp0mFVszUqnygi4SOYBwC6lOkEJajy5IsxYm57PeyK23tvRneEcbQenxDJbYf+N3 9M7127fz0OPh0ujJGOmhm5kbJCtid X-Received: by 2002:a05:6512:3d21:b0:503:655:12e7 with SMTP id d33-20020a0565123d2100b00503065512e7mr10393196lfv.62.1695724539871; Tue, 26 Sep 2023 03:35:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGn3ozsYpRq6AuJvRaLBGJ3+5/IVA5BsFnkHEF6nwZAP0ixv8ZfQALU7T1Ot7RrjwRGez4gGg== X-Received: by 2002:a05:6512:3d21:b0:503:655:12e7 with SMTP id d33-20020a0565123d2100b00503065512e7mr10393157lfv.62.1695724539418; Tue, 26 Sep 2023 03:35:39 -0700 (PDT) Received: from [192.168.1.217] ([109.37.154.108]) by smtp.gmail.com with ESMTPSA id c19-20020a056402121300b0052e9b50dafdsm6556318edw.33.2023.09.26.03.35.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Sep 2023 03:35:38 -0700 (PDT) Message-ID: <2e201a3b-d75f-916d-5135-b084ad5da23e@redhat.com> Date: Tue, 26 Sep 2023 12:35:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface To: Shyam Sundar S K , markgross@kernel.org, basavaraj.natikar@amd.com, jikos@kernel.org, benjamin.tissoires@redhat.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch References: <20230922175056.244940-1-Shyam-sundar.S-k@amd.com> <20230922175056.244940-14-Shyam-sundar.S-k@amd.com> From: Hans de Goede In-Reply-To: <20230922175056.244940-14-Shyam-sundar.S-k@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, dri-devel@lists.freedesktop.org, Patil.Reddy@amd.com, linux-input@vger.kernel.org, mario.limonciello@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 9/22/23 19:50, Shyam Sundar S K wrote: > For the Smart PC Solution to fully work, it has to enact to the actions > coming from TA. Add the initial code path for set interface to AMDGPU. > > Co-developed-by: Mario Limonciello > Signed-off-by: Mario Limonciello > Signed-off-by: Shyam Sundar S K > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 21 +++++++++++++++++++++ > drivers/platform/x86/amd/pmf/pmf.h | 2 ++ > drivers/platform/x86/amd/pmf/tee-if.c | 19 +++++++++++++++++-- > include/linux/amd-pmf-io.h | 1 + > 4 files changed, 41 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c > index 232d11833ddc..5c567bff0548 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c > @@ -68,3 +68,24 @@ int amd_pmf_get_gfx_data(struct amd_gpu_pmf_data *pmf) > return 0; > } > EXPORT_SYMBOL_GPL(amd_pmf_get_gfx_data); > + > +int amd_pmf_set_gfx_data(struct amd_gpu_pmf_data *pmf) > +{ > + struct drm_device *drm_dev = pci_get_drvdata(pmf->gpu_dev); > + struct amdgpu_device *adev = drm_to_adev(drm_dev); > + struct backlight_device *bd; > + > + if (!(adev->flags & AMD_IS_APU)) { > + DRM_ERROR("PMF-AMDGPU interface not supported\n"); > + return -ENODEV; > + } > + > + bd = backlight_device_get_by_type(BACKLIGHT_RAW); > + if (!bd) > + return -ENODEV; This assumes that the backlight is always controller by the amdgpu's native backlight driver, but it might e.g. also be handled by eacpi-video or by nvidia_wmi_ec_backlight (when using an AMD APU + nvidia dgpu). For now what should be done here is to call acpi_video_get_backlight_type() and then translate the return value from this into a backlight-type: acpi_backlight_video -> BACKLIGHT_FIRMWARE acpi_backlight_vendor, -> BACKLIGHT_PLATFORM acpi_backlight_native, -> BACKLIGHT_RAW acpi_backlight_nvidia_wmi_ec, -> BACKLIGHT_FIRMWARE acpi_backlight_apple_gmux, -> BACKLIGHT_PLATFORM Also I'm worried about probe order here, this code currently assumes that the GPU or other backlight driver has loaded before this runs, which is not necessarily the case. I think that if the backlight_device_get_by_type() fails this should be retried say every 10 seconds from some delayed workqueue for at least a couple of minutes after boot. Regards, Hans > + > + backlight_device_set_brightness(bd, pmf->brightness); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(amd_pmf_set_gfx_data); > diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h > index 9032df4ba48a..ce89cc0daa5a 100644 > --- a/drivers/platform/x86/amd/pmf/pmf.h > +++ b/drivers/platform/x86/amd/pmf/pmf.h > @@ -73,6 +73,7 @@ > #define PMF_POLICY_STT_SKINTEMP_APU 7 > #define PMF_POLICY_STT_SKINTEMP_HS2 8 > #define PMF_POLICY_SYSTEM_STATE 9 > +#define PMF_POLICY_DISPLAY_BRIGHTNESS 12 > #define PMF_POLICY_P3T 38 > > /* TA macros */ > @@ -480,6 +481,7 @@ enum ta_pmf_error_type { > }; > > struct pmf_action_table { > + unsigned long display_brightness; > enum system_state system_state; > unsigned long spl; /* in mW */ > unsigned long sppt; /* in mW */ > diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c > index 1608996654e8..eefffff83a4c 100644 > --- a/drivers/platform/x86/amd/pmf/tee-if.c > +++ b/drivers/platform/x86/amd/pmf/tee-if.c > @@ -79,10 +79,10 @@ static int amd_pmf_update_uevents(struct amd_pmf_dev *dev, u16 event) > return 0; > } > > -static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_result *out) > +static int amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_result *out) > { > u32 val, event = 0; > - int idx; > + int idx, ret; > > for (idx = 0; idx < out->actions_count; idx++) { > val = out->actions_list[idx].value; > @@ -160,8 +160,23 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_ > dev->prev_data->system_state = 0; > } > break; > + > + case PMF_POLICY_DISPLAY_BRIGHTNESS: > + ret = amd_pmf_get_gfx_data(&dev->gfx_data); > + if (ret) > + return ret; > + > + dev->prev_data->display_brightness = dev->gfx_data.brightness; > + if (dev->prev_data->display_brightness != val) { > + dev->gfx_data.brightness = val; > + amd_pmf_set_gfx_data(&dev->gfx_data); > + dev_dbg(dev->dev, "update DISPLAY_BRIGHTNESS : %d\n", val); > + } > + break; > } > } > + > + return 0; > } > > static int amd_pmf_invoke_cmd_enact(struct amd_pmf_dev *dev) > diff --git a/include/linux/amd-pmf-io.h b/include/linux/amd-pmf-io.h > index a2d4af231362..ecae387ddaa6 100644 > --- a/include/linux/amd-pmf-io.h > +++ b/include/linux/amd-pmf-io.h > @@ -25,4 +25,5 @@ struct amd_gpu_pmf_data { > }; > > int amd_pmf_get_gfx_data(struct amd_gpu_pmf_data *pmf); > +int amd_pmf_set_gfx_data(struct amd_gpu_pmf_data *pmf); > #endif