From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2 Date: Tue, 3 Jul 2018 13:46:44 +0200 Message-ID: <2ebff18b-414d-c971-1b7f-f6a21aacf196@gmail.com> References: <20180622141103.1787-1-christian.koenig@amd.com> <20180622141103.1787-3-christian.koenig@amd.com> <20180625082231.GM2958@phenom.ffwll.local> <20180625091217.GO2958@phenom.ffwll.local> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180625091217.GO2958@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: linaro-mm-sig@lists.linaro.org, intel-gfx@lists.freedesktop.org, sumit.semwal@linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org QW0gMjUuMDYuMjAxOCB1bSAxMToxMiBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gT24gTW9uLCBK dW4gMjUsIDIwMTggYXQgMTA6MjI6MzFBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPj4g T24gRnJpLCBKdW4gMjIsIDIwMTggYXQgMDQ6MTE6MDFQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPj4+IEZpcnN0IHN0ZXAgdG93YXJkcyB1bnBpbm5lZCBETUEgYnVmIG9wZXJhdGlv bi4KPj4+Cj4+PiBJJ3ZlIGNoZWNrZWQgdGhlIERSTSBkcml2ZXJzIHRvIHBvdGVudGlhbCBsb2Nr aW5nIG9mIHRoZSByZXNlcnZhdGlvbgo+Pj4gb2JqZWN0LCBidXQgZXNzZW50aWFsbHkgd2UgbmVl ZCB0byBhdWRpdCBhbGwgaW1wbGVtZW50YXRpb25zIG9mIHRoZQo+Pj4gZG1hX2J1ZiBfb3BzIGZv ciB0aGlzIHRvIHdvcmsuCj4+Pgo+Pj4gdjI6IHJlb3JkZXJlZAo+Pj4KPj4+IFNpZ25lZC1vZmYt Ynk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPj4gUmV2aWV3 ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gT2sgSSBkaWQg cmV2aWV3IGRyaXZlcnMgYSBiaXQsIGJ1dCBhcHBhcmVudGx5IG5vdCB3ZWxsIGVub3VnaCBieSBm YXIuIGk5MTUKPiBDSSBpcyB1bmhhcHB5Ogo+Cj4gaHR0cHM6Ly9pbnRlbC1nZngtY2kuMDEub3Jn L3RyZWUvZHJtLXRpcC9QYXRjaHdvcmtfOTQwMC9maS13aGwtdS9pZ3RAZ2VtX21tYXBfZ3R0QGJh c2ljLXNtYWxsLWJvLXRpbGVkeC5odG1sCj4KPiBTbyB5ZWFoIGluc2VydGluZyB0aGF0IGxvY2sg aW4gdGhlcmUgaXNuJ3QgdGhlIG1vc3QgdHJpdmlhbCB0aGluZyA6LS8KPgo+IEkga2luZGEgYXNz dW1lIHRoYXQgb3RoZXIgZHJpdmVycyB3aWxsIGhhdmUgc2ltaWxhciBpc3N1ZXMsIGUuZy4gb21h cGRybSdzCj4gdXNlIG9mIGRldi0+c3RydWN0X211dGV4IGFsc28gdmVyeSBtdWNoIGxvb2tzIGxp a2UgaXQnbGwgcmVzdWx0IGluIGEgbmV3Cj4gbG9ja2luZyBpbnZlcnNpb24uCgpBaCwgY3JhcC4g QWxyZWFkeSBmZWFyZWQgdGhhdCB0aGlzIHdvdWxkbid0IGJlIGVhc3ksIGJ1dCB5ZWFoIHRoYXQg aXQgaXMgCmFzIGJhZCBhcyB0aGlzIGlzIHJhdGhlciBkaXNhcHBvaW50aW5nLgoKVGhhbmtzIGZv ciB0aGUgaW5mbywgZ29pbmcgdG8ga2VlcCB0aGlua2luZyBhYm91dCBob3cgdG8gc29sdmUgdGhv c2UgaXNzdWVzLgoKQ2hyaXN0aWFuLgoKPiAtRGFuaWVsCj4KPj4+IC0tLQo+Pj4gICBkcml2ZXJz L2RtYS1idWYvZG1hLWJ1Zi5jIHwgOSArKysrKystLS0KPj4+ICAgaW5jbHVkZS9saW51eC9kbWEt YnVmLmggICB8IDQgKysrKwo+Pj4gICAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hLWJ1Zi9kbWEt YnVmLmMgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWJ1Zi5jCj4+PiBpbmRleCBkYzk0ZTc2ZTJlMmEu LjQ5ZjIzYjc5MWViOCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMK Pj4+ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMKPj4+IEBAIC02NjUsNyArNjY1LDkg QEAgc3RydWN0IHNnX3RhYmxlICpkbWFfYnVmX21hcF9hdHRhY2htZW50KHN0cnVjdCBkbWFfYnVm X2F0dGFjaG1lbnQgKmF0dGFjaCwKPj4+ICAgCWlmIChXQVJOX09OKCFhdHRhY2ggfHwgIWF0dGFj aC0+ZG1hYnVmKSkKPj4+ICAgCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPj4+ICAgCj4+PiAt CXNnX3RhYmxlID0gYXR0YWNoLT5kbWFidWYtPm9wcy0+bWFwX2RtYV9idWYoYXR0YWNoLCBkaXJl Y3Rpb24pOwo+Pj4gKwlyZXNlcnZhdGlvbl9vYmplY3RfbG9jayhhdHRhY2gtPmRtYWJ1Zi0+cmVz diwgTlVMTCk7Cj4+PiArCXNnX3RhYmxlID0gZG1hX2J1Zl9tYXBfYXR0YWNobWVudF9sb2NrZWQo YXR0YWNoLCBkaXJlY3Rpb24pOwo+Pj4gKwlyZXNlcnZhdGlvbl9vYmplY3RfdW5sb2NrKGF0dGFj aC0+ZG1hYnVmLT5yZXN2KTsKPj4+ICAgCWlmICghc2dfdGFibGUpCj4+PiAgIAkJc2dfdGFibGUg PSBFUlJfUFRSKC1FTk9NRU0pOwo+Pj4gICAKPj4+IEBAIC03MTUsOCArNzE3LDkgQEAgdm9pZCBk bWFfYnVmX3VubWFwX2F0dGFjaG1lbnQoc3RydWN0IGRtYV9idWZfYXR0YWNobWVudCAqYXR0YWNo LAo+Pj4gICAJaWYgKFdBUk5fT04oIWF0dGFjaCB8fCAhYXR0YWNoLT5kbWFidWYgfHwgIXNnX3Rh YmxlKSkKPj4+ICAgCQlyZXR1cm47Cj4+PiAgIAo+Pj4gLQlhdHRhY2gtPmRtYWJ1Zi0+b3BzLT51 bm1hcF9kbWFfYnVmKGF0dGFjaCwgc2dfdGFibGUsCj4+PiAtCQkJCQkJZGlyZWN0aW9uKTsKPj4+ ICsJcmVzZXJ2YXRpb25fb2JqZWN0X2xvY2soYXR0YWNoLT5kbWFidWYtPnJlc3YsIE5VTEwpOwo+ Pj4gKwlkbWFfYnVmX3VubWFwX2F0dGFjaG1lbnRfbG9ja2VkKGF0dGFjaCwgc2dfdGFibGUsIGRp cmVjdGlvbik7Cj4+PiArCXJlc2VydmF0aW9uX29iamVjdF91bmxvY2soYXR0YWNoLT5kbWFidWYt PnJlc3YpOwo+Pj4gICB9Cj4+PiAgIEVYUE9SVF9TWU1CT0xfR1BMKGRtYV9idWZfdW5tYXBfYXR0 YWNobWVudCk7Cj4+PiAgIAo+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZG1hLWJ1Zi5o IGIvaW5jbHVkZS9saW51eC9kbWEtYnVmLmgKPj4+IGluZGV4IGEyNWU3NTRhZTJmNy4uMDI0NjU4 ZDFmMjJlIDEwMDY0NAo+Pj4gLS0tIGEvaW5jbHVkZS9saW51eC9kbWEtYnVmLmgKPj4+ICsrKyBi L2luY2x1ZGUvbGludXgvZG1hLWJ1Zi5oCj4+PiBAQCAtMTE4LDYgKzExOCw4IEBAIHN0cnVjdCBk bWFfYnVmX29wcyB7Cj4+PiAgIAkgKiBhbnkgb3RoZXIga2luZCBvZiBzaGFyaW5nIHRoYXQgdGhl IGV4cG9ydGVyIG1pZ2h0IHdpc2ggdG8gbWFrZQo+Pj4gICAJICogYXZhaWxhYmxlIHRvIGJ1ZmZl ci11c2Vycy4KPj4+ICAgCSAqCj4+PiArCSAqIFRoaXMgaXMgY2FsbGVkIHdpdGggdGhlIGRtYWJ1 Zi0+cmVzdiBvYmplY3QgbG9ja2VkLgo+Pj4gKwkgKgo+Pj4gICAJICogUmV0dXJuczoKPj4+ICAg CSAqCj4+PiAgIAkgKiBBICZzZ190YWJsZSBzY2F0dGVyIGxpc3Qgb2Ygb3IgdGhlIGJhY2tpbmcg c3RvcmFnZSBvZiB0aGUgRE1BIGJ1ZmZlciwKPj4+IEBAIC0xMzgsNiArMTQwLDggQEAgc3RydWN0 IGRtYV9idWZfb3BzIHsKPj4+ICAgCSAqIEl0IHNob3VsZCBhbHNvIHVucGluIHRoZSBiYWNraW5n IHN0b3JhZ2UgaWYgdGhpcyBpcyB0aGUgbGFzdCBtYXBwaW5nCj4+PiAgIAkgKiBvZiB0aGUgRE1B IGJ1ZmZlciwgaXQgdGhlIGV4cG9ydGVyIHN1cHBvcnRzIGJhY2tpbmcgc3RvcmFnZQo+Pj4gICAJ ICogbWlncmF0aW9uLgo+Pj4gKwkgKgo+Pj4gKwkgKiBUaGlzIGlzIGNhbGxlZCB3aXRoIHRoZSBk bWFidWYtPnJlc3Ygb2JqZWN0IGxvY2tlZC4KPj4+ICAgCSAqLwo+Pj4gICAJdm9pZCAoKnVubWFw X2RtYV9idWYpKHN0cnVjdCBkbWFfYnVmX2F0dGFjaG1lbnQgKiwKPj4+ICAgCQkJICAgICAgc3Ry dWN0IHNnX3RhYmxlICosCj4+PiAtLSAKPj4+IDIuMTQuMQo+Pj4KPj4gLS0gCj4+IERhbmllbCBW ZXR0ZXIKPj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4+IGh0dHA6Ly9i bG9nLmZmd2xsLmNoCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK