From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sharma, Jitendra" Subject: Re: [PATCH v2] drm/bridge: adv7511: Remove unused code blocks Date: Thu, 20 Oct 2016 14:56:36 +0530 Message-ID: <2f4e7ee7-8fe2-7960-664c-1bc5c393bd7c@codeaurora.org> References: <1476785398-27255-1-git-send-email-shajit@codeaurora.org> <3685503.gXBRGfjrFE@avalon> <2505713.JpW5SKnp2Y@avalon> <20161020084535.GA1442@katana> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0306808817==" Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8332E6EADD for ; Thu, 20 Oct 2016 09:26:41 +0000 (UTC) In-Reply-To: <20161020084535.GA1442@katana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wolfram Sang , Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============0306808817== Content-Type: multipart/alternative; boundary="------------8C384D649D8B623813ADBA57" This is a multi-part message in MIME format. --------------8C384D649D8B623813ADBA57 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for comments. On 10/20/2016 2:15 PM, Wolfram Sang wrote: >>> IMO it would be better to use id->driver_data unconditionally and save a >>> call to of_device_get_match_data() >>> What would you suggest to move ahead? >> I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's >> opinion on this (CC'ed). > IIUC: I'd suggest to leave it as it is. > > There are people working on removing the quirky fallback to > i2c_device_id in case of_compatible is not provided. If that gets > mainline, you don't have i2c_device_id anymore with DT matching. So all > binding methods should be self-contained. ok Should we leave as it is, redundant if-else code block also, or fix it as posted in patch v2 > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --------------8C384D649D8B623813ADBA57 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Thanks for comments.


On 10/20/2016 2:15 PM, Wolfram Sang wrote:

      

        

          
IMO it would be better to use id->driver_data unconditionally and save a
call to of_device_get_match_data()
What would you suggest to move ahead?


        

        
I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's 
opinion on this (CC'ed).


      

      
IIUC: I'd suggest to leave it as it is.

There are people working on removing the quirky fallback to
i2c_device_id in case of_compatible is not provided. If that gets
mainline, you don't have i2c_device_id anymore with DT matching. So all
binding methods should be self-contained.

    

    ok

    Should we leave as it is, redundant if-else code block also, or fix
    it as posted in patch v2

    

      



      

      

      

      
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


    

    

  


--------------8C384D649D8B623813ADBA57--

--===============0306808817==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0306808817==--