From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: "Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
Daniel Vetter <daniel@ffwll.ch>"Zhou,
David(ChunMing)" <David1.Zhou@amd.com>
Cc: Dave Airlie <airlied@redhat.com>,
"Rakos, Daniel" <Daniel.Rakos@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/7] drm: add syncobj timeline support v8
Date: Wed, 17 Oct 2018 09:29:01 +0000 [thread overview]
Message-ID: <2f99da09-7bf7-d5e7-d7c1-fe2e4cf43b40@amd.com> (raw)
In-Reply-To: <2066a18d-8002-014b-ef3c-a6f6014bdb55@amd.com>
Am 17.10.18 um 11:17 schrieb zhoucm1:
> [SNIP]
>>> +struct drm_syncobj_signal_pt {
>>> + struct dma_fence_array *base;
>> Out of curiosity, why the pointer and not embedding? base is kinda
>> misleading for a pointer.
> Yeah, Christian doesn't like signal_pt lifecycle same as fence, so
> it's a pointer.
> If you don't like 'base' name, I can change it.
Well I never said that you can't embed the fence array into the signal_pt.
You just need to make sure that we don't affect the drm_syncobj
lilecycle as well, e.g. that we don't also need to keep that around.
Regards,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-17 9:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 8:55 [PATCH 1/7] drm: add flags to drm_syncobj_find_fence Chunming Zhou
2018-10-15 8:55 ` [PATCH 2/7] drm: add syncobj timeline support v8 Chunming Zhou
2018-10-17 8:09 ` Daniel Vetter
[not found] ` <20181017080908.GK31561-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-10-17 9:17 ` zhoucm1
2018-10-17 9:29 ` Koenig, Christian [this message]
2018-10-17 10:24 ` Daniel Vetter
[not found] ` <CAKMK7uGxptMKtz-4JzT9us3M2dsLGhTSVuAKduNH+VGCsCSsQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-18 3:11 ` zhoucm1
[not found] ` <b08b1f23-d8dc-a294-2176-5125075c9acc-5C7GfCeVMHo@public.gmane.org>
2018-10-18 11:50 ` Christian König
2018-10-19 2:29 ` zhoucm1
2018-10-19 8:55 ` Daniel Vetter
2018-10-19 9:20 ` zhoucm1
[not found] ` <19972bac-f2a9-49ee-592d-85f9eaf06145-5C7GfCeVMHo@public.gmane.org>
2018-10-19 10:12 ` zhoucm1
[not found] ` <22a52713-0ab5-80d9-a604-b171f916eedd-5C7GfCeVMHo@public.gmane.org>
2018-10-19 10:45 ` zhoucm1
[not found] ` <69039ffa-425e-81e7-4b08-1d431d8a212f-5C7GfCeVMHo@public.gmane.org>
2018-10-19 18:17 ` Daniel Vetter
[not found] ` <2066a18d-8002-014b-ef3c-a6f6014bdb55-5C7GfCeVMHo@public.gmane.org>
2018-10-17 10:22 ` Daniel Vetter
[not found] ` <CAKMK7uEEKpzjdON-qOstM67OYfDjHc5gS0+kSpuh1pm5t4BAHA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-17 10:37 ` zhoucm1
[not found] ` <20181015085553.30656-2-david1.zhou-5C7GfCeVMHo@public.gmane.org>
2018-10-19 8:49 ` Chris Wilson
2018-10-15 8:55 ` [PATCH 3/7] drm: add support of syncobj timeline point wait v2 Chunming Zhou
2018-10-15 8:55 ` [PATCH 4/7] drm: add timeline syncobj payload query ioctl v2 Chunming Zhou
[not found] ` <20181015085553.30656-1-david1.zhou-5C7GfCeVMHo@public.gmane.org>
2018-10-15 8:55 ` [PATCH 5/7] drm: add timeline support for syncobj export/import Chunming Zhou
2018-10-15 8:55 ` [PATCH 6/7] drm/amdgpu: add timeline support in amdgpu CS v2 Chunming Zhou
2018-10-15 8:55 ` [PATCH 7/7] drm/amdgpu: update version for timeline syncobj support in amdgpu Chunming Zhou
2018-10-15 9:01 ` Zhou, David(ChunMing)
[not found] ` <BY1PR12MB0502F0E543F50239A43E5F94B4FD0-PicGAnIBOobrCwm+z9iKNgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-10-15 9:04 ` Koenig, Christian
[not found] ` <cf4590f5-8e0a-ac0e-f34b-3e1b4b01fd99-5C7GfCeVMHo@public.gmane.org>
2018-10-16 12:54 ` Christian König
[not found] ` <dcb28515-7250-9a1c-2784-a4cbf517e467-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-17 7:46 ` zhoucm1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f99da09-7bf7-d5e7-d7c1-fe2e4cf43b40@amd.com \
--to=christian.koenig@amd.com \
--cc=Daniel.Rakos@amd.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox