From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling. Date: Tue, 27 Jun 2017 16:29:44 +0200 Message-ID: <2fa47671-6a2b-5a19-3072-e7f59b92cb4d@linux.intel.com> References: <0d603149-3fb0-3d48-89e5-77e3f7686415@amd.com> <1497981426-27203-1-git-send-email-Andrey.Grodzovsky@amd.com> <26571917-afb7-fb53-c002-5869cf8ccdf9@amd.com> <20170627073740.wz5xix2ecmvh4rbn@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170627073740.wz5xix2ecmvh4rbn-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Harry Wentland , Andrey Grodzovsky , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T3AgMjctMDYtMTcgb20gMDk6Mzcgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIE1vbiwgSnVu IDI2LCAyMDE3IGF0IDAzOjQ0OjA3UE0gLTA0MDAsIEhhcnJ5IFdlbnRsYW5kIHdyb3RlOgo+PiBP biAyMDE3LTA2LTIwIDAxOjU3IFBNLCBBbmRyZXkgR3JvZHpvdnNreSB3cm90ZToKPj4+IFByb2Js ZW0gOiBXaGlsZSBydW5uaW5nIElHVCBrbXNfYXRvbWljX3RyYW5zaXRpb24gdGVzdCBzdWl0ZSBp IGVuY291bnRlcmVkCj4+PiBhIGhhbmcgaW4gZHJtSGFuZGxlRXZlbnQgaW1tZWRpYXRlbHkgZm9s bG93aW5nICBhbiBhdG9taWNfY29tbWl0Lgo+Pj4gQWZ0ZXIgZHVtcGluZyB0aGUgYXRvbWljIHN0 YXRlIEkgcmVsaXplZCB0aGF0IGluIHRoaXMgY2FzZSB0aGVyZSB3YXMKPj4+IG5vdCBldmVuIG9u ZSBDUlRDIGF0dGFjaGVkIHRvIHRoZSBzdGF0ZSBhbmQgb25seSBkaXNhYmxlZAo+Pj4gcGxhbmVz LiBUaGlzIHByb2JhYmx5IGR1ZSB0byBhIGNvbW1pdCB3aGljaCBoYWRuJ3QgY2hhbmdlZCBhbnkg cHJvcGVydHkKPj4+IHdoaWNoIHdvdWxkIHJlcXVpcmUgYXR0YWNoaW5nIGNydGMgc3RhdGUuIFRo aXMgbWVhbnMgZHJtSGFuZGxlRXZlbnQKPj4+IHdpbGwgbmV2ZXIgd2FrZSB1cCBmcm9tIHJlYWQg c2luY2Ugd2l0aG91dCBDUlRDIGluIGF0b21pYyBzdGF0ZQo+Pj4gdGhlIGV2ZW50IGZkIHdpbGwg bm90IGJlIHNpZ25hbGVkLgo+Pj4KPj4+IEZpeDogUHJvdGVjdCBhZ2FpbnN0IHRoaXMgaXNzdWUg YnkgZmFpbGluZyBhdG9taWNfY29tbWl0IGVhcmx5IGluCj4+PiBkcm1fbW9kZV9hdG9taWNfY29t bWl0IHdoZXJlIHN1Y2ggcHJvYmVsbSBjYW4gYmUgaWRlbnRpZmllZC4KPj4+Cj4+PiB2MjoKPj4+ IEZpeCB0eXBvcyBhbmQgZXh0cmEgbmV3bGluZXMuCj4+Pgo+Pj4gQ2hhbmdlLUlkOiBJM2VlMjhm ZmFlMzVmZDFlOGJmZTU1MzE0NmM0NGRhNTNkYTAyZTZmOAo+Pj4gU2lnbmVkLW9mZi1ieTogQW5k cmV5IEdyb2R6b3Zza3kgPEFuZHJleS5Hcm9kem92c2t5QGFtZC5jb20+Cj4+IFJldmlld2VkLWJ5 OiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KPiBTdGFsbGluZyBvbiB0 aGlzIGhvcGluZyBmb3IgdGhlIGlndCBwYXRjaC4gRG9lcyBpdCBleGlzdCBhbHJlYWR5Pwo+IC1E YW5pZWwKPgo+PiBIYXJyeQo+Pgo+Pj4gLS0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWMuYyB8IDExICsrKysrKysrKystCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPj4+IGluZGV4IGE1Njcz MTAuLjQ4MTQ1YmYgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5j Cj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4+PiBAQCAtMTkzMyw3ICsx OTMzLDcgQEAgc3RhdGljIGludCBwcmVwYXJlX2NydGNfc2lnbmFsaW5nKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4+PiAgewo+Pj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+PiAgCXN0cnVj dCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4+IC0JaW50IGksIHJldDsKPj4+ICsJaW50 IGksIGMgPSAwLCByZXQ7Cj4+PiAgCj4+PiAgCWlmIChhcmctPmZsYWdzICYgRFJNX01PREVfQVRP TUlDX1RFU1RfT05MWSkKPj4+ICAJCXJldHVybiAwOwo+Pj4gQEAgLTE5OTQsOCArMTk5NCwxNyBA QCBzdGF0aWMgaW50IHByZXBhcmVfY3J0Y19zaWduYWxpbmcoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPj4+ICAKPj4+ICAJCQljcnRjX3N0YXRlLT5ldmVudC0+YmFzZS5mZW5jZSA9IGZlbmNlOwo+ Pj4gIAkJfQo+Pj4gKwo+Pj4gKwkJYysrOwo+Pj4gIAl9Cj4+PiAgCj4+PiArCS8qCj4+PiArCSAq IEhhdmluZyB0aGlzIGZsYWcgbWVhbnMgdXNlciBtb2RlIHBlbmRzIG9uIGV2ZW50IHdoaWNoIHdp bGwgbmV2ZXIKPj4+ICsJICogcmVhY2ggZHVlIHRvIGxhY2sgb2YgYXQgbGVhc3Qgb25lIENSVEMg Zm9yIHNpZ25hbGluZwo+Pj4gKwkgKi8KPj4+ICsJaWYgKGMgPT0gMCAmJiAoYXJnLT5mbGFncyAm IERSTV9NT0RFX1BBR0VfRkxJUF9FVkVOVCkpCj4+PiArCQlyZXR1cm4gLUVJTlZBTDsKPj4+ICsK Pj4+ICAJcmV0dXJuIDA7Cj4+PiAgfQo+Pj4gIAo+Pj4KSnVzdCBkbyBpdCwgYW5kIEknbGwgY29t bWl0IHRoaXMgdG8gaWd0PwoKZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19hdG9taWMuYyBiL3Rlc3Rz L2ttc19hdG9taWMuYwppbmRleCA2Mzc1ZmVkZTcxNzkuLjc3NDI5YjNkYjM4NCAxMDA2NDQKLS0t IGEvdGVzdHMva21zX2F0b21pYy5jCisrKyBiL3Rlc3RzL2ttc19hdG9taWMuYwpAQCAtMTIwNSw2 ICsxMjA1LDE1IEBAIHN0YXRpYyB2b2lkIGNydGNfaW52YWxpZF9wYXJhbXMoc3RydWN0IGttc19h dG9taWNfY3J0Y19zdGF0ZSAqY3J0Y19vbGQsCiAJY3J0Y19jb21taXRfYXRvbWljKCZjcnRjLCBw bGFuZSwgcmVxLCBBVE9NSUNfUkVMQVhfTk9ORSwKIAkJCSAgIERSTV9NT0RFX0FUT01JQ19URVNU X09OTFkpOwogCisJLyoKKwkgKiBURVNUX09OTFkgY2Fubm90IGJlIGNvbWJpbmVkIHdpdGggRFJN X01PREVfUEFHRV9GTElQX0VWRU5ULAorCSAqIGJ1dCBEUk1fTU9ERV9QQUdFX0ZMSVBfRVZFTlQg d2lsbCBhbHdheXMgZ2VuZXJhdGUgRUlOVkFMCisJICogd2l0aG91dCB2YWxpZCBjcnRjLCBzbyB0 ZXN0IGl0IGhlcmUuCisJICovCisJY3J0Y19jb21taXRfYXRvbWljX2VycigmY3J0YywgcGxhbmUs IHJlcSwgQVRPTUlDX1JFTEFYX05PTkUsCisJCQkgICAgICAgRFJNX01PREVfQVRPTUlDX1RFU1Rf T05MWSB8IERSTV9NT0RFX1BBR0VfRkxJUF9FVkVOVCwKKwkJCSAgICAgICBFSU5WQUwpOworCiAJ LyogQ3JlYXRlIGEgYmxvYiB3aGljaCBpcyB0aGUgd3Jvbmcgc2l6ZSB0byBiZSBhIHZhbGlkIG1v ZGUuICovCiAJZG9fb3JfZGllKGRybU1vZGVDcmVhdGVQcm9wZXJ0eUJsb2IoY3J0Yy5zdGF0ZS0+ ZGVzYy0+ZmQsCiAJCQkJCSAgICBjcnRjLm1vZGUuZGF0YSwKQEAgLTEzNTYsMTIgKzEzNjUsMTIg QEAgc3RhdGljIHZvaWQgYXRvbWljX2ludmFsaWRfcGFyYW1zKHN0cnVjdCBrbXNfYXRvbWljX2Ny dGNfc3RhdGUgKmNydGMsCiAJLyogVmFsaWQgcG9pbnRlcnMsIGJ1dCBzdGlsbCBzaG91bGQgY29w eSBub3RoaW5nLiAqLwogCWRvX2lvY3RsKGRlc2MtPmZkLCBEUk1fSU9DVExfTU9ERV9BVE9NSUMs ICZpb2MpOwogCi0JLyogTm9uc2Vuc2UgZmxhZ3MuICovCi0JaW9jLmZsYWdzID0gMHhkZWFkYmVl ZjsKKwkvKiBWYWxpZCBub29wLCBidXQgd2l0aCBldmVudCBzZXQgc2hvdWxkIGZhaWwuICovCisJ aW9jLmZsYWdzID0gRFJNX01PREVfUEFHRV9GTElQX0VWRU5UOwogCWRvX2lvY3RsX2VycihkZXNj LT5mZCwgRFJNX0lPQ1RMX01PREVfQVRPTUlDLCAmaW9jLCBFSU5WQUwpOwogCi0JLyogU3BlY2lm aWNhbGx5IGZvcmJpZGRlbiBjb21iaW5hdGlvbi4gKi8KLQlpb2MuZmxhZ3MgPSBEUk1fTU9ERV9B VE9NSUNfVEVTVF9PTkxZIHwgRFJNX01PREVfUEFHRV9GTElQX0VWRU5UOworCS8qIE5vbnNlbnNl IGZsYWdzLiAqLworCWlvYy5mbGFncyA9IDB4ZGVhZGJlZWY7CiAJZG9faW9jdGxfZXJyKGRlc2Mt PmZkLCBEUk1fSU9DVExfTU9ERV9BVE9NSUMsICZpb2MsIEVJTlZBTCk7CiAKIAlpb2MuZmxhZ3Mg PSAwOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1k LWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==