dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper
Date: Thu, 29 May 2014 16:00:37 +0200	[thread overview]
Message-ID: <3002835.ly8JuaRppI@avalon> (raw)
In-Reply-To: <1401337998-18085-1-git-send-email-sachin.kamat@linaro.org>

Hi Sachin,

Thank you for the patch.

On Thursday 29 May 2014 10:03:18 Sachin Kamat wrote:
> Makes the code a bit more readable.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_gem_cma_helper.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
> b/drivers/gpu/drm/drm_gem_cma_helper.c index 05c97c5350a1..e467e67af6e7
> 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -327,7 +327,7 @@ drm_gem_cma_prime_import_sg_table(struct drm_device
> *dev, size_t size, /* Create a CMA GEM buffer. */
>  	cma_obj = __drm_gem_cma_create(dev, size);
>  	if (IS_ERR(cma_obj))
> -		return ERR_PTR(PTR_ERR(cma_obj));
> +		return ERR_CAST(cma_obj);
> 
>  	cma_obj->paddr = sg_dma_address(sgt->sgl);
>  	cma_obj->sgt = sgt;

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2014-05-29 14:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  4:33 [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper Sachin Kamat
2014-05-29 14:00 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3002835.ly8JuaRppI@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox