Re: [PATCH 35/37] drm: Eliminate the useless "non-RGB fb" debug message

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Ville,

Thank you for the patch.

On Friday 18 Nov 2016 21:53:11 ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> No point in spamming the log whenever a non-RGB fb is being
> constructed. And since there's nothing to do anymore that
> fb->bits_per_pixel and fb->depth are gone, we can just kill
> off this entire piece of code.
> 
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_modeset_helper.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_modeset_helper.c
> b/drivers/gpu/drm/drm_modeset_helper.c index 639e474e7d43..5b051859b8d3
> 100644
> --- a/drivers/gpu/drm/drm_modeset_helper.c
> +++ b/drivers/gpu/drm/drm_modeset_helper.c
> @@ -72,21 +72,10 @@ void drm_helper_mode_fill_fb_struct(struct drm_device
> *dev, struct drm_framebuffer *fb,
>  				    const struct drm_mode_fb_cmd2 *mode_cmd)
>  {
> -	const struct drm_format_info *info;
>  	int i;
> 
> -	info = drm_format_info(mode_cmd->pixel_format);
> -	if (!info || !info->depth) {
> -		struct drm_format_name_buf format_name;
> -
> -		DRM_DEBUG_KMS("non-RGB pixel format %s\n",
> -		              drm_get_format_name(mode_cmd->pixel_format,
> -		                                  &format_name));
> -	} else {
> -	}
> -
>  	fb->dev = dev;
> -	fb->format = info;
> +	fb->format = drm_format_info(mode_cmd->pixel_format);
>  	fb->width = mode_cmd->width;
>  	fb->height = mode_cmd->height;
>  	for (i = 0; i < 4; i++) {

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel