From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 08/32] drm/exynos: Remove dpms link between encoder/connector Date: Fri, 08 Nov 2013 22:45:53 +0100 Message-ID: <3189394.QzR5WfSHpU@flatron> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-9-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 41890FC2A5 for ; Fri, 8 Nov 2013 13:45:54 -0800 (PST) Received: by mail-ea0-f170.google.com with SMTP id q10so1165005eaj.29 for ; Fri, 08 Nov 2013 13:45:53 -0800 (PST) In-Reply-To: <1383063198-10526-9-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Sean Paul Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org On Tuesday 29 of October 2013 12:12:54 Sean Paul wrote: > This patch removes the call from encoder dpms into connector dpms (which > will then call back into encoder dpms through the helper function). The > callback is likely to keep connector->dpms in the right state when > initiating dpms from crtc or encoder, but this isn't the right way to > do it. This patch is the first step towards rationalizing power > management in the exynos drm driver. > > Signed-off-by: Sean Paul > --- > > Changes in v2: > - Split out the apply change into a new patch > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_connector.c | 42 > ++-------------------- drivers/gpu/drm/exynos/exynos_drm_connector.h | > 4 --- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 50 > +++------------------------ 3 files changed, 8 insertions(+), 88 > deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz