* linux-next-20251029 - build error in amdgpu
@ 2025-10-30 17:20 Valdis Klētnieks
2025-10-30 18:05 ` Timur Kristóf
0 siblings, 1 reply; 13+ messages in thread
From: Valdis Klētnieks @ 2025-10-30 17:20 UTC (permalink / raw)
To: Timur Krist?f, Alex Deucher
Cc: Leo Li, David Airlie, amd-gfx, dri-devel, linux-kernel
Hit this error while building next-20251029 with W=1 and gcc (GCC) 15.2.1 20251022 (Red Hat 15.2.1-3
CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.o
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:1571:69: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
1571 | static const struct stream_encoder_funcs dce110_an_str_enc_funcs = {0};
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:1571:69: note: (near initialization for 'dce110_an_str_enc_funcs')
cc1: some warnings being treated as errors
Caused by:
commit deb072d241c906ae378bc88ff91dfcdc34ebe71a
Author: Timur Krist?f <timur.kristof@gmail.com>
Date: Fri Sep 26 20:01:51 2025 +0200
drm/amd/display: Implement DCE analog stream encoders
\0\0\0\0\0\0\0\0
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: linux-next-20251029 - build error in amdgpu 2025-10-30 17:20 linux-next-20251029 - build error in amdgpu Valdis Klētnieks @ 2025-10-30 18:05 ` Timur Kristóf 2025-11-02 0:59 ` Valdis Klētnieks 0 siblings, 1 reply; 13+ messages in thread From: Timur Kristóf @ 2025-10-30 18:05 UTC (permalink / raw) To: Valdis Klētnieks, Alex Deucher Cc: Leo Li, David Airlie, amd-gfx, dri-devel, linux-kernel On Thu, 2025-10-30 at 13:20 -0400, Valdis Klētnieks wrote: > Hit this error while building next-20251029 with W=1 and gcc (GCC) > 15.2.1 20251022 (Red Hat 15.2.1-3 Hi, Can you say how to reproduce that? I use the same version of GCC but it hasn't given me any warning or error for that patch. Thanks & best regards, Timur > > CC [M] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.o > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:157 > 1:69: error: positional initialization of field in 'struct' declared > with 'designated_init' attribute [-Werror=designated-init] > 1571 | static const struct stream_encoder_funcs > dce110_an_str_enc_funcs = {0}; > > | > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:157 > 1:69: note: (near initialization for 'dce110_an_str_enc_funcs') > cc1: some warnings being treated as errors > > Caused by: > commit deb072d241c906ae378bc88ff91dfcdc34ebe71a > Author: Timur Krist?f <timur.kristof@gmail.com> > Date: Fri Sep 26 20:01:51 2025 +0200 > > drm/amd/display: Implement DCE analog stream encoders > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-10-30 18:05 ` Timur Kristóf @ 2025-11-02 0:59 ` Valdis Klētnieks 2025-11-02 9:27 ` Timur Kristóf 0 siblings, 1 reply; 13+ messages in thread From: Valdis Klētnieks @ 2025-11-02 0:59 UTC (permalink / raw) To: Timur Kristóf Cc: Alex Deucher, Leo Li, David Airlie, amd-gfx, dri-devel, linux-kernel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 738 bytes --] On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > Can you say how to reproduce that? > I use the same version of GCC but it hasn't given me any warning or > error for that patch. Upon further testing, [/usr/src/linux-next] make is sufficient on my system. Turns out that it errors out even without W=1. My next guess was that it had to do with -Werror, which would cause warnings to be treated as errors, but my .config has # CONFIG_WERROR is not set # CONFIG_DRM_WERROR is not set # CONFIG_DRM_AMDGPU_WERROR is not set Do you perhaps have patches in your tree that aren't in next-20251029? I wonder if Fedora's build of gcc 15.2.1 is different somehow from the build you're using.... \0\0\0\0\0\0\0\0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-02 0:59 ` Valdis Klētnieks @ 2025-11-02 9:27 ` Timur Kristóf 2025-11-06 2:34 ` Amit Dhingra 0 siblings, 1 reply; 13+ messages in thread From: Timur Kristóf @ 2025-11-02 9:27 UTC (permalink / raw) To: Valdis Klētnieks Cc: Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1239 bytes --] Hello Valdis, I use Fedora and I developed that patch on Fedora, using the same GCC version. It did not give me an error or warning when I wrote the patch. It is still not giving me an error or warning about that code now. I am working with the amd-staging-drm-next branch. What do I need to do to trigger the warning? Thanks & best regards, Timur Valdis Klētnieks <valdis.kletnieks@vt.edu> ezt írta (időpont: 2025. nov. 2., Vas 1:59): > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > > > Can you say how to reproduce that? > > I use the same version of GCC but it hasn't given me any warning or > > error for that patch. > > Upon further testing, > > [/usr/src/linux-next] make > > is sufficient on my system. Turns out that it errors out even without W=1. > My > next guess was that it had to do with -Werror, which would cause warnings > to > be treated as errors, but my .config has > > # CONFIG_WERROR is not set > # CONFIG_DRM_WERROR is not set > # CONFIG_DRM_AMDGPU_WERROR is not set > > Do you perhaps have patches in your tree that aren't in next-20251029? > > I wonder if Fedora's build of gcc 15.2.1 is different somehow from the > build you're using.... > > > > [-- Attachment #2: Type: text/html, Size: 1797 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-02 9:27 ` Timur Kristóf @ 2025-11-06 2:34 ` Amit Dhingra 2025-11-06 2:40 ` Timur Kristóf 2025-11-06 3:18 ` Valdis Klētnieks 0 siblings, 2 replies; 13+ messages in thread From: Amit Dhingra @ 2025-11-06 2:34 UTC (permalink / raw) To: Timur Kristóf Cc: Valdis Klētnieks, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel On Sun, Nov 02, 2025 at 10:27:54AM +0100, Timur Kristóf wrote: > Hello Valdis, > > I use Fedora and I developed that patch on Fedora, using the same GCC > version. It did not give me an error or warning when I wrote the patch. It > is still not giving me an error or warning about that code now. > > I am working with the amd-staging-drm-next branch. > > What do I need to do to trigger the warning? > I have the same problem. linux-next on Arch Linux GCC : 15.2.1 20250813 Steps to reproduce the error - make mrproper - make allmodconfig - make drivers/gpu/drm/amd/amdgpu/ Turns out its due to randconfig, See [1] Setting RANDSTRUCT_NONE=y seems to stop the error. [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/ - Amit > Thanks & best regards, > Timur > > Valdis Klētnieks <valdis.kletnieks@vt.edu> ezt írta (időpont: 2025. nov. > 2., Vas 1:59): > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > > > > > Can you say how to reproduce that? > > > I use the same version of GCC but it hasn't given me any warning or > > > error for that patch. > > > > Upon further testing, > > > > [/usr/src/linux-next] make > > > > is sufficient on my system. Turns out that it errors out even without W=1. > > My > > next guess was that it had to do with -Werror, which would cause warnings > > to > > be treated as errors, but my .config has > > > > # CONFIG_WERROR is not set > > # CONFIG_DRM_WERROR is not set > > # CONFIG_DRM_AMDGPU_WERROR is not set > > > > Do you perhaps have patches in your tree that aren't in next-20251029? > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow from the > > build you're using.... > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 2:34 ` Amit Dhingra @ 2025-11-06 2:40 ` Timur Kristóf 2025-11-06 3:24 ` Amit Dhingra 2025-11-06 3:18 ` Valdis Klētnieks 1 sibling, 1 reply; 13+ messages in thread From: Timur Kristóf @ 2025-11-06 2:40 UTC (permalink / raw) To: Amit Dhingra Cc: Valdis Klētnieks, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel On Wed, 2025-11-05 at 18:34 -0800, Amit Dhingra wrote: > > > > > What do I need to do to trigger the warning? > > > I have the same problem. > > linux-next on Arch Linux > GCC : 15.2.1 20250813 > > > Steps to reproduce the error > - make mrproper > - make allmodconfig > - make drivers/gpu/drm/amd/amdgpu/ > > Turns out its due to randconfig, See [1] > > Setting RANDSTRUCT_NONE=y seems to stop the error. Can you please try and see if this fixes the warning? https://pastebin.com/raw/b8j3UABj Alternatively, if anyone has other recommendations on how to fix it, I'm also open to suggestions. Thanks, Timur > > > > Valdis Klētnieks <valdis.kletnieks@vt.edu> ezt írta (időpont: 2025. > > nov. > > 2., Vas 1:59): > > > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > > > > > > > Can you say how to reproduce that? > > > > I use the same version of GCC but it hasn't given me any > > > > warning or > > > > error for that patch. > > > > > > Upon further testing, > > > > > > [/usr/src/linux-next] make > > > > > > is sufficient on my system. Turns out that it errors out even > > > without W=1. > > > My > > > next guess was that it had to do with -Werror, which would cause > > > warnings > > > to > > > be treated as errors, but my .config has > > > > > > # CONFIG_WERROR is not set > > > # CONFIG_DRM_WERROR is not set > > > # CONFIG_DRM_AMDGPU_WERROR is not set > > > > > > Do you perhaps have patches in your tree that aren't in next- > > > 20251029? > > > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow > > > from the > > > build you're using.... > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 2:40 ` Timur Kristóf @ 2025-11-06 3:24 ` Amit Dhingra 2025-11-06 3:29 ` Timur Kristóf 2025-11-06 3:31 ` Valdis Klētnieks 0 siblings, 2 replies; 13+ messages in thread From: Amit Dhingra @ 2025-11-06 3:24 UTC (permalink / raw) To: Timur Kristóf Cc: Valdis Klētnieks, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel On Thu, Nov 06, 2025 at 03:40:52AM +0100, Timur Kristóf wrote: > On Wed, 2025-11-05 at 18:34 -0800, Amit Dhingra wrote: > > > > > > > > What do I need to do to trigger the warning? > > > > > I have the same problem. > > > > linux-next on Arch Linux > > GCC : 15.2.1 20250813 > > > > > > Steps to reproduce the error > > - make mrproper > > - make allmodconfig > > - make drivers/gpu/drm/amd/amdgpu/ > > > > Turns out its due to randconfig, See [1] > > > > Setting RANDSTRUCT_NONE=y seems to stop the error. > > Can you please try and see if this fixes the warning? > https://pastebin.com/raw/b8j3UABj The patch above defining all fields seems to fix the error. > > Alternatively, if anyone has other recommendations on how to fix it, > I'm also open to suggestions. > What seemed to also work for me is to defining the struct as below without an initialization. static const struct stream_encoder_funcs dce110_an_str_enc_funcs; Its static so should be initialized zeroed out. objdump shows correct size allocation. objdump -x dce_stream_encoder.o 0000000000000b60 l O .rodata 0000000000000130 dce110_str_enc_funcs 0000000000000a00 l O .rodata 0000000000000130 dce110_an_str_enc_funcs > Thanks, > Timur > > > > > > > > Valdis Klētnieks <valdis.kletnieks@vt.edu> ezt írta (időpont: 2025. > > > nov. > > > 2., Vas 1:59): > > > > > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > > > > > > > > > Can you say how to reproduce that? > > > > > I use the same version of GCC but it hasn't given me any > > > > > warning or > > > > > error for that patch. > > > > > > > > Upon further testing, > > > > > > > > [/usr/src/linux-next] make > > > > > > > > is sufficient on my system. Turns out that it errors out even > > > > without W=1. > > > > My > > > > next guess was that it had to do with -Werror, which would cause > > > > warnings > > > > to > > > > be treated as errors, but my .config has > > > > > > > > # CONFIG_WERROR is not set > > > > # CONFIG_DRM_WERROR is not set > > > > # CONFIG_DRM_AMDGPU_WERROR is not set > > > > > > > > Do you perhaps have patches in your tree that aren't in next- > > > > 20251029? > > > > > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow > > > > from the > > > > build you're using.... > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 3:24 ` Amit Dhingra @ 2025-11-06 3:29 ` Timur Kristóf 2025-11-06 3:32 ` Amit Dhingra 2025-11-06 3:31 ` Valdis Klētnieks 1 sibling, 1 reply; 13+ messages in thread From: Timur Kristóf @ 2025-11-06 3:29 UTC (permalink / raw) To: Amit Dhingra Cc: Valdis Klētnieks, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel On Wed, 2025-11-05 at 19:24 -0800, Amit Dhingra wrote: > On Thu, Nov 06, 2025 at 03:40:52AM +0100, Timur Kristóf wrote: > > On Wed, 2025-11-05 at 18:34 -0800, Amit Dhingra wrote: > > > > > > > > > > > What do I need to do to trigger the warning? > > > > > > > I have the same problem. > > > > > > linux-next on Arch Linux > > > GCC : 15.2.1 20250813 > > > > > > > > > Steps to reproduce the error > > > - make mrproper > > > - make allmodconfig > > > - make drivers/gpu/drm/amd/amdgpu/ > > > > > > Turns out its due to randconfig, See [1] > > > > > > Setting RANDSTRUCT_NONE=y seems to stop the error. > > > > Can you please try and see if this fixes the warning? > > https://pastebin.com/raw/b8j3UABj > > The patch above defining all fields seems to fix the error. > > > > > Alternatively, if anyone has other recommendations on how to fix > > it, > > I'm also open to suggestions. > > > > What seemed to also work for me is to defining the struct as below > without an initialization. > > static const struct stream_encoder_funcs dce110_an_str_enc_funcs; > > Its static so should be initialized zeroed out. objdump shows correct > size > allocation. > > objdump -x dce_stream_encoder.o > > 0000000000000b60 l O .rodata 0000000000000130 > dce110_str_enc_funcs > 0000000000000a00 l O .rodata 0000000000000130 > dce110_an_str_enc_funcs > Thanks! This looks even cleaner. I will submit a patch to fix the warning next week. Can I add your name and email to the Suggested-by tag? Thanks, Timur > > > Thanks, > > Timur > > > > > > > > > > > > Valdis Klētnieks <valdis.kletnieks@vt.edu> ezt írta (időpont: > > > > 2025. > > > > nov. > > > > 2., Vas 1:59): > > > > > > > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > > > > > > > > > > > Can you say how to reproduce that? > > > > > > I use the same version of GCC but it hasn't given me any > > > > > > warning or > > > > > > error for that patch. > > > > > > > > > > Upon further testing, > > > > > > > > > > [/usr/src/linux-next] make > > > > > > > > > > is sufficient on my system. Turns out that it errors out even > > > > > without W=1. > > > > > My > > > > > next guess was that it had to do with -Werror, which would > > > > > cause > > > > > warnings > > > > > to > > > > > be treated as errors, but my .config has > > > > > > > > > > # CONFIG_WERROR is not set > > > > > # CONFIG_DRM_WERROR is not set > > > > > # CONFIG_DRM_AMDGPU_WERROR is not set > > > > > > > > > > Do you perhaps have patches in your tree that aren't in next- > > > > > 20251029? > > > > > > > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow > > > > > from the > > > > > build you're using.... > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 3:29 ` Timur Kristóf @ 2025-11-06 3:32 ` Amit Dhingra 0 siblings, 0 replies; 13+ messages in thread From: Amit Dhingra @ 2025-11-06 3:32 UTC (permalink / raw) To: Timur Kristóf Cc: Valdis Klētnieks, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel On Thu, Nov 06, 2025 at 04:29:05AM +0100, Timur Kristóf wrote: > On Wed, 2025-11-05 at 19:24 -0800, Amit Dhingra wrote: > > On Thu, Nov 06, 2025 at 03:40:52AM +0100, Timur Kristóf wrote: > > > On Wed, 2025-11-05 at 18:34 -0800, Amit Dhingra wrote: > > > > > > > > > > > > > > What do I need to do to trigger the warning? > > > > > > > > > I have the same problem. > > > > > > > > linux-next on Arch Linux > > > > GCC : 15.2.1 20250813 > > > > > > > > > > > > Steps to reproduce the error > > > > - make mrproper > > > > - make allmodconfig > > > > - make drivers/gpu/drm/amd/amdgpu/ > > > > > > > > Turns out its due to randconfig, See [1] > > > > > > > > Setting RANDSTRUCT_NONE=y seems to stop the error. > > > > > > Can you please try and see if this fixes the warning? > > > https://pastebin.com/raw/b8j3UABj > > > > The patch above defining all fields seems to fix the error. > > > > > > > > Alternatively, if anyone has other recommendations on how to fix > > > it, > > > I'm also open to suggestions. > > > > > > > What seemed to also work for me is to defining the struct as below > > without an initialization. > > > > static const struct stream_encoder_funcs dce110_an_str_enc_funcs; > > > > Its static so should be initialized zeroed out. objdump shows correct > > size > > allocation. > > > > objdump -x dce_stream_encoder.o > > > > 0000000000000b60 l O .rodata 0000000000000130 > > dce110_str_enc_funcs > > 0000000000000a00 l O .rodata 0000000000000130 > > dce110_an_str_enc_funcs > > > > Thanks! This looks even cleaner. > > I will submit a patch to fix the warning next week. > Can I add your name and email to the Suggested-by tag? Certainly. Thank you!! > > Thanks, > Timur > > > > > > > > Thanks, > > > Timur > > > > > > > > > > > > > > > > Valdis Klētnieks <valdis.kletnieks@vt.edu> ezt írta (időpont: > > > > > 2025. > > > > > nov. > > > > > 2., Vas 1:59): > > > > > > > > > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said: > > > > > > > > > > > > > Can you say how to reproduce that? > > > > > > > I use the same version of GCC but it hasn't given me any > > > > > > > warning or > > > > > > > error for that patch. > > > > > > > > > > > > Upon further testing, > > > > > > > > > > > > [/usr/src/linux-next] make > > > > > > > > > > > > is sufficient on my system. Turns out that it errors out even > > > > > > without W=1. > > > > > > My > > > > > > next guess was that it had to do with -Werror, which would > > > > > > cause > > > > > > warnings > > > > > > to > > > > > > be treated as errors, but my .config has > > > > > > > > > > > > # CONFIG_WERROR is not set > > > > > > # CONFIG_DRM_WERROR is not set > > > > > > # CONFIG_DRM_AMDGPU_WERROR is not set > > > > > > > > > > > > Do you perhaps have patches in your tree that aren't in next- > > > > > > 20251029? > > > > > > > > > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow > > > > > > from the > > > > > > build you're using.... > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 3:24 ` Amit Dhingra 2025-11-06 3:29 ` Timur Kristóf @ 2025-11-06 3:31 ` Valdis Klētnieks 1 sibling, 0 replies; 13+ messages in thread From: Valdis Klētnieks @ 2025-11-06 3:31 UTC (permalink / raw) To: Amit Dhingra Cc: Timur Kristóf, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 407 bytes --] On Wed, 05 Nov 2025 19:24:22 -0800, Amit Dhingra said: > On Thu, Nov 06, 2025 at 03:40:52AM +0100, Timur Kristóf wrote: > The patch above defining all fields seems to fix the error. The bigger question is whether that patch merely papers over a bug in the gcc plugin. Basically, why does the struct being one layout compile cleanly, but throws an error if the layout is randomized... \0m> \0\0\0\0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 2:34 ` Amit Dhingra 2025-11-06 2:40 ` Timur Kristóf @ 2025-11-06 3:18 ` Valdis Klētnieks 2025-11-06 14:02 ` Kees Cook 1 sibling, 1 reply; 13+ messages in thread From: Valdis Klētnieks @ 2025-11-06 3:18 UTC (permalink / raw) To: Amit Dhingra Cc: Timur Kristóf, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel, Kees Cook, linux-hardening On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said: > I have the same problem. > ... > Setting RANDSTRUCT_NONE=y seems to stop the error. > > [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/ Wow. I wouldn't have guessed that RANDSTRUCT would be the cause... However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly. <insert Twilight Zone theme music here> Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an idea what's going on. \0\0\0\0\0\0\0\0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 3:18 ` Valdis Klētnieks @ 2025-11-06 14:02 ` Kees Cook 2025-11-06 23:49 ` Bill Wendling 0 siblings, 1 reply; 13+ messages in thread From: Kees Cook @ 2025-11-06 14:02 UTC (permalink / raw) To: Valdis Klētnieks, Amit Dhingra Cc: Timur Kristóf, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel, linux-hardening On November 5, 2025 7:18:51 PM PST, "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote: >On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said: > >> I have the same problem. >> ... > >> Setting RANDSTRUCT_NONE=y seems to stop the error. >> >> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/ > >Wow. I wouldn't have guessed that RANDSTRUCT would be the cause... >However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly. > ><insert Twilight Zone theme music here> > >Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an >idea what's going on. I'm surprised the stable team didn't find the associated fix in your linked thread. It had the right Fixes tag: https://lore.kernel.org/all/20250502224156.work.617-kees@kernel.org/ Regardless, just remove the "0" from the dce110_an_str_enc_funcs initializer; that's an older code pattern that isn't needed any more. Randstruct requires designated initializers, though I thought the macro turned that on universally, so the fact that the error is only present with randstruct seems like a separate bug. -Kees -- Kees Cook ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu 2025-11-06 14:02 ` Kees Cook @ 2025-11-06 23:49 ` Bill Wendling 0 siblings, 0 replies; 13+ messages in thread From: Bill Wendling @ 2025-11-06 23:49 UTC (permalink / raw) To: Kees Cook Cc: Valdis Klētnieks, Amit Dhingra, Timur Kristóf, Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel, linux-kernel, linux-hardening On Thu, Nov 6, 2025 at 6:13 AM Kees Cook <kees@kernel.org> wrote: > On November 5, 2025 7:18:51 PM PST, "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote: > >On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said: > > > >> I have the same problem. > >> ... > > > >> Setting RANDSTRUCT_NONE=y seems to stop the error. > >> > >> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/ > > > >Wow. I wouldn't have guessed that RANDSTRUCT would be the cause... > >However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly. > > > ><insert Twilight Zone theme music here> > > > >Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an > >idea what's going on. > > I'm surprised the stable team didn't find the associated fix in your linked thread. It had the right Fixes tag: > https://lore.kernel.org/all/20250502224156.work.617-kees@kernel.org/ > FYI, their Fixes tag points to something that doesn't exist. I found it at SHA1 e136a4062174a9a8d1c1447ca040ea81accfa6a8 though. > Regardless, just remove the "0" from the dce110_an_str_enc_funcs initializer; that's an older code pattern that isn't needed any more. > > Randstruct requires designated initializers, though I thought the macro turned that on universally, so the fact that the error is only present with randstruct seems like a separate bug. > > -Kees > > -- > Kees Cook > ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-11-06 23:50 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-10-30 17:20 linux-next-20251029 - build error in amdgpu Valdis Klētnieks 2025-10-30 18:05 ` Timur Kristóf 2025-11-02 0:59 ` Valdis Klētnieks 2025-11-02 9:27 ` Timur Kristóf 2025-11-06 2:34 ` Amit Dhingra 2025-11-06 2:40 ` Timur Kristóf 2025-11-06 3:24 ` Amit Dhingra 2025-11-06 3:29 ` Timur Kristóf 2025-11-06 3:32 ` Amit Dhingra 2025-11-06 3:31 ` Valdis Klētnieks 2025-11-06 3:18 ` Valdis Klētnieks 2025-11-06 14:02 ` Kees Cook 2025-11-06 23:49 ` Bill Wendling
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).