Re: [PATCH resend 2/4] backlight: Add backlight device (un)registration notification

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

[-- Attachment #1: Type: text/plain, Size: 3044 bytes --]

On Tuesday, May 27, 2014 10:20:33 AM Lee Jones wrote:
> > On 05/26/2014 01:03 PM, Rafael J. Wysocki wrote:
> > > On Monday, May 26, 2014 12:03:43 PM Jingoo Han wrote:
> > >> On Thursday, May 22, 2014 6:02 PM, Lee Jones wrote:
> > >>> On Thursday, May 22, 2014 5:45 PM, Hans de Goede wrote:
> > >>>> On Thursday, May 22, 2014 8:31 AM, Rafael J. Wysocki wrote:
> > >>>>> On Wednesday, May 21, 2014 10:40 PM, Hans de Goede wrote:
> > >>>>>> Some firmware drivers, ie acpi-video want to get themselves out of the
> > >>>>>> way (in some cases) when their also is a raw backlight device available.
> > >>>>>>
> > >>>>>> Due to module loading ordering being unknown, acpi-video cannot be certain
> > >>>>>> that the backlight_device_registered(BACKLIGHT_RAW) it does for this is
> > >>>>>> the final verdict wrt there being a BACKLIGHT_RAW device.
> > >>>>>>
> > >>>>>> By adding notification acpi-video can listen for backlight devices showing
> > >>>>>> up after it has loaded, and unregister its backlight device if desired.
> > >>>>>>
> > >>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > >>>>>
> > >>>>> Backlight maintainer's ACK is requisite here.
> > >>>>
> > >>>> Agreed, which is why I send this set to all 3 the backlight maintainers
> > >>>> directly on both postings.
> > >>>>
> > >>>> What may be helpful for them is to hear from you if you're ok with the
> > >>>> acpi-video bits which are actually going to use this, since those will
> > >>>> be the only user of the new backlight api (for now).
> > >>>
> > >>> I'm happy to apply any Backlight patches which have either Bryan or
> > >>> Jingoo's Ack, as they are the reviewers for the BL subsystem.
> > >>
> > >> Acked-by: Jingoo Han <jg1.han@samsung.com>
> > >>
> > >> Lee Jones,
> > >> Would you merge this patch into your backlight git tree?
> > > 
> > > Hans, does this series depend on things that I've applied already?  If so,
> > > I'd very much prefer to take this series too as a whole.
> > 
> > The 3th patch in this series:
> > " acpi-video: Unregister the backlight device if a raw one shows up later"
> > depends on my "acpi-video: Add an acpi_video_unregister_backlight function"
> > patch, which you've applied to your linux-next branch already.
> > 
> > As well as on the 2nd patch in this series:
> > "backlight: Add backlight device (un)registration notification"
> > 
> > So I agree that it is a good idea to take the whole series through your tree.
> 
> I'm fine with that.
> 
> Rafael, could you apply the set onto an immutable branch and send me a
> signed pull-request please?

You can find this patch on the branch at

git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git acpi-video

The top-most commit is 0dc6b96ac20c (ACPI / video: Add 4 new models to the
use_native_backlight DMI list).

Please feel free to pull from there if necessary, it is not going to be rebased.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]