From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 2/5] drm/atomic: Make drm_atomic_plane_disabling easier to understand. Date: Wed, 01 Mar 2017 02:53:49 +0200 Message-ID: <3325156.LUftCxXOWX@avalon> References: <1487256430-7625-1-git-send-email-maarten.lankhorst@linux.intel.com> <1487256430-7625-3-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1487256430-7625-3-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFhcnRlbiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVGh1cnNkYXkgMTYgRmVi IDIwMTcgMTU6NDc6MDcgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gVGhpcyBmdW5jdGlvbiBi ZWNvbWVzIGEgbG90IHNpbXBsZXIgd2hlbiBoYXZpbmcgcGFzc2VkIGJvdGggdGhlIG9sZCBhbmQK PiBuZXcgc3RhdGUgdG8gaXQuIExvb2tpbmcgYXQgYWxsIGNhbGxlcnMsIGl0IHNlZW1zIHRoYXQg b2xkX3BsYW5lX3N0YXRlCj4gaXMgbmV2ZXIgTlVMTCBzbyB0aGUgY2hlY2sgY2FuIGJlIGRyb3Bw ZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYyB8ICA3ICsrKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9w bGFuZV9oZWxwZXIuYyAgfCAgMiArLQo+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5o ICAgICB8IDI2ICsrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwg MTMgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYyBpbmRleCA3ZDQzMmQ5YTE4Y2YuLmVhNTQ0YmRkYzI5Ygo+IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtMTc1Nyw3ICsxNzU3LDggQEAgdm9p ZCBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzKHN0cnVjdCBkcm1fZGV2aWNlCj4gKmRl diwgaWYgKCFmdW5jcykKPiAgCQkJY29udGludWU7Cj4gCj4gLQkJZGlzYWJsaW5nID0gZHJtX2F0 b21pY19wbGFuZV9kaXNhYmxpbmcocGxhbmUsIApvbGRfcGxhbmVfc3RhdGUpOwo+ICsJCWRpc2Fi bGluZyA9IGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKG9sZF9wbGFuZV9zdGF0ZSwKPiArCQkJ CQkJICAgICAgIG5ld19wbGFuZV9zdGF0ZSk7Cj4gCj4gIAkJaWYgKGFjdGl2ZV9vbmx5KSB7Cj4g IAkJCS8qCj4gQEAgLTE4NTIsMTEgKzE4NTMsMTEgQEAgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0 X3BsYW5lc19vbl9jcnRjKHN0cnVjdAo+IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkK PiAKPiAgCQlXQVJOX09OKHBsYW5lLT5zdGF0ZS0+Y3J0YyAmJiBwbGFuZS0+c3RhdGUtPmNydGMg IT0gY3J0Yyk7Cj4gCj4gLQkJaWYgKGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKHBsYW5lLCBv bGRfcGxhbmVfc3RhdGUpICYmCj4gKwkJaWYgKGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKG9s ZF9wbGFuZV9zdGF0ZSwgcGxhbmUtPnN0YXRlKSAKJiYKPiAgCQkgICAgcGxhbmVfZnVuY3MtPmF0 b21pY19kaXNhYmxlKQo+ICAJCQlwbGFuZV9mdW5jcy0+YXRvbWljX2Rpc2FibGUocGxhbmUsIG9s ZF9wbGFuZV9zdGF0ZSk7Cj4gIAkJZWxzZSBpZiAocGxhbmUtPnN0YXRlLT5jcnRjIHx8Cj4gLQkJ CSBkcm1fYXRvbWljX3BsYW5lX2Rpc2FibGluZyhwbGFuZSwgb2xkX3BsYW5lX3N0YXRlKSkKPiAr CQkJIGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKG9sZF9wbGFuZV9zdGF0ZSwgcGxhbmUtCj5z dGF0ZSkpCj4gIAkJCXBsYW5lX2Z1bmNzLT5hdG9taWNfdXBkYXRlKHBsYW5lLCBvbGRfcGxhbmVf c3RhdGUpOwo+ICAJfQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5l X2hlbHBlci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lX2hlbHBlci5jIGluZGV4IDE0 ODY4OGZiOTIwYS4uZjRkNzBkZDVlM2U0Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9wbGFuZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmVfaGVs cGVyLmMKPiBAQCAtNDcwLDcgKzQ3MCw3IEBAIGludCBkcm1fcGxhbmVfaGVscGVyX2NvbW1pdChz dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCSAqIERyaXZlcnMgbWF5IG9wdGlvbmFsbHkgaW1w bGVtZW50IHRoZSAtPmF0b21pY19kaXNhYmxlIGNhbGxiYWNrLCBzbwo+ICAJICogc3BlY2lhbC1j YXNlIHRoYXQgaGVyZS4KPiAgCSAqLwo+IC0JaWYgKGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5n KHBsYW5lLCBwbGFuZV9zdGF0ZSkgJiYKPiArCWlmIChkcm1fYXRvbWljX3BsYW5lX2Rpc2FibGlu ZyhwbGFuZV9zdGF0ZSwgcGxhbmUtPnN0YXRlKSAmJgo+ICAJICAgIHBsYW5lX2Z1bmNzLT5hdG9t aWNfZGlzYWJsZSkKPiAgCQlwbGFuZV9mdW5jcy0+YXRvbWljX2Rpc2FibGUocGxhbmUsIHBsYW5l X3N0YXRlKTsKPiAgCWVsc2UKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuaAo+IGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaCBpbmRleCA5Y2VkYTM3 OWNlNTguLmRjMTYyNzQ5ODdjNyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fYXRvbWlj X2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaAo+IEBAIC0y MjAsMTAgKzIyMCwxMCBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfbGVnYWN5X2dhbW1hX3NldChz dHJ1Y3QgZHJtX2NydGMKPiAqY3J0YywgX19kcm1fYXRvbWljX2dldF9jdXJyZW50X3BsYW5lX3N0 YXRlKChjcnRjX3N0YXRlKS0+c3RhdGUsIFwgcGxhbmUpKSkKPiAKPiAtLyoKPiArLyoqCj4gICAq IGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nIC0gY2hlY2sgd2hldGhlciBhIHBsYW5lIGlzIGJl aW5nIGRpc2FibGVkCj4gLSAqIEBwbGFuZTogcGxhbmUgb2JqZWN0Cj4gLSAqIEBvbGRfc3RhdGU6 IHByZXZpb3VzIGF0b21pYyBzdGF0ZQo+ICsgKiBAb2xkX3BsYW5lX3N0YXRlOiBvbGQgYXRvbWlj IHBsYW5lIHN0YXRlCj4gKyAqIEBuZXdfcGxhbmVfc3RhdGU6IG5ldyBhdG9taWMgcGxhbmUgc3Rh dGUKPiAgICoKPiAgICogQ2hlY2tzIHRoZSBhdG9taWMgc3RhdGUgb2YgYSBwbGFuZSB0byBkZXRl cm1pbmUgd2hldGhlciBpdCdzIGJlaW5nCj4gZGlzYWJsZWQgKiBvciBub3QuIFRoaXMgYWxzbyBX QVJOcyBpZiBpdCBkZXRlY3RzIGFuIGludmFsaWQgc3RhdGUgKGJvdGgKPiBDUlRDIGFuZCBGQiBA QCAtMjMzLDI4ICsyMzMsMTggQEAgaW50Cj4gZHJtX2F0b21pY19oZWxwZXJfbGVnYWN5X2dhbW1h X3NldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsICogVHJ1ZSBpZiB0aGUKPiBwbGFuZSBpcyBiZWlu ZyBkaXNhYmxlZCwgZmFsc2Ugb3RoZXJ3aXNlLgo+ICAgKi8KPiAgc3RhdGljIGlubGluZSBib29s Cj4gLWRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ IC0JCQkgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpvbGRfc3RhdGUpCj4gK2RybV9hdG9taWNf cGxhbmVfZGlzYWJsaW5nKHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSwK PiArCQkJICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqbmV3X3BsYW5lX3N0YXRlKQo+ICB7Cj4g IAkvKgo+ICAJICogV2hlbiBkaXNhYmxpbmcgYSBwbGFuZSwgQ1JUQyBhbmQgRkIgc2hvdWxkIGFs d2F5cyBiZSBOVUxMIHRvZ2V0aGVyLgo+ICAJICogQW55dGhpbmcgZWxzZSBzaG91bGQgYmUgY29u c2lkZXJlZCBhIGJ1ZyBpbiB0aGUgYXRvbWljIGNvcmUsIHNvIHdlCj4gIAkgKiBnZW50bHkgd2Fy biBhYm91dCBpdC4KPiAgCSAqLwo+IC0JV0FSTl9PTigocGxhbmUtPnN0YXRlLT5jcnRjID09IE5V TEwgJiYgcGxhbmUtPnN0YXRlLT5mYiAhPSBOVUxMKSB8fAo+IC0JCShwbGFuZS0+c3RhdGUtPmNy dGMgIT0gTlVMTCAmJiBwbGFuZS0+c3RhdGUtPmZiID09IE5VTEwpKTsKPiArCVdBUk5fT04oKG5l d19wbGFuZV9zdGF0ZS0+Y3J0YyA9PSBOVUxMICYmIG5ld19wbGFuZV9zdGF0ZS0+ZmIgIT0gTlVM TCkgCnx8Cj4gKwkJKG5ld19wbGFuZV9zdGF0ZS0+Y3J0YyAhPSBOVUxMICYmIG5ld19wbGFuZV9z dGF0ZS0+ZmIgPT0gCk5VTEwpKTsKPiAKPiAtCS8qCj4gLQkgKiBXaGVuIHVzaW5nIHRoZSB0cmFu c2l0aW9uYWwgaGVscGVycywgb2xkX3N0YXRlIG1heSBiZSBOVUxMLiBJZiBzbywKPiAtCSAqIHdl IGtub3cgbm90aGluZyBhYm91dCB0aGUgY3VycmVudCBzdGF0ZSBhbmQgaGF2ZSB0byBhc3N1bWUg dGhhdCBpdAo+IC0JICogbWlnaHQgYmUgZW5hYmxlZC4KPiAtCSAqCj4gLQkgKiBXaGVuIHVzaW5n IHRoZSBhdG9taWMgaGVscGVycywgb2xkX3N0YXRlIHdvbid0IGJlIE5VTEwuIFRoZXJlZm9yZQo+ IC0JICogdGhpcyBjaGVjayBhc3N1bWVzIHRoYXQgZWl0aGVyIHRoZSBkcml2ZXIgd2lsbCBoYXZl IHJlY29uc3RydWN0ZWQKPiAtCSAqIHRoZSBjb3JyZWN0IHN0YXRlIGluIC0+cmVzZXQoKSBvciB0 aGF0IHRoZSBkcml2ZXIgd2lsbCBoYXZlIHRha2VuCj4gLQkgKiBhcHByb3ByaWF0ZSBtZWFzdXJl cyB0byBkaXNhYmxlIGFsbCBwbGFuZXMuCj4gLQkgKi8KPiAtCXJldHVybiAoIW9sZF9zdGF0ZSB8 fCBvbGRfc3RhdGUtPmNydGMpICYmICFwbGFuZS0+c3RhdGUtPmNydGM7Cj4gKwlyZXR1cm4gb2xk X3BsYW5lX3N0YXRlLT5jcnRjICYmICFuZXdfcGxhbmVfc3RhdGUtPmNydGM7Cj4gIH0KPiAKPiAg I2VuZGlmIC8qIERSTV9BVE9NSUNfSEVMUEVSX0hfICovCgotLSAKUmVnYXJkcywKCkxhdXJlbnQg UGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=