From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/gem-fb-helper: Use debug message on gem lookup failure
Date: Wed, 13 Sep 2017 05:44:59 +0300 [thread overview]
Message-ID: <3340729.1dRm1phaJg@avalon> (raw)
In-Reply-To: <1505147865-18194-2-git-send-email-noralf@tronnes.org>
Hi Noralf,
Thank you for the patch.
On Monday, 11 September 2017 19:37:45 EEST Noralf Trønnes wrote:
> GEM lookup failure can easily be triggered by userspace so make
> it a debug message, not an error message.
>
> Also remove unnecessary inner parentheses and fix alphabetical
> struct declaration order.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++--
> include/drm/drm_gem_framebuffer_helper.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index e2ca002..9cf6566
> 100644
> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> @@ -157,7 +157,7 @@ drm_gem_fb_create_with_funcs(struct drm_device *dev,
> struct drm_file *file,
>
> objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);
> if (!objs[i]) {
> - DRM_DEV_ERROR(dev->dev, "Failed to lookup GEM\n");
> + DRM_DEBUG_KMS("Failed to lookup GEM object\n");
> ret = -ENOENT;
> goto err_gem_object_put;
> }
> @@ -235,7 +235,7 @@ int drm_gem_fb_prepare_fb(struct drm_plane *plane,
> struct dma_buf *dma_buf;
> struct dma_fence *fence;
>
> - if ((plane->state->fb == state->fb) || !state->fb)
> + if (plane->state->fb == state->fb || !state->fb)
> return 0;
>
> dma_buf = drm_gem_fb_get_obj(state->fb, 0)->dma_buf;
> diff --git a/include/drm/drm_gem_framebuffer_helper.h
> b/include/drm/drm_gem_framebuffer_helper.h index db9cfa0..5ca7cdc 100644
> --- a/include/drm/drm_gem_framebuffer_helper.h
> +++ b/include/drm/drm_gem_framebuffer_helper.h
> @@ -2,8 +2,8 @@
> #define __DRM_GEM_FB_HELPER_H__
>
> struct drm_device;
> -struct drm_file;
> struct drm_fb_helper_surface_size;
> +struct drm_file;
> struct drm_framebuffer;
> struct drm_framebuffer_funcs;
> struct drm_gem_object;
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-13 2:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 16:37 [PATCH v2 1/2] drm/gem-fb-helper: Cleanup docs Noralf Trønnes
2017-09-11 16:37 ` [PATCH v2 2/2] drm/gem-fb-helper: Use debug message on gem lookup failure Noralf Trønnes
2017-09-13 2:44 ` Laurent Pinchart [this message]
2017-09-16 12:14 ` Noralf Trønnes
2017-09-13 2:44 ` [PATCH v2 1/2] drm/gem-fb-helper: Cleanup docs Laurent Pinchart
2017-09-13 13:41 ` Noralf Trønnes
2017-09-14 21:45 ` Laurent Pinchart
2017-09-20 18:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3340729.1dRm1phaJg@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox