From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH] staging/vboxvideo: Another FIXME item Date: Thu, 21 Feb 2019 17:40:05 +0100 Message-ID: <33679003-ce23-2ba0-d8c2-fd8187ecea36@redhat.com> References: <20190221155951.19855-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190221155951.19855-1-daniel.vetter@ffwll.ch> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter , DRI Development , LKML Cc: Greg Kroah-Hartman , Sam Ravnborg , Liviu Dudau List-Id: dri-devel@lists.freedesktop.org Hi, On 21-02-19 16:59, Daniel Vetter wrote: > Found while grepping around. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede > Cc: Greg Kroah-Hartman > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Liviu Dudau > --- > drivers/staging/vboxvideo/vbox_irq.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c > index 195484713365..89944134ea86 100644 > --- a/drivers/staging/vboxvideo/vbox_irq.c > +++ b/drivers/staging/vboxvideo/vbox_irq.c > @@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox) > > validate_or_set_position_hints(vbox); > drm_modeset_lock_all(dev); > + /* > + * FIXME: this needs to use drm_connector_list_iter and some real > + * locking for the actual data it changes, not the deprecated > + * drm_modeset_lock_all() shotgun approach. > + */ Question, are the locking expectations from the drm's core pov (for modesetting-drivers) *fully* (and clearly) documented somewhere? Regards, Hans > list_for_each_entry(connector, &dev->mode_config.connector_list, head) { > vbox_conn = to_vbox_connector(connector); > >