From: Marek Vasut <marex@denx.de>
To: Gustavo Padovan <gustavo@padovan.org>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/bridge: Call drm_connector_cleanup directly
Date: Wed, 5 Oct 2016 16:32:08 +0200 [thread overview]
Message-ID: <35eefd08-f480-2f58-e67d-294782e24bb0@denx.de> (raw)
In-Reply-To: <20161005142003.GF21711@joana>
On 10/05/2016 04:20 PM, Gustavo Padovan wrote:
> Hi Marek,
>
> 2016-10-05 Marek Vasut <marex@denx.de>:
>
>> On 10/05/2016 03:21 PM, Daniel Vetter wrote:
>>> On Wed, Oct 05, 2016 at 11:03:20AM +0200, Gustavo Padovan wrote:
>>>> Hi Marek,
>>>>
>>>> 2016-10-05 Marek Vasut <marex@denx.de>:
>>>>
>>>>> Remove the unnecessary wrapper functions around drm_connector_cleanup().
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>>> ---
>>>>> drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
>>>>> drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
>>>>> drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
>>>>> 3 files changed, 3 insertions(+), 18 deletions(-)
>>>>
>>>> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>
>>> Yeah, nice little cleanup. Applied to drm-misc.
>>
>> So while we're at it, I also found drivers with code like [1]. Is
>> calling the drm_connector_unregister() necessary in there at all ?
>> Or shall we convert it the same way as the three drivers above ?
>
> drm_connector_register/unregister() are not necessary anymore as this is
> handled by drm_dev_register() now. So these drivers can be clean up as
> well.
OK, got it. Patch is out.
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-10-05 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 22:23 [PATCH] drm/bridge: Call drm_connector_cleanup directly Marek Vasut
2016-10-05 9:03 ` Gustavo Padovan
2016-10-05 13:21 ` Daniel Vetter
2016-10-05 14:06 ` Marek Vasut
2016-10-05 14:20 ` Gustavo Padovan
2016-10-05 14:32 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35eefd08-f480-2f58-e67d-294782e24bb0@denx.de \
--to=marex@denx.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).