From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 5/5] drm: adv7511: Add support for i2c_new_secondary_device Date: Tue, 13 Feb 2018 14:23:30 +0200 Message-ID: <3664373.zGkbJUDGbo@avalon> References: <1518473273-6333-1-git-send-email-kbingham@kernel.org> <1518473273-6333-6-git-send-email-kbingham@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE25E8980C for ; Tue, 13 Feb 2018 12:22:59 +0000 (UTC) In-Reply-To: <1518473273-6333-6-git-send-email-kbingham@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: Hans Verkuil , Sergei Shtylyov , Neil Armstrong , David Airlie , Daniel Vetter , Kieran Bingham , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jean-Michel Hautbois , Bhumika Goyal , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxMyBGZWJy dWFyeSAyMDE4IDAwOjA3OjUzIEVFVCBLaWVyYW4gQmluZ2hhbSB3cm90ZToKPiBGcm9tOiBLaWVy YW4gQmluZ2hhbSA8a2llcmFuLmJpbmdoYW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+IAo+ IFRoZSBBRFY3NTExIGhhcyBmb3VyIDI1Ni1ieXRlIG1hcHMgdGhhdCBjYW4gYmUgYWNjZXNzZWQg dmlhIHRoZSBtYWluIEnCskMKPiBwb3J0cy4gRWFjaCBtYXAgaGFzIGl0IG93biBJwrJDIGFkZHJl c3MgYW5kIGFjdHMgYXMgYSBzdGFuZGFyZCBzbGF2ZQo+IGRldmljZSBvbiB0aGUgScKyQyBidXMu Cj4gCj4gQWxsb3cgYSBkZXZpY2UgdHJlZSBub2RlIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0IGFk ZHJlc3NlcyBzbyB0aGF0Cj4gYWRkcmVzcyBjb25mbGljdHMgd2l0aCBvdGhlciBkZXZpY2VzIG9u IHRoZSBzYW1lIGJ1cyBtYXkgYmUgcmVzb2x2ZWQgYXQKPiB0aGUgYm9hcmQgZGVzY3JpcHRpb24g bGV2ZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFt K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiAtLS0KPiB2MjoKPiAgLSBVcGRhdGUgbWlzc2lu ZyBlZGlkLWkyYyBhZGRyZXNzIHNldHRpbmcKPiAgLSBTcGxpdCBvdXQgRFQgYmluZGluZ3MKPiAg LSBSZW5hbWUgYW5kIG1vdmUgdGhlIEkyQyBkZWZhdWx0IGFkZHJlc3NlcyB0byB0aGVpciBvd24g c2VjdGlvbgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oICAg ICB8ICA2ICsrKysKPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2 LmMgfCA0MiArKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAzMyBp bnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTEuaAo+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9hZHY3NTExL2Fkdjc1MTEuaCBpbmRleCBkMDM0YjJjYjVlZWUuLjA0ZTY3NTllZTQ1Ygo+IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmgKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oCj4gQEAgLTkzLDYg KzkzLDExIEBACj4gICNkZWZpbmUgQURWNzUxMV9SRUdfQ0hJUF9JRF9ISUdICQkweGY1Cj4gICNk ZWZpbmUgQURWNzUxMV9SRUdfQ0hJUF9JRF9MT1cJCQkweGY2Cj4gCj4gKy8qIEhhcmR3YXJlIGRl ZmluZWQgZGVmYXVsdCBhZGRyZXNzZXMgZm9yIGkyYyByZWdpc3RlciBtYXBzICovCgpzL2kyYy9J MkMvID8gVGhhdCdzIHJlYWxseSBiZWNhdXNlIEkgaGFkIHRvIGZpbmQgc29tZXRoaW5nIDotKQoK UmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJv YXJkLmNvbT4KCj4gKyNkZWZpbmUgQURWNzUxMV9DRUNfSTJDX0FERFJfREVGQVVMVAkJMHgzYwo+ ICsjZGVmaW5lIEFEVjc1MTFfRURJRF9JMkNfQUREUl9ERUZBVUxUCQkweDNmCj4gKyNkZWZpbmUg QURWNzUxMV9QQUNLRVRfSTJDX0FERFJfREVGQVVMVAkJMHgzOAo+ICsKPiAgI2RlZmluZSBBRFY3 NTExX0NTQ19FTkFCTEUJCQlCSVQoNykKPiAgI2RlZmluZSBBRFY3NTExX0NTQ19VUERBVEVfTU9E RQkJCUJJVCg1KQo+IAo+IEBAIC0zMjIsNiArMzI3LDcgQEAgc3RydWN0IGFkdjc1MTEgewo+ICAJ c3RydWN0IGkyY19jbGllbnQgKmkyY19tYWluOwo+ICAJc3RydWN0IGkyY19jbGllbnQgKmkyY19l ZGlkOwo+ICAJc3RydWN0IGkyY19jbGllbnQgKmkyY19jZWM7Cj4gKwlzdHJ1Y3QgaTJjX2NsaWVu dCAqaTJjX3BhY2tldDsKPiAKPiAgCXN0cnVjdCByZWdtYXAgKnJlZ21hcDsKPiAgCXN0cnVjdCBy ZWdtYXAgKnJlZ21hcF9jZWM7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv YWR2NzUxMS9hZHY3NTExX2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEv YWR2NzUxMV9kcnYuYyBpbmRleAo+IGVmYTI5ZGI1ZmMyYi4uNWU2MWI5MjhjOWMwIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMKPiBAQCAtNTg2 LDcgKzU4Niw3IEBAIHN0YXRpYyBpbnQgYWR2NzUxMV9nZXRfbW9kZXMoc3RydWN0IGFkdjc1MTEg KmFkdjc1MTEsCj4gIAkvKiBSZWFkaW5nIHRoZSBFRElEIG9ubHkgd29ya3MgaWYgdGhlIGRldmlj ZSBpcyBwb3dlcmVkICovCj4gIAlpZiAoIWFkdjc1MTEtPnBvd2VyZWQpIHsKPiAgCQl1bnNpZ25l ZCBpbnQgZWRpZF9pMmNfYWRkciA9Cj4gLQkJCQkJKGFkdjc1MTEtPmkyY19tYWluLT5hZGRyIDw8 IDEpICsgNDsKPiArCQkJCQkoYWR2NzUxMS0+aTJjX2VkaWQtPmFkZHIgPDwgMSk7Cj4gCj4gIAkJ X19hZHY3NTExX3Bvd2VyX29uKGFkdjc1MTEpOwo+IAo+IEBAIC05NjksMTAgKzk2OSwxMCBAQCBz dGF0aWMgaW50IGFkdjc1MTFfaW5pdF9jZWNfcmVnbWFwKHN0cnVjdCBhZHY3NTExCj4gKmFkdikg ewo+ICAJaW50IHJldDsKPiAKPiAtCWFkdi0+aTJjX2NlYyA9IGkyY19uZXdfZHVtbXkoYWR2LT5p MmNfbWFpbi0+YWRhcHRlciwKPiAtCQkJCSAgICAgYWR2LT5pMmNfbWFpbi0+YWRkciAtIDEpOwo+ ICsJYWR2LT5pMmNfY2VjID0gaTJjX25ld19zZWNvbmRhcnlfZGV2aWNlKGFkdi0+aTJjX21haW4s ICJjZWMiLAo+ICsJCQkJCUFEVjc1MTFfQ0VDX0kyQ19BRERSX0RFRkFVTFQpOwo+ICAJaWYgKCFh ZHYtPmkyY19jZWMpCj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4g IAlpMmNfc2V0X2NsaWVudGRhdGEoYWR2LT5pMmNfY2VjLCBhZHYpOwo+IAo+ICAJYWR2LT5yZWdt YXBfY2VjID0gZGV2bV9yZWdtYXBfaW5pdF9pMmMoYWR2LT5pMmNfY2VjLAo+IEBAIC0xMDgyLDgg KzEwODIsNiBAQCBzdGF0aWMgaW50IGFkdjc1MTFfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmky YywgY29uc3QKPiBzdHJ1Y3QgaTJjX2RldmljZV9pZCAqaWQpIHN0cnVjdCBhZHY3NTExX2xpbmtf Y29uZmlnIGxpbmtfY29uZmlnOwo+ICAJc3RydWN0IGFkdjc1MTEgKmFkdjc1MTE7Cj4gIAlzdHJ1 Y3QgZGV2aWNlICpkZXYgPSAmaTJjLT5kZXY7Cj4gLQl1bnNpZ25lZCBpbnQgbWFpbl9pMmNfYWRk ciA9IGkyYy0+YWRkciA8PCAxOwo+IC0JdW5zaWduZWQgaW50IGVkaWRfaTJjX2FkZHIgPSBtYWlu X2kyY19hZGRyICsgNDsKPiAgCXVuc2lnbmVkIGludCB2YWw7Cj4gIAlpbnQgcmV0Owo+IAo+IEBA IC0xMTUzLDI0ICsxMTUxLDM1IEBAIHN0YXRpYyBpbnQgYWR2NzUxMV9wcm9iZShzdHJ1Y3QgaTJj X2NsaWVudCAqaTJjLAo+IGNvbnN0IHN0cnVjdCBpMmNfZGV2aWNlX2lkICppZCkgaWYgKHJldCkK PiAgCQlnb3RvIHVuaW5pdF9yZWd1bGF0b3JzOwo+IAo+IC0JcmVnbWFwX3dyaXRlKGFkdjc1MTEt PnJlZ21hcCwgQURWNzUxMV9SRUdfRURJRF9JMkNfQUREUiwgZWRpZF9pMmNfYWRkcik7Cj4gLQly ZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVnbWFwLCBBRFY3NTExX1JFR19QQUNLRVRfSTJDX0FERFIs Cj4gLQkJICAgICBtYWluX2kyY19hZGRyIC0gMHhhKTsKPiAtCXJlZ21hcF93cml0ZShhZHY3NTEx LT5yZWdtYXAsIEFEVjc1MTFfUkVHX0NFQ19JMkNfQUREUiwKPiAtCQkgICAgIG1haW5faTJjX2Fk ZHIgLSAyKTsKPiAtCj4gIAlhZHY3NTExX3BhY2tldF9kaXNhYmxlKGFkdjc1MTEsIDB4ZmZmZik7 Cj4gCj4gLQlhZHY3NTExLT5pMmNfZWRpZCA9IGkyY19uZXdfZHVtbXkoaTJjLT5hZGFwdGVyLCBl ZGlkX2kyY19hZGRyID4+IDEpOwo+ICsJYWR2NzUxMS0+aTJjX2VkaWQgPSBpMmNfbmV3X3NlY29u ZGFyeV9kZXZpY2UoaTJjLCAiZWRpZCIsCj4gKwkJCQkJQURWNzUxMV9FRElEX0kyQ19BRERSX0RF RkFVTFQpOwo+ICAJaWYgKCFhZHY3NTExLT5pMmNfZWRpZCkgewo+IC0JCXJldCA9IC1FTk9NRU07 Cj4gKwkJcmV0ID0gLUVJTlZBTDsKPiAgCQlnb3RvIHVuaW5pdF9yZWd1bGF0b3JzOwo+ICAJfQo+ IAo+ICsJcmVnbWFwX3dyaXRlKGFkdjc1MTEtPnJlZ21hcCwgQURWNzUxMV9SRUdfRURJRF9JMkNf QUREUiwKPiArCQkgICAgIGFkdjc1MTEtPmkyY19lZGlkLT5hZGRyIDw8IDEpOwo+ICsKPiAgCXJl dCA9IGFkdjc1MTFfaW5pdF9jZWNfcmVnbWFwKGFkdjc1MTEpOwo+ICAJaWYgKHJldCkKPiAgCQln b3RvIGVycl9pMmNfdW5yZWdpc3Rlcl9lZGlkOwo+IAo+ICsJcmVnbWFwX3dyaXRlKGFkdjc1MTEt PnJlZ21hcCwgQURWNzUxMV9SRUdfQ0VDX0kyQ19BRERSLAo+ICsJCSAgICAgYWR2NzUxMS0+aTJj X2NlYy0+YWRkciA8PCAxKTsKPiArCj4gKwlhZHY3NTExLT5pMmNfcGFja2V0ID0gaTJjX25ld19z ZWNvbmRhcnlfZGV2aWNlKGkyYywgInBhY2tldCIsCj4gKwkJCQkJQURWNzUxMV9QQUNLRVRfSTJD X0FERFJfREVGQVVMVCk7Cj4gKwlpZiAoIWFkdjc1MTEtPmkyY19wYWNrZXQpIHsKPiArCQlyZXQg PSAtRUlOVkFMOwo+ICsJCWdvdG8gZXJyX3VucmVnaXN0ZXJfY2VjOwo+ICsJfQo+ICsKPiArCXJl Z21hcF93cml0ZShhZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX1BBQ0tFVF9JMkNfQUREUiwK PiArCQkgICAgIGFkdjc1MTEtPmkyY19wYWNrZXQtPmFkZHIgPDwgMSk7Cj4gKwo+ICAJSU5JVF9X T1JLKCZhZHY3NTExLT5ocGRfd29yaywgYWR2NzUxMV9ocGRfd29yayk7Cj4gCj4gIAlpZiAoaTJj LT5pcnEpIHsKPiBAQCAtMTE4MSw3ICsxMTkwLDcgQEAgc3RhdGljIGludCBhZHY3NTExX3Byb2Jl KHN0cnVjdCBpMmNfY2xpZW50ICppMmMsIGNvbnN0Cj4gc3RydWN0IGkyY19kZXZpY2VfaWQgKmlk KSBJUlFGX09ORVNIT1QsIGRldl9uYW1lKGRldiksCj4gIAkJCQkJCWFkdjc1MTEpOwo+ICAJCWlm IChyZXQpCj4gLQkJCWdvdG8gZXJyX3VucmVnaXN0ZXJfY2VjOwo+ICsJCQlnb3RvIGVycl91bnJl Z2lzdGVyX3BhY2tldDsKPiAgCX0KPiAKPiAgCWFkdjc1MTFfcG93ZXJfb2ZmKGFkdjc1MTEpOwo+ IEBAIC0xMjAzLDYgKzEyMTIsOCBAQCBzdGF0aWMgaW50IGFkdjc1MTFfcHJvYmUoc3RydWN0IGky Y19jbGllbnQgKmkyYywgY29uc3QKPiBzdHJ1Y3QgaTJjX2RldmljZV9pZCAqaWQpIGFkdjc1MTFf YXVkaW9faW5pdChkZXYsIGFkdjc1MTEpOwo+ICAJcmV0dXJuIDA7Cj4gCj4gK2Vycl91bnJlZ2lz dGVyX3BhY2tldDoKPiArCWkyY191bnJlZ2lzdGVyX2RldmljZShhZHY3NTExLT5pMmNfcGFja2V0 KTsKPiAgZXJyX3VucmVnaXN0ZXJfY2VjOgo+ICAJaTJjX3VucmVnaXN0ZXJfZGV2aWNlKGFkdjc1 MTEtPmkyY19jZWMpOwo+ICAJaWYgKGFkdjc1MTEtPmNlY19jbGspCj4gQEAgLTEyMzQsNiArMTI0 NSw3IEBAIHN0YXRpYyBpbnQgYWR2NzUxMV9yZW1vdmUoc3RydWN0IGkyY19jbGllbnQgKmkyYykK PiAgCWNlY191bnJlZ2lzdGVyX2FkYXB0ZXIoYWR2NzUxMS0+Y2VjX2FkYXApOwo+IAo+ICAJaTJj X3VucmVnaXN0ZXJfZGV2aWNlKGFkdjc1MTEtPmkyY19lZGlkKTsKPiArCWkyY191bnJlZ2lzdGVy X2RldmljZShhZHY3NTExLT5pMmNfcGFja2V0KTsKPiAKPiAgCXJldHVybiAwOwo+ICB9CgotLSAK UmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=