From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A481DCD11C2 for ; Wed, 10 Apr 2024 19:55:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C54310E6E2; Wed, 10 Apr 2024 19:55:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=cknow.org header.i=@cknow.org header.b="Qmkk2P6A"; dkim-atps=neutral X-Greylist: delayed 503 seconds by postgrey-1.36 at gabe; Wed, 10 Apr 2024 19:55:33 UTC Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EC2B10E6E2 for ; Wed, 10 Apr 2024 19:55:33 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1712778428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HTMX4XGvOpzyNxVflhRx4NfOt2Vj+LsvHzJX5SgXyZM=; b=Qmkk2P6AwiAybwySdf8VZSr825+Rp1DtfZTwfMdIY7HDpyPGzB1Fu1cUnd+K/tOefK7anM rd/0AwqoFin4BslePzPNJvi7nLXkLR4KNP17ZcWJE+Qi1rNPk3b4HyX46CT1ksWsciYOaV KjAEl2Pn40GxA660alIIZTttJNPI5OSA63FdWxaV2nCmXjOcogKVERJ4N3609vZ6c/6DNF KJHOdbMhHmMnRlir+Yhn20q/fv04gptq/vJSv+x52r0DQYJq61jDwVAlXuE874XzLeur77 nWGyRBLQvH9s5D/RDAyzkZANOJg1AjftwmXoDOrqmy+jauAOl8KDfOpMrYxVkQ== From: Diederik de Haas To: Maxime Ripard , Geert Uytterhoeven Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, Jani Nikula , Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on Date: Wed, 10 Apr 2024 21:46:54 +0200 Message-ID: <3688196.Heb4DZiL54@bagend> Organization: Connecting Knowledge In-Reply-To: References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3085996.ce5DWXnqYG"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --nextPart3085996.ce5DWXnqYG Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Diederik de Haas Date: Wed, 10 Apr 2024 21:46:54 +0200 Message-ID: <3688196.Heb4DZiL54@bagend> Organization: Connecting Knowledge In-Reply-To: MIME-Version: 1.0 On Tuesday, 9 April 2024 11:26:25 CEST Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, 27 Mar 2024, Maxime Ripard wrote: > > Jani recently pointed out that the Kconfig symbols are a bit difficult > > to work with at the moment when they depend on each other, and that > > using depends on would be a better idea, but no one really did the work > > so far. > > > > So here it goes :) > > > > It's been tested by comparing the riscv defconfig, arm > > multi_v7_defconfig, arm64 defconfig, drm-misc-arm, drm-misc-arm64 and > > drm-misc-x86 before and after this series and making sure they are > > identical. > > That is not true: comparing drm-misc/for-linux-next to v6.9-rc2, > arm/multi_v7_defconfig, arm64/defconfig, and riscv/defconfig lost > several of: > - CONFIG_DRM_DW_HDMI, > - CONFIG_DRM_DW_HDMI_AHB_AUDIO, > - CONFIG_DRM_DW_HDMI_CEC, > - CONFIG_DRM_DW_HDMI_I2S_AUDIO, > - CONFIG_DRM_IMX_HDMI. > - CONFIG_DRM_MESON_DW_HDMI, > - CONFIG_DRM_RCAR_DW_HDMI, > - CONFIG_DRM_SUN8I_DW_HDMI, > - CONFIG_ROCKCHIP_DW_HDMI, > - CONFIG_SND_MESON_G12A_TOHDMITX, > > > Let me know what you think, > > IMHO this series looks like a big usuability issue for anyone > configuring the kernel, and you try to work around this by sprinkling > "default y" around. > > The user should not need to know which helpers are needed for the driver > he is interested in. When a symbol selects another symbol, it should > just make sure the dependencies of the target symbol are met. > > Thanks for reverting ;-) I *think* that I ran into this issue (but it may also be KEBKAC). I tried to build a Debian arm64 kernel from 6.9-rc3 with a number of drm-misc- next patches, including this patch set. debian/config/arm64/config: CONFIG_DRM_SUN8I_DW_HDMI=m In my 6.7.9 kernel the sun8i-drm-hdmi module got build. (as well as meson_dw_hdmi, although it does not have an explicit configuration for it, but there appears a similarity with it in the `drm: Make drivers depends on DRM_DW_HDMI` commit) But in my newly build kernel both are NOT build. While I can't complain about meson_dw_hdmi, I would have expected the sun8i- drm-hdmi module to be build. Cheers, Diederik PS: The Kconfig says that the module will be called `sun8i_dw_hdmi`, but that seems to be incorrect --nextPart3085996.ce5DWXnqYG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZhbsrgAKCRDXblvOeH7b bvq1AQCWuETmAhmjxyvowpjrLc/u+IYBh0PwB08fkWCmCv+HXgEAt9qM3PNgc04c 9HHAXN5cSjjo3bslRseoFhXzizCtMgA= =XwbC -----END PGP SIGNATURE----- --nextPart3085996.ce5DWXnqYG--