From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: shmob_drm: Check clk_prepare_enable() return value Date: Wed, 04 Dec 2013 02:38:21 +0100 Message-ID: <37481163.oH5TkQcYhz@avalon> References: <1385945540-20710-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20131203095923.GD21178@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0151549539==" Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 7490EFB86A for ; Tue, 3 Dec 2013 17:38:22 -0800 (PST) In-Reply-To: <20131203095923.GD21178@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Thierry Reding Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0151549539== Content-Type: multipart/signed; boundary="nextPart2709928.G9VmhVFzRc"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart2709928.G9VmhVFzRc Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Thierry, On Tuesday 03 December 2013 10:59:24 Thierry Reding wrote: > On Mon, Dec 02, 2013 at 01:52:20AM +0100, Laurent Pinchart wrote: > [...] > > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > > b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > [...] > > > @@ -170,7 +178,9 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc > > *scrtc) > > return; > > > > /* Enable clocks before accessing the hardware. */ > > - shmob_drm_clk_on(sdev); > > + ret = shmob_drm_clk_on(sdev); > > + if (ret < 0) > > + return; > > Perhaps this should be printing an error or using WARN_ON()? Otherwise > it might be very difficult to diagnose what's going wrong. That's a good point. In practice, as the driver always uses a Renesas SoC MSTP clock, the clock code will print a message to the kernel log though, so I'm not sure whether we should duplicate that here. If you think we should I'll submit a new patch. -- Regards, Laurent Pinchart --nextPart2709928.G9VmhVFzRc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAABAgAGBQJSnoeSAAoJEIkPb2GL7hl1uVEIAKP3pbWbE08/ZbdnGdTSGiiz fE2Lh8EXmeO+32Pscf3AhxBX+zNTwOi0CcxLu5e9zRXOhbvwlNk4nSypqbk9GyTV mGQGiiRdsTxuRlsvWSDC9YjA3LPuUc5g+La89jiSKN/44OJ+s/hEWBrAcXC2XfuI /ezsreSKEdvylKEOaMRuAttwX0vjyiO7EA+YqJTRfSRTMwuTI4QHmqu3TqS3KucI /C0VEwwTTmP6uj8hciMFf4CkMNY97ONYRP45WRRAUAWJ6QB5ZlG38hEjzZ7KjKiW 9y6oT4j0M/BRClDt1MrUQOP6Fpfnv1iJ48KBLvdZRjgUdCbWS1ut0dWYxP+qpKs= =2K+P -----END PGP SIGNATURE----- --nextPart2709928.G9VmhVFzRc-- --===============0151549539== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0151549539==--